From: Peter Xu <peterx@redhat.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Lokesh Gidra <lokeshgidra@google.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
aarcange@redhat.com, david@redhat.com,
zhengqi.arch@bytedance.com, kaleshsingh@google.com,
ngeoffray@google.com
Subject: Re: [PATCH] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE
Date: Wed, 10 Apr 2024 13:09:57 -0400 [thread overview]
Message-ID: <ZhbH5TepRnNZu82l@x1n> (raw)
In-Reply-To: <CAJuCfpGj5xk-NxSwW6Mt8NGZcV9N__8zVPMGXDPAYKMcN9=Oig@mail.gmail.com>
On Thu, Apr 04, 2024 at 02:07:45PM -0700, Suren Baghdasaryan wrote:
> Yes, I was typing my reply :)
> This might have happened simply because lock_vma_under_rcu() was
> originally developed to handle only anonymous page faults and then got
> expanded to cover file-backed cases as well. Your suggestion seems
> fine to me but I would feel much more comfortable after Matthew (who
> added file-backed support) reviewed it.
Thanks.
Just in case this will fall through the cracks (while I still think we
should do it..), I sent a formal patch just now with some more information
in the commit log. Any further review comments welcomed there.
--
Peter Xu
prev parent reply other threads:[~2024-04-10 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 17:17 Lokesh Gidra
2024-04-04 17:21 ` Matthew Wilcox
2024-04-04 20:07 ` Suren Baghdasaryan
[not found] ` <adce9a6f-fccf-4c9b-8ca3-3140a6a3d326@redhat.com>
2024-04-04 20:23 ` Suren Baghdasaryan
2024-04-04 20:37 ` Andrew Morton
2024-04-04 20:32 ` Peter Xu
2024-04-04 20:55 ` Suren Baghdasaryan
2024-04-04 21:04 ` Peter Xu
2024-04-04 21:07 ` Suren Baghdasaryan
2024-04-10 17:09 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhbH5TepRnNZu82l@x1n \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=ngeoffray@google.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox