From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A60CD11C2 for ; Wed, 10 Apr 2024 15:31:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1C096B00BD; Wed, 10 Apr 2024 11:31:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CD006B00C0; Wed, 10 Apr 2024 11:31:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 893F26B00C1; Wed, 10 Apr 2024 11:31:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 663FF6B00BD for ; Wed, 10 Apr 2024 11:31:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1402F1A072F for ; Wed, 10 Apr 2024 15:31:15 +0000 (UTC) X-FDA: 81994010910.07.950CCFE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf03.hostedemail.com (Postfix) with ESMTP id 072D52001D for ; Wed, 10 Apr 2024 15:31:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qViPEqHI; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf03.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712763065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cbi/eAWd7VhxaqxfaHTml+ueD1AIDaz+ba8OE4CCdvA=; b=FNDeG8NkpzxPTJdx0IbVgTz+Jr3cn2z/RXGVU7syyybPD3j6QmDzWF7MujEIeABzqiJ/eG Rf4wiMiA0scmiBZ1sRSPLKUQj0Zddn/UnVMi5g/yW9YRNj5Zp1B//HdY3HnvKEKDI/XU8T D7oMRlvgZBzOV76r1QDu3iwtoNtDlgI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qViPEqHI; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf03.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712763065; a=rsa-sha256; cv=none; b=Ow1/xEi8/9jtY38BrOIxHqDqFy70MqjODTEp5mxPRlh50OkzKDCyKJ/01bVXuJfzDRNDCx eSJbP1FNKUzs0S7FpDzU2zfTAZWykeY9lcrseB6YPhZArsI7fMZ0DZJhwwr+LL1M4rj9d3 Li7mQCrsrtgsdtf46NCZvDP1UHgDWLg= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43ADvQvd002584; Wed, 10 Apr 2024 15:31:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=Cbi/eAWd7VhxaqxfaHTml+ueD1AIDaz+ba8OE4CCdvA=; b=qViPEqHIuBk9CBux21zCp8UMLj//yBpq37q5ojeITXSi8J/V8GrSYW3oKyFtC8PKQ+S+ jr0OhNNdhKo+mOCUbqWdK/lNmqCc2cNxhf6ejca2zxlBcdRMMlsNZhh8pbBlSQTJ+cGT GJSo67C6hCJT5OzwqYENJ/tcY43p+woUjruAfstycZ5vCHtTWkZO+L/3B8pPB3Qre+1A kbCdGBSDon3MT4zO6YL1Ejx0HvY7IVWO2AVHuf7g7Z5i39EUrFtZIIwvsMa8nha9f8kJ 1aAEDABtFv13w7dxCcY14UBIuYa+KqH3EXEgAv0JDBI2zgg1TKSAxI54/uxGqSwdt0K6 uQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xds6k8s0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 15:31:03 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43AFV3XD021875; Wed, 10 Apr 2024 15:31:03 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xds6k8s0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 15:31:03 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43AEXDuU029966; Wed, 10 Apr 2024 15:26:47 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbj7mdf1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 15:26:47 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43AFQf4j30867974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 15:26:44 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3E2E20043; Wed, 10 Apr 2024 15:26:41 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 32FE12004F; Wed, 10 Apr 2024 15:26:41 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.29.198]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 10 Apr 2024 15:26:41 +0000 (GMT) Date: Wed, 10 Apr 2024 17:26:39 +0200 From: Sumanth Korikkar To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hughd@google.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, iii@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/shmem: Inline shmem_is_huge() for disabled transparent hugepages Message-ID: References: <20240409155407.2322714-1-sumanthk@linux.ibm.com> <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: L612PNMowBeXj8vY2YP3t3EszkoVv0Uk X-Proofpoint-ORIG-GUID: GxlMHGTjvPmiE1LhuQok0TrbcWFwqCxD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 mlxlogscore=368 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404100112 X-Rspamd-Queue-Id: 072D52001D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9frf77bi3qz8crks7tdajgbzwmcchpfn X-HE-Tag: 1712763064-308975 X-HE-Meta: U2FsdGVkX19C9yrDnkX+ZRUsjUQbUb12wAAbv0Ii/wj2Q9Ufy+llD3+uLa/TctnxcBGyNRS1N8ib/P3yX2Ao/Q1YVpV3vdBYkjrdHDfnwEOEDBXcvYTNRcR6Ghai5ZO5AiwLAPgKOJBjUmftNgyMbgccj6tH68QS2LQXHjSiABRpBotZk10vjyzBgugraG6q1LIn9r5Ajht0AdWP3dzZPHpS5KJORzRGYulwyZ34wpnMLjAK32Y+suZBs3rSBAFHRlve8A0zsQcHzLWYdQdbD6yHgjTnGVaHJx2Ou7B6Ah1BupZdPapQixQ5cQx3Q7Obf3wy9xSqK5Zlonui3Bd9kWtzKaVb3Y7T6lnaFRnAFxy9+u1XkNzWENHIlbPuiJgXcUVNu8USp23rKTKaZhbrrAIwrAqwLFJatc33dYewyjweu8Ga5r2U+abPAw2jNjhPKAxulDQwbvyMGwNBa644runOnqR7RlbEv4gV5c4YPMirh0D1tzUKYfWMd2t8caflYJKomlfigXtSsbPcOgJ30QIfbe8u1gUF42oKSUNI/IRPfMHEPMl9GCbWVQbcw96YwSOMb+kv1olhTlHfD4ObVA7e938t5+SgGE91CwuMh6Gi35LgdL3129kj0MqQY1PNd0rMuN6XMjGVrkceyraA8WOrB34X4+4KOtjmrh2xqZpl55fQd/MX4XdxwaPBg9p6DyEekMs0uu5YB9Pu+UbQ1CqgtF+PIZqXBJ2NOCfaq8dXRgBdsVldXsHZRYnGOH1SbnEsGwwq0xrgdkPvi3WmfVSuylSWOiS+iWVKUpzow11u5z9YTCTJ+Q29o+V42sYq10cs8CjC0btknRszVTcHNnBogFf441q0badbiO6o87mOOJ89wLsNn7oEyAPZpAouOEO4on/bXLc6UsNJGMZgbiRUX9Aa2eWuUsEHZjkGSwxN/FqZ4vsBAOFTKss3nCmcYeOdbd4Ir8j0/tsu2G7 vQ4otYhk +BiRyQkokDbZXSkIyzjRl7ey7fe5CFKFwWSHYq8fTYQ6V+pq1MO1jint3eocWnUOb2NOFepq/12kZNU0XJMyJu3toguT+dodWINE39E1RDGI5iSbvLxHr3CqWfdvjjPOlybLc2+/DSqAefWQB8QMMnK5lBqYzGiJ+2TF4ndWWB+AA5xUjJADRe8GE2LrYgqJrR+cEDOctLX5oTDw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 02:34:35PM +0200, David Hildenbrand wrote: > On 09.04.24 17:54, Sumanth Korikkar wrote: > > In order to minimize code size (CONFIG_CC_OPTIMIZE_FOR_SIZE=y), > > compiler might choose to make a regular function call (out-of-line) for > > shmem_is_huge() instead of inlining it. When transparent hugepages are > > disabled (CONFIG_TRANSPARENT_HUGEPAGE=n), it can cause compilation > > error. > > > > mm/shmem.c: In function ‘shmem_getattr’: > > ./include/linux/huge_mm.h:383:27: note: in expansion of macro ‘BUILD_BUG’ > > 383 | #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; }) > > | ^~~~~~~~~ > > mm/shmem.c:1148:33: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > > 1148 | stat->blksize = HPAGE_PMD_SIZE; > > > > To prevent the possible error, always inline shmem_is_huge() when > > transparent hugepages are disabled. > > > > Do you know which commit introduced that? Hi David, Currently with CONFIG_CC_OPTIMIZE_FOR_SIZE=y and expirementing with -fPIC kernel compiler option, I could see this error on s390. However, default kernel compiler options doesnt end up with the above pattern right now. I think, shmem_is_huge() for disabled transparent hugepages comes from: Commit 5e6e5a12a44c ("huge tmpfs: shmem_is_huge(vma, inode, index)") However, HPAGE_PMD_SIZE macros for !CONFIG_TRANSPARENT_HUGEPAGE originates from: Commit d8c37c480678 ("thp: add HPAGE_PMD_* definitions for !CONFIG_TRANSPARENT_HUGEPAGE") Thanks, Sumanth