From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D4ECD11C2 for ; Wed, 10 Apr 2024 16:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B0206B008C; Wed, 10 Apr 2024 12:33:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95FD86B0092; Wed, 10 Apr 2024 12:33:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8279F6B0093; Wed, 10 Apr 2024 12:33:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5FEA36B008C for ; Wed, 10 Apr 2024 12:33:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1ED3114064C for ; Wed, 10 Apr 2024 16:33:55 +0000 (UTC) X-FDA: 81994168830.30.F34FFDA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 2370480009 for ; Wed, 10 Apr 2024 16:33:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UxM7bIKO; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712766832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UqUP56LAHm5QWmZInX2pt0/23Oe37lP9qAH/Ei2rnL0=; b=NdXwCsH4H9ixw7NijsuEciFocHvOukE9+ZtvQqH/KM1vq5kyRSV+8WIVc5afjzQjXj+OXE LX6EHf7hgZCDu9jrxQ/VX+WyQqsdwAheB3gEVFCnKBsJ/V5zDsqNyGRczlpr0Cg6tUbYfR FEXMyoK8LV7qXxzkREBBNEa9Xuj3lLI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712766832; a=rsa-sha256; cv=none; b=pPQbSLZHgLhLOeZfAIV9BCUWwK4Ywm2J+1AQlxK6LY70udRVYtPsGDQ8fm+vu35ZZqEAg/ sMdJu6Sf00LI+Vnxap1mDpXHHchZcpW86/4fiaXA+s0ufz1RxAcckJXZOO7cUbjZl1mN3z UX2XzmQVXXEqSFuI6JJ45dStiCkadm0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UxM7bIKO; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712766831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqUP56LAHm5QWmZInX2pt0/23Oe37lP9qAH/Ei2rnL0=; b=UxM7bIKO2WG4xHB55887S6UcB8fNuQYTbOv4jmlVxY66c27gi4DLEEuZKJ1DMtYLPE41lP NlJQo1BqYGNXBAsBejLt7RKFhb0aVptbHMZs9u8TRgk6b5jOpvdR9cdjq+UFC/N6iVtCt+ Wbk25ubNs7Wh2WeBmqPfy+6IzWER4Rs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-5Rt8q92-N7CAE1DucNRkAg-1; Wed, 10 Apr 2024 12:33:50 -0400 X-MC-Unique: 5Rt8q92-N7CAE1DucNRkAg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69945bfdbfdso1737466d6.0 for ; Wed, 10 Apr 2024 09:33:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712766829; x=1713371629; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UqUP56LAHm5QWmZInX2pt0/23Oe37lP9qAH/Ei2rnL0=; b=qdwuEO/VCcOAqfMIhHyDDe3bisFd55aLiseFg5PnRqK9UQEM6fguJtNJYy6v1RaCI5 mzIeGYg2chG2qKGzlg/0U6JXH7axsfKqrGEPTCOXoKiSk6n2WeE9qYiZwFKSltMUSqFA Q7Ze/eA7u8oAfi0oPdwL5rY1H+uDA8/sU5bWAXgr1OUAh0pb+AYFGjavqCEh+D9/Nryg 3o0ybMrs3Tet9D30eI2pTaexi0QdHdqgSTm7r8yDZL+IG2j7rORW+SZC6j6dWNyNCtTN zwEWzO0Qa6JNK5SSpo4MfELl5820Xv+UgiMjacqPr5NpZVxc/qF7wXKTK4cwkEo+Wl3C 6vMg== X-Forwarded-Encrypted: i=1; AJvYcCUpq2maoU42Tmos3cmrKwy3J3H2M51x56DLXhkRtVwcA61PFJCl1ZmEqG1oXjp4/zTUuieBwaP35lIyaHq21KogG+k= X-Gm-Message-State: AOJu0Yzm1qUMxd31gsNqUBpepp+nluYO/Ij5evRtU3flQbOWxmNYdUne 7opYKuvBMjWMf418A1t1caIvon23bezqcYbqIfb0VeuSUzyTlZGNVngu/E7wD7wqG8pHy1Dpyyi ncd6t3TF4NRdu77EyQXcVDV//Yh0T/a/p2AasszlEzcxr+fBl X-Received: by 2002:a05:6214:3018:b0:699:4a1:e12d with SMTP id ke24-20020a056214301800b0069904a1e12dmr3340422qvb.0.1712766829174; Wed, 10 Apr 2024 09:33:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhHEeK0Z21Hv+XY+0uQzZDjNJnCyA6fiR8by+XEvbvIcY63kybP9mgoWUYTyVjx2wWFUSKrg== X-Received: by 2002:a05:6214:3018:b0:699:4a1:e12d with SMTP id ke24-20020a056214301800b0069904a1e12dmr3340388qvb.0.1712766828551; Wed, 10 Apr 2024 09:33:48 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id u10-20020a05621411aa00b0069b407ac4fasm529376qvv.6.2024.04.10.09.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 09:33:48 -0700 (PDT) Date: Wed, 10 Apr 2024 12:33:46 -0400 From: Peter Xu To: David Hildenbrand Cc: Sumanth Korikkar , akpm@linux-foundation.org, linux-mm@kvack.org, hughd@google.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, iii@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH] mm/shmem: Inline shmem_is_huge() for disabled transparent hugepages Message-ID: References: <20240409155407.2322714-1-sumanthk@linux.ibm.com> <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> <29b613a8-f0d5-4f5f-adbc-d64ed8908044@redhat.com> <1ce2fe6c-b56a-4582-a5d8-babc8fccef52@redhat.com> MIME-Version: 1.0 In-Reply-To: <1ce2fe6c-b56a-4582-a5d8-babc8fccef52@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2370480009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8p7b57wbjjxu9oba9x8rqttengr3zgxe X-HE-Tag: 1712766831-722009 X-HE-Meta: U2FsdGVkX192UsKYlknjYaFd8StOY2imRaXW/Bl+nbSNnk3BSXNbbb98gcZ/G32FhfOvVepq63v0DfbdA3XWd6pnpOGbCbk4ahjEtAdjHiZ/fG+Dj/GJAG/LA66aUjsM919t8/++qat6hhfRAY7fychH6tg4sPlary1hsKcoY6865CPbLnCdem10OONhzv9oK0X+dOdsVIdzu/3J+3DuCosbFW5FkH+5c3mVNNrCHLoZ0X7kDPCu6clnZobGbAe1DTN/xvXs1GOBfF1IBBj8Tb0HyRLHW8hK7Ozf6XfiLuw1SBQ5yVVm99KjDhTsd0AAnmz4s2KBaibsVbbWfy1JFBCm3nMONJTde6CT1fPzIAjAll5PCa4IMlvjEWQSJmspYWWbzVF2cmUngLN4kPYwZSyIX8GuH7uscZuzDKHtFdJMNvCk/bygpX67Jh6vfuxQBIj6rbgj7zcLMYjR8D/zaSP+JBk3cv4NCSZmHXtQ+JCey0gT09JKuS5VV0GY0Q+LCq8oYQEQlZd7uhdariyRSl2/lY2g2nFUo6vqkdTgqe0Ha33PsP77qYftRyw97GI/r106nrcIbz83fXRyw9GQH8vtJYuI7ibfdLEgaLZm1qqKkK71R5LL9Lsi3ClkhFY9c1q/wwmJG2ELVWsW1JHKbDe8Hs9X5+pq9URSm6BTZPiCRlj4Nk2aTmm4JngsGJA6UGC5oThuDDfjXR2Y8loJLNZMUmh1/DFAaUdrzp2r5tHjTbABka7W/dgPYtP25Q7+Y2zh1thoBR+9YTzKiVrWhLp3J0da/dRANnsmFmCkwbeiidB1v01uBmdXcCiaAOVyWHV7RMGaYq1FxxtQJioupiezN/URDsfd+4tjn/pX/0lYFRrgsrm7yyjOKoOjSgaDEmwMpJNDqZXoycAEuiY1XLU3DEudjKg+xMp7LanwCdYf+NcfXqG+4Cz2mSy3d47On0pgSw/mMQKH2P+IAbj jmY651WL 509eujK0aWUmclsoT2QM54x0luBGilakw549cHzrKuIhRxEbQC/UT07kkM4r+h//VC3ondUkFy0Fn+aSBBKkXTKETZCIHEZfPnd27CuBbk3MgvbsGcK0T8cP5sEf9yI4+lVXd8ciZ7sy3KrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 06:12:34PM +0200, David Hildenbrand wrote: > On 10.04.24 18:07, Sumanth Korikkar wrote: > > On Wed, Apr 10, 2024 at 05:51:28PM +0200, David Hildenbrand wrote: > > > On 10.04.24 17:26, Sumanth Korikkar wrote: > > > > On Wed, Apr 10, 2024 at 02:34:35PM +0200, David Hildenbrand wrote: > > > > > On 09.04.24 17:54, Sumanth Korikkar wrote: > > > > > > In order to minimize code size (CONFIG_CC_OPTIMIZE_FOR_SIZE=y), > > > > > > compiler might choose to make a regular function call (out-of-line) for > > > > > > shmem_is_huge() instead of inlining it. When transparent hugepages are > > > > > > disabled (CONFIG_TRANSPARENT_HUGEPAGE=n), it can cause compilation > > > > > > error. > > > > > > > > > > > > mm/shmem.c: In function ‘shmem_getattr’: > > > > > > ./include/linux/huge_mm.h:383:27: note: in expansion of macro ‘BUILD_BUG’ > > > > > > 383 | #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; }) > > > > > > | ^~~~~~~~~ > > > > > > mm/shmem.c:1148:33: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > > > > > > 1148 | stat->blksize = HPAGE_PMD_SIZE; > > > > > > > > > > > > To prevent the possible error, always inline shmem_is_huge() when > > > > > > transparent hugepages are disabled. > > > > > > > > > > > > > > > > Do you know which commit introduced that? > > > > Hi David, > > > > > > > > Currently with CONFIG_CC_OPTIMIZE_FOR_SIZE=y and expirementing with > > > > -fPIC kernel compiler option, I could see this error on s390. > > > > > > Got it. I assume on Linus' tree, not mm/unstable? > > > > It's not yet upstream. > > > > > > > > > > > However, default kernel compiler options doesnt end up with the above > > > > pattern right now. > > > > > > Okay, just asking if this is related to recent HPAGE_PMD_SIZE changes: > > > > > > commit c1a1e497a3d5711dbf8fa6d7432d6b83ec18c26f > > > Author: Peter Xu > > > Date: Wed Mar 27 11:23:22 2024 -0400 > > > > > > mm: make HPAGE_PXD_* macros even if !THP > > > > > > Which is still in mm-unstable and not upstream. > > > > Not related to this commit. I tried on master branch. > > Thanks! Can you try with Peters patch? (ccing Peter) > > If I am not wrong, that should also resolve the issue you are seeing. David, Do you mean this one? https://lore.kernel.org/all/20240403013249.1418299-4-peterx@redhat.com/ That's indeed similar but that was for pud_pfn() not HPAGE_* stuff. I just had a quick look, Sumanth's fix looks valid, and IIUC the goal is also that we should keep these build checks around for the long term goal (Jason definitely preferred that [1] too, which I agree). I removed that build check there for pud_pfn just to avoid other build fallouts for other archs as a temporary measure. For this one if it's in common code for a long time and if it's the single spot maybe it's nice to have this patch as proposed, as it means it optimizes the if check too besides fixing the build error. After all referencing HPAGE_* with !THP+!HUGETLB shouldn't happen logically. [1] https://lore.kernel.org/r/20240404112404.GG1723999@nvidia.com Thanks, -- Peter Xu