From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E423CD11C2 for ; Wed, 10 Apr 2024 12:39:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 094426B0087; Wed, 10 Apr 2024 08:39:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0456D6B0088; Wed, 10 Apr 2024 08:39:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E77366B0089; Wed, 10 Apr 2024 08:39:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CB19D6B0087 for ; Wed, 10 Apr 2024 08:39:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8E75F1A0239 for ; Wed, 10 Apr 2024 12:39:55 +0000 (UTC) X-FDA: 81993579150.19.4E13CCE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id B47D514000F for ; Wed, 10 Apr 2024 12:39:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of cristian.marussi@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=cristian.marussi@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712752794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rGqBamJaO+mkOrCSz3MrgtkD/+vmxd/hiawB/99UKkM=; b=K9K4SXaCXDOVvSPA8/Ce8VulQ3iilpOKjMLp1GjjV0ezte8sEIXeK+zbA73zBc/XyUdfVW TyT7AT67MMQ9UD++gCZVqPfeQ9qL5L7v3FnJfHI954FtjvOMbQsRZ2stHeGYmWD+gWiu8k gXOpCwP7Nb0cgvCDr/oReE3qdU3QfF4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712752794; a=rsa-sha256; cv=none; b=5V99u+NPXRBxGiwSoSPR8YswgWsUFupBWvs/uhA6NVDgeBtcxHKft+jbsFLHPSBcXPz9qQ yoWISJCZiwg3wqe3KAHl1ohycsI0gI3mJz080HleHzhksZp94vvR6+FA4DsB15NhCa6ZAm nqrqOpQ3bHZeiVXOT7eA8GdTo8Fp6Ks= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of cristian.marussi@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=cristian.marussi@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CAA4139F; Wed, 10 Apr 2024 05:40:22 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 584D93F6C4; Wed, 10 Apr 2024 05:39:51 -0700 (PDT) Date: Wed, 10 Apr 2024 13:39:48 +0100 From: Cristian Marussi To: Kefeng Wang Cc: Aishwarya TCV , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Will Deacon , Catalin Marinas , Russell King , Andrew Morton , Mark Brown Subject: Re: [PATCH 1/2] arm64: mm: drop VM_FAULT_BADMAP/VM_FAULT_BADACCESS Message-ID: References: <20240407081211.2292362-1-wangkefeng.wang@huawei.com> <20240407081211.2292362-2-wangkefeng.wang@huawei.com> <681e3bf8-dedf-469e-8fd3-0a67b8e6e625@arm.com> <0977b553-b0ae-4e4b-8cb4-007204381c0b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0977b553-b0ae-4e4b-8cb4-007204381c0b@huawei.com> X-Rspamd-Queue-Id: B47D514000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: odp6ih3gmetropos369sksgkn6rq91dy X-HE-Tag: 1712752793-630188 X-HE-Meta: U2FsdGVkX19PDtF2OXpeaeZggdpM2q64Vr7gJeluUvHrhqWbGF/2XgeWgI6j0WwRpz/qa5xfdJz0Y+neWldcSEoW8QSOLDosGCp7ITy/lXhYOUVeCAvvwWTMbtHUFJ6IBtSI3n0Q74UpJabckUKr9/jryYkXUBYbWPvMbyPefDdwRSg2v/Jqo7/oqpy+I3/57y0TsK8sc03ree1FR6M7w4r40tdffS8xsX+2qvB7DIW657R3X0kSp4fAkUcZ8pzt4wd6MLuau2U7bjSu4pyyDLV2zeRK8EfW9EJumxL78Ey98Xa2b9tlU9Y2kVtVQlueGjMyEPqcyXcx5hDB585r0x6RCP8K8+DNfoU11NWPiPF0lCQQXy3rl/aiT0XT5A9F5pe8Pa0sL5o3TDr+Z0EuTNJ/0TjwqQHipO5RRyHxiShopWEbacNUJq7v5em6qwLWckQzNk2hKlXwnUC8BN4gukNkjnrVn44I+rGscT6WO77mJelccGgITQ7Viq9oRaigvAfHwe9m2DU0aAkTqqOWzB9D664wSJd+DmpNgNaN+A0AwJZhGnw9zi7FAleZoUpPuH754lO/vhpO1K1iKCXjdJ3B4/qxB8nww8UbrFmUUcp4UgiIplauGBLvi392HmvjLHd3Vi+DJ/Jv2Y1iwnUOBnIYeFabGXdED6m/VnBctLCSoFsAIUNZm3DZO6mFGzCZbdYPACMntbPtxI9WxRZOi9xkyhCHys9sS1JhCFatxixjcBUSgr+9jgTQAb6EjmZLuhQ8p6fKewIMlmF+SNiijiAVxplcz3HlNv8fe9g8/rwcZpUPTW7odWvLt3UCxQqv+8F7/iNTA2nKzhllY1XLNCViEU/VGE6BXjip/J2CYEWYrWcNFj9Bfty6nWXb2Isw9TIRYFn88Ur+TDVDOAmftFmA4q3Y9dxeRAnAu+DBio35+T3FyOlzlMnklHRk2cw4d5W084eK61iXrOAmz/Q BN9ZFc2i WnFdajmbkkBhj54+50mo8TRA8o+eSyy/EtCkUhRxBX8x3/s7SHLKu/2uHiAnuaqPyEMAx+kvYNG+bULiYKQgUqUocUkCZkV65zKtg3XTpAXTtSkcPlzkWSVx+g0DcVOfBW2VTNuJj2xh29Ayay9dP3H8Hiea8FcLYLwozszdPUJFWjMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 07:53:21PM +0800, Kefeng Wang wrote: > > > On 2024/4/10 19:24, Aishwarya TCV wrote: > > Hi, > > > > On 07/04/2024 09:12, Kefeng Wang wrote: > > > If bad map or access, directly set si_code to SEGV_MAPRR or SEGV_ACCERR, > > > also set fault to 0 and goto error handling, which make us to drop the > > > arch's special vm fault reason. > > > > > > Signed-off-by: Kefeng Wang > > > --- > > > arch/arm64/mm/fault.c | 41 ++++++++++++++++++----------------------- > > > 1 file changed, 18 insertions(+), 23 deletions(-) > > > > Hi Kefeng, > > > > While running LTP test suite, I observed that few test cases are unable > > to kill exe when run against next-master(next-20240409) kernel with > > Arm64 on JUNO in our CI. I can send the full logs if required, but it > > doesn't say much. > > Sorry about it, as Catalin pointed, there is issue in this patch, and > I replied today, could you help to test with following changes, many thanks. > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index 61a2acae0dca..451ba7cbd5ad 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -604,6 +604,7 @@ static int __kprobes do_page_fault(unsigned long far, > unsigned long esr, > } > > if (!(vma->vm_flags & vm_flags)) { > + mmap_read_unlock(mm); > fault = 0; > si_code = SEGV_ACCERR; > goto bad_area; > @@ -632,6 +633,7 @@ static int __kprobes do_page_fault(unsigned long far, > unsigned long esr, > if (likely(!(fault & VM_FAULT_ERROR))) > return 0; > > + si_code = SEGV_MAPERR; > bad_area: > /* > * If we are in kernel mode at this point, we have no context to > On my JUNO setup, the above patch solves the 'un-killable tests' issues and all the previously failing tests passes. (I have NOT run the full LTP test-suite, though, only replayed the tests that were failing before as mentioned by Aishwarya) Thanks, Cristian