From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5F9CD128A for ; Wed, 10 Apr 2024 16:08:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E996B0093; Wed, 10 Apr 2024 12:08:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBEB66B0095; Wed, 10 Apr 2024 12:08:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5F406B0096; Wed, 10 Apr 2024 12:08:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A89426B0093 for ; Wed, 10 Apr 2024 12:08:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 59966140872 for ; Wed, 10 Apr 2024 16:08:09 +0000 (UTC) X-FDA: 81994103898.06.D0393A7 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id 2C70840003 for ; Wed, 10 Apr 2024 16:08:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=bz+xp+Vq; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712765287; a=rsa-sha256; cv=none; b=CaAGo1Bsmok5Hd2FrY+aGtJ5h5d8/B34tavcCjjOv0nwHOSt0YCoV8ovdHBmLXzyG5tXjJ KKrb+ACIFjqJch5EwRO+pCTv4aUDX/GSYqaTi3dYTQaAqG5lsyTdpbNbY7hhmrB0otLHEG Oiy5B5hnqDPmsNE8p+LIqNyOZQRIufA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=bz+xp+Vq; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712765287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n+nI9qSzX6fe4b6bLe/CP34ytrHVPciQDdwr8ktXFOM=; b=K5HmduwoSl4aIygMGLXc1aiLzjlG9o8W8EV+47pIfjss0O92+jYnwWInXFnGeBf/4ho6XW Tio9LqvpJd8hBFTe05hCdatg6xipaNTa1nNukY1+0R6rpSp4lO9qUBLZ/Zpn5z68/9URMa 3+xhjeIO7X5W5BHTcUMRxr5haqxkUOc= Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43AG3vwA016370; Wed, 10 Apr 2024 16:08:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=n+nI9qSzX6fe4b6bLe/CP34ytrHVPciQDdwr8ktXFOM=; b=bz+xp+VqP3XyScImRa/54OkA6ZyBSnmwJML+NPsZc9HvwLrSe4pll8LRwua2lGCHnqRX wzVatIm2SwqrmKhtCEQ25WsXRsOMxNobbAKWtdR4eEnevIMwLEpYNp06ggrcw+wE0+T9 q4wFD0JNXoCh+9oVcM/ZeZanGvocN6yOJ7o2giFY2sOnrh1mh7eWY4D+pg1b9T9fcYKO mcIoGs/hlqIjjvGAiiWJMW5Xh70ny4dPMtl3+5nYxvNZxA8NoCpZ/0nYJiU/TpBRIO9S 27jwqq+FES0JeZj+DFirQXgg2G4Sbje/Wvo6IpQN+6sYOP4tG9v/QofmnpoF6Rv9uc2G 3A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdwxsr0hy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 16:08:00 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43AG80sP022647; Wed, 10 Apr 2024 16:08:00 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xdwxsr0hu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 16:08:00 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43AFb0J0016996; Wed, 10 Apr 2024 16:07:59 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbke2nbgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2024 16:07:59 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43AG7sWf33161638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 16:07:56 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFB302004D; Wed, 10 Apr 2024 16:07:53 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 451BD20043; Wed, 10 Apr 2024 16:07:53 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.29.198]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 10 Apr 2024 16:07:53 +0000 (GMT) Date: Wed, 10 Apr 2024 18:07:51 +0200 From: Sumanth Korikkar To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hughd@google.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, iii@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/shmem: Inline shmem_is_huge() for disabled transparent hugepages Message-ID: References: <20240409155407.2322714-1-sumanthk@linux.ibm.com> <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> <29b613a8-f0d5-4f5f-adbc-d64ed8908044@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <29b613a8-f0d5-4f5f-adbc-d64ed8908044@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: diLl3fzGZHAouOz23n5C0cevWaObunjs X-Proofpoint-GUID: _1YMLRsYJXVgNhSs5Kv8fJoHDrrYdjkM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 clxscore=1015 mlxlogscore=699 malwarescore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404100117 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2C70840003 X-Stat-Signature: 9ht8hg47pi9t5kuq6nkhz39k79nbcoca X-HE-Tag: 1712765285-283982 X-HE-Meta: U2FsdGVkX1/XTzwciMBJeaXmtTeHNKZlfttjLYxUCJaFxzVuDy/tNo1LiaqxCYOrVDBKpWPDXYGKzLTrxU0Eo4LEqGT8VyXp0aTiNXqf7U8W68+CRWJjv2Y62oHpZWBNnj+jy8HskR5piReqoIwPm7xsmo3EXPNdIv8ROWgZpEEEAMIhRQGyEZtI5kWrKETABQnsqh0Yi3EJwLcHcrpIL6QAFEv1repn5+pSNB52XDD+NFzt/A+JNQ9btHDo0TI8w7MfFInbUDf23thcTaTWEMcY/zFje/k0IGh/OQFBWQCxBsgLNs2o+7obzyUi0T/ChasJIiaOUhINdzYwxPxM0PZ5NeSSbP/cXQyE+nwTscSqctqCj6ZWJWCFi+R5hkraspepstHo3qVyq6juBBpZq3M0I7dglGOD+f/PyS1vy66OpJ8Q6KcNXLHOBkROwK8b8c32ZfNdYz8Ektvj5cc9O8ZsNPZpU2yWu11CNCAy7Hrywcr1ySV7Kvc7NsR2qe61r1idJWpxiPwW9CqN3x90nJLO+EnfKM8DxloihVnFBZcS71K0DI+8/TUm6tGQhRZZXPgink0sWl8/vH1UgLsRJK3KuqLLDX3Tap4bQVPhsW1qeQH21n4gzyr0qabogi8gtfERFgTAr3+x22w8OmTWKrb8BP+axBlNCl0P91R4jWaGD3HUydDSH0QkkQKnXHUIGKsGsHyUa/EHpYtw6RJQWDh4gvIS3760sUyZU4xtk9E2h4bud+JodwCmOLoC4SxPf1qHPmCqw+2ridiy574LFskdwO2JKjcv8CUEhkRzySNqM/ugJSjA4tFbqv1DDvlCp4fxj4mebar97qezmAsNDUjAW8VRMjFvTGL+EFq64Fj3lRAS1B7wIUK3GNi9EOTGTY2tvfamaMuRiK+b/8KaFSUAiAuYOeCEiJwNW4lQPMyMg/1O/fVgWSsQoEgzZVlW7R6LEdBO2ABePVGGMca fv/C9KCu ekg5I6e+d8efLvvYXh9XVvXOzRhsB1lnYPi+5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 05:51:28PM +0200, David Hildenbrand wrote: > On 10.04.24 17:26, Sumanth Korikkar wrote: > > On Wed, Apr 10, 2024 at 02:34:35PM +0200, David Hildenbrand wrote: > > > On 09.04.24 17:54, Sumanth Korikkar wrote: > > > > In order to minimize code size (CONFIG_CC_OPTIMIZE_FOR_SIZE=y), > > > > compiler might choose to make a regular function call (out-of-line) for > > > > shmem_is_huge() instead of inlining it. When transparent hugepages are > > > > disabled (CONFIG_TRANSPARENT_HUGEPAGE=n), it can cause compilation > > > > error. > > > > > > > > mm/shmem.c: In function ‘shmem_getattr’: > > > > ./include/linux/huge_mm.h:383:27: note: in expansion of macro ‘BUILD_BUG’ > > > > 383 | #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; }) > > > > | ^~~~~~~~~ > > > > mm/shmem.c:1148:33: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > > > > 1148 | stat->blksize = HPAGE_PMD_SIZE; > > > > > > > > To prevent the possible error, always inline shmem_is_huge() when > > > > transparent hugepages are disabled. > > > > > > > > > > Do you know which commit introduced that? > > Hi David, > > > > Currently with CONFIG_CC_OPTIMIZE_FOR_SIZE=y and expirementing with > > -fPIC kernel compiler option, I could see this error on s390. > > Got it. I assume on Linus' tree, not mm/unstable? It's not yet upstream. > > > > > However, default kernel compiler options doesnt end up with the above > > pattern right now. > > Okay, just asking if this is related to recent HPAGE_PMD_SIZE changes: > > commit c1a1e497a3d5711dbf8fa6d7432d6b83ec18c26f > Author: Peter Xu > Date: Wed Mar 27 11:23:22 2024 -0400 > > mm: make HPAGE_PXD_* macros even if !THP > > Which is still in mm-unstable and not upstream. Not related to this commit. I tried on master branch. Thanks, Sumanth