From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F10C4345F for ; Wed, 17 Apr 2024 12:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675E66B007B; Wed, 17 Apr 2024 08:31:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6095B6B0087; Wed, 17 Apr 2024 08:31:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 451406B0088; Wed, 17 Apr 2024 08:31:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2599D6B007B for ; Wed, 17 Apr 2024 08:31:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90696A0DEF for ; Wed, 17 Apr 2024 12:31:48 +0000 (UTC) X-FDA: 82018960296.01.8C5E361 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id C88B3C0015 for ; Wed, 17 Apr 2024 12:31:45 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1iD43Ece; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PnkGW4IO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1iD43Ece; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PnkGW4IO; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713357106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5L4Cpqhji1dUxreeRJmUVcGAtVBWN1z//jlv1xmcGEE=; b=JeZUgFigDoSEggv3gPQvpJHJS0XrmHcZM4HCzrl9R69vYHIc9jbe1CmicJJv9vG/Fs3wJl 1HLQ3DRHN7MyIoWxj/wZRIw3QAUBZwiwwq9JBAY/aqBMdD6E9V7CmcsEYy5KYEPGjgv2i6 mTB9NEeDAGbzwmxcCkDbo0WkUOedWd8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713357106; a=rsa-sha256; cv=none; b=JVytoXsLPTULE/uotI0aiuVB6OD0B+LfmRMvt8/YTTBiD5Raxp0nVEutxJ1YO9z5EO5mYr xsUChGNfeNYDDrJ8BwxLexcWe+1F7696ZoxQdhuRfnqknwbIRyI+5/qAP7hGGs16QhoDXW 3JkUwq0jigACeicTxLtpmv8gRlz+muA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1iD43Ece; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PnkGW4IO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1iD43Ece; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PnkGW4IO; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F6DD33C42; Wed, 17 Apr 2024 12:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713357104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5L4Cpqhji1dUxreeRJmUVcGAtVBWN1z//jlv1xmcGEE=; b=1iD43EceviFz+KY05gM4FjqkaP3J7tV1tRqKcpl/FycpA1bIkaqvRUxh83HFXUkkEYABzn 2Zq/qzk2EH4AHjBtNpK0owv7BUHuogUVIhcbQDwjW1eiGvmRoRilM3pYrfRKANt/U7UEFg FiIPUq6AmWzsc4FAgOBCFn80ucxCjjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713357104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5L4Cpqhji1dUxreeRJmUVcGAtVBWN1z//jlv1xmcGEE=; b=PnkGW4IOEXnDPviFaQWfyO2xr8qX1ttY0BiMCF6uvBFlGEAPhVfeLqKFJWQglXNi7HSt2n QKsuL4AofQJ2h+AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713357104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5L4Cpqhji1dUxreeRJmUVcGAtVBWN1z//jlv1xmcGEE=; b=1iD43EceviFz+KY05gM4FjqkaP3J7tV1tRqKcpl/FycpA1bIkaqvRUxh83HFXUkkEYABzn 2Zq/qzk2EH4AHjBtNpK0owv7BUHuogUVIhcbQDwjW1eiGvmRoRilM3pYrfRKANt/U7UEFg FiIPUq6AmWzsc4FAgOBCFn80ucxCjjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713357104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5L4Cpqhji1dUxreeRJmUVcGAtVBWN1z//jlv1xmcGEE=; b=PnkGW4IOEXnDPviFaQWfyO2xr8qX1ttY0BiMCF6uvBFlGEAPhVfeLqKFJWQglXNi7HSt2n QKsuL4AofQJ2h+AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D846A1384C; Wed, 17 Apr 2024 12:31:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id j187Mi/BH2bKHgAAD6G6ig (envelope-from ); Wed, 17 Apr 2024 12:31:43 +0000 Date: Wed, 17 Apr 2024 14:31:38 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Muchun Song Subject: Re: [PATCH v1 2/2] fs/proc/task_mmu: convert smaps_hugetlb_range() to work on folios Message-ID: References: <20240417092313.753919-1-david@redhat.com> <20240417092313.753919-3-david@redhat.com> <209b1956-a46f-41aa-bec1-cd65484f36cd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <209b1956-a46f-41aa-bec1-cd65484f36cd@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C88B3C0015 X-Rspam-User: X-Stat-Signature: ipfqbynuymau95im17aok9sstafj7y8m X-HE-Tag: 1713357105-745348 X-HE-Meta: U2FsdGVkX1/kYnFfCRhV9kHfC47YGnfiUc3j+36E1LQeuua5mhDeSIc6HvpPslI79eU27fo4VK2yDxP59JYLVOOlKdlMbHQqxlNE3X52GI4wXZKD8Le4Gp5oa0nDoqPt2R1aVK8o9TDvAxOwv1pSyG73V3WfITHIWwIDhsEk0fCXfUbbbwTnogIXJDK0YNxMM1rXGhpRxruW0V8Bynxlb50RvZ7KcmhCk2Eg2hJvfFyiWdtz83wr82AY/FZtR2fjOnPY6cXzPNycajXYgOXIg40ThdhmPn/+PaueT5JWGjePZ4agee63ezaVvg3v2L6cokjPZa4liXMFOPW1dLrkpmUk3jEJUJVFbV9PtfbJKoAvZblh+dif65Al7xletheBK/qcpTLjNrwRi3lfcPvbEOvJwc13g/YH5807cGhUTt6HK05bk690I9epNtbqLy/VRkux8c4dVQVjqycAelpDFshtEkjHr0vH3NZRiyh0lbDdxqcI3nm/hTQv0CMXpfgBzqmNW6KW/238PWXvUXj9blxEHOVkqhI8vTmkSSP2ClezxXJMr7R79feySgCeFJUrUnPnG6B9qXbo3BpKLegz16qpRBM1cT2BVtIyX/Ou6aYSBb6zty+01Qie902gDcsFMvM99UN/v6aQm4CnOCpmbN5T7vjWnWjJsBu0iQQAY61kjehiRayAGQ+rmIeRLXi283C6MWw1SY+d3aOLht2IPqAb5jEuJjObD7C6on5geJrQPCnlZLzeyZxOLu1ZsNA6qHffE5eX0bNTBzw41q2ucohYpK+Dv2V6deszSjh0nlfETHEt6TBaR2QkFHQ1sEnfH59gCz6E6BCtAvVW7ssmmLNXiaZAYeCkmTKAueIyII9yoWfiZhM0Q4tqI+X5n/xzAFa4MDKOQaFJH0Spo/Ab+nFSnuV9+QeURwNJZ8x1uutYxDNjec8LZ6QcGCmZajfLkQChAIrGwLb5dhwpVQ8 AEPgl28w p/jBYErcKOEiSIQv6J/PEqD597Mf9Pb0+lDzC56aNomCFk7duJGj/098KwtX0qEoQSql2cUna1C2mVxMVJKhcomQsCHdTRsqblCUmkQHrCKtSThBmjMlOvyi9Lkrf2A0JvjSRKI6hLccqlMVHk4kpjfvVgLTfrQqUjXC95eT7IrKZBqcBWC8NHHNeNvKzbNssqTIfanqcsY88lPemSW8zVB1vf1ye6+gGH/hjcYmM4kmBVrXTOweh57eu8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 02:18:10PM +0200, David Hildenbrand wrote: > On 17.04.24 14:09, Oscar Salvador wrote: > > On Wed, Apr 17, 2024 at 11:23:13AM +0200, David Hildenbrand wrote: > > > Let's get rid of another page_mapcount() check and simply use > > > folio_likely_mapped_shared(), which is precise for hugetlb folios. > > > > > > While at it, use huge_ptep_get() + pte_page() instead of ptep_get() + > > > vm_normal_page(), just like we do in pagemap_hugetlb_range(). > > > > That is fine because vm_normal_page() tries to be clever about mappings which > > hugetlb does not support, right? > > Right, using vm_normal_page() is even completely bogus. Usually (but not > always) we have PMDs/PUDs and not PTEs for mapping hugetlb pages -- where > vm_normal_folio_pmd() would be the right thing to do. > > That's also the reason why hugetlb.c has not a single user of > vm_normal_page() and friends ... it doesn't apply to hugetlb, but likely > also isn't currently harmful to use it. I guess not because we skip the special handling, but I agree that replacing it is the right thing to do. Thanks for explaining! -- Oscar Salvador SUSE Labs