From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAF2C4345F for ; Wed, 17 Apr 2024 16:54:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95EB06B0093; Wed, 17 Apr 2024 12:54:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E68A6B0095; Wed, 17 Apr 2024 12:54:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 739956B0098; Wed, 17 Apr 2024 12:54:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 561A96B0093 for ; Wed, 17 Apr 2024 12:54:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0CAD7A0EEC for ; Wed, 17 Apr 2024 16:54:45 +0000 (UTC) X-FDA: 82019622930.30.69C964E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id EE51C100006 for ; Wed, 17 Apr 2024 16:54:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kjw2DN63; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713372882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9pfdSfsDYqErxJUnuf0Vsxrj81l78d6tn6CxKCHFtJU=; b=DsEdzxXPG0bULuceVXWdKGSFOAk7Vbf8xYV4gkdF3tkQc6z2KmqXOVHMyMUCi5vbr39KvM iyGTSvBaj7/aWnVWkWJz3x9AUNdWTKvBrha8wC2zsHknOZASfta1iZv6MPEmYnSqi7Eyje OKNFz6AGlUmZEQvZ1ymk4uu6e3kIyHI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kjw2DN63; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713372882; a=rsa-sha256; cv=none; b=j6fMS6WW4GCDGis2gXXWii4Q7XUvFldiuqgMpdm42Y0ZqEx4By2mUFpGTXQs9gFnxvgpNy +TuyY/MuwxnKSCVbcDToRoc5ULU8tkGY+U4orDvR30E73Fwg+m37D08ZVidHZGYt8SP27n Na50o5DT+NgHe9QGS09IjUyIlCT61F8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713372881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9pfdSfsDYqErxJUnuf0Vsxrj81l78d6tn6CxKCHFtJU=; b=Kjw2DN63Sv6niAIyQtNtdl5r7G4KC9FzPkOMzEDUu8VZDAORG+og+DNWQGeVGlbydzb8VO mI3MsJ+4pLATMAupXN9XQjlc47HHd2joVUuaKPeEqcRhP6+nqVG8GkqPHm/i48xqi+Rlcf hGywkEf5ZorUK9/Q8xZ5LzVvXdqn+2Y= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-q_wSAHrjNUKG44Rsgd0HNA-1; Wed, 17 Apr 2024 12:54:39 -0400 X-MC-Unique: q_wSAHrjNUKG44Rsgd0HNA-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-61b027fc233so3172487b3.3 for ; Wed, 17 Apr 2024 09:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713372879; x=1713977679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9pfdSfsDYqErxJUnuf0Vsxrj81l78d6tn6CxKCHFtJU=; b=Ju7sFUWnqkv1OFVOWN71tRZm8sAjo/4KhLMo0l9rxqRCQiSDUib2XxVq9MxJCRDGPq SD/tdr5pzRHYheJz44h3KL9ks6nN4rverZkR3ZlaGjnyl3RoKHEqQAr42Agba3z8aKwR vlpDN/VMgpy8/15xpaHKEC42rtXUDv7k96ZXYOLb4S7diQnUlhZmYzp6MLmFkpiu/SK+ IQCXylJWMci+TGNTYY0ullPaCCXujLltL+AA/jQ2g4b0pt8LO4Zj5nBq1igEinysd5uJ h7pZKqQTtRH5OblFdS0wRwsrrjBvyP68Nzf/6cJIsGnJ5vw4BU8lKMmYOUKpzuqVot1E JQwA== X-Forwarded-Encrypted: i=1; AJvYcCUlog5mP28kcu48pAsA7G3yAMZKcQRV7j7T6w427Tc8lMDxyEeFx5xWRUkAOAG2GnDaQFK+sKhLRiVDAbd8lWSHxPE= X-Gm-Message-State: AOJu0Yx6laPPm52icgYxo35uVndDMHTCM8eyCecyD8nPLuaHGzgE0Tnw 1w7tKSL6f1L6LiKFrQbiGNrNeeJfYIP/kFySPsHlN/Gw7xgZtVNbTsbuiHW6e4SJHDpeQsT3VZb ADhAq3vg7x/hmJf4j9Kj9B0Xf2UatE2ZQ8NkFEV71B8Ups6l3 X-Received: by 2002:a0d:d6c8:0:b0:61a:e6c6:12b5 with SMTP id y191-20020a0dd6c8000000b0061ae6c612b5mr6316693ywd.4.1713372879171; Wed, 17 Apr 2024 09:54:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTmZXNb3HlX8X4x9Oh8ZDAGx60kf6R0AwLQP+t1uo+RSWiX7cFbrL3VDDHGtvShVBwlm+aNg== X-Received: by 2002:a0d:d6c8:0:b0:61a:e6c6:12b5 with SMTP id y191-20020a0dd6c8000000b0061ae6c612b5mr6316667ywd.4.1713372878713; Wed, 17 Apr 2024 09:54:38 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id i15-20020a0cf10f000000b006a04a3d4fbesm465147qvl.56.2024.04.17.09.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 09:54:38 -0700 (PDT) Date: Wed, 17 Apr 2024 12:54:36 -0400 From: Peter Xu To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 6398/6705] mm/page_table_check.c:194:1: warning: control reaches end of non-void function Message-ID: References: <202404171745.Zd13ydca-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202404171745.Zd13ydca-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 65kr67gcxewy9dbjtqipxihszdgamtxk X-Rspamd-Queue-Id: EE51C100006 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713372881-162286 X-HE-Meta: U2FsdGVkX19A9OYnl+riSnY8Jfr8BAffeehs+Eun0oU5Z/YJfAc3mJNLX+mB+EWTqXWdNlz/WI0uN+Lj/1umGlQoZzLdKlrv2zcsz+EPBCO4vyM+7kINlGXBK7Rfu10l2FpU428K2AHfEgpAPXKMLO6tOkw2UqFJQKzKFw0uFg0wV9hH/KYL3va0/WBSusxa56xVRX/DCNeWSNSgqgjK789Y54EM1zjtewh7zS2IzSmzxC68JFconMm5/bqOMFrmrRWsnS7yZX+9Bu6WetQCFrZCROO5taGbFO4MscyiG/acOjhbRcRm0to2sYyXu9NevY1FEtwNg8C78LVNY6QyW3T6Q4LBH1Fz5ySC1Upb0N40uqdR04x9lPcvrNvCi6QOm4JUQJEZ8ZoVhAkGoUuGNBeVY/R9Jf6wyn1oBEhbdqvMoBfvcKK1Dr+mcsj1lB+KEFRHhaURC0srfDOX2X9fGWcqmyxelP+wC0YZi9rsvlYDbSSVKckJvKUbEn6mdjMU5OlG01z74U1A6eYBso/sUpZwVXZUW99c0Z+169RNXj0w2EwgwRI/lPtTXtueIxNSGb5wt3vnoGedFuzeG1INuW777NmSKGw10niFNqBCo5s2H2OTPTPU0mSFV6KG2+195Oceo6H+OJyLD6+0EiJvOLMfxja6ATsqrGdHQVS5cD7+6g8CwxrBKwkHqrJE0qDiJIIt9mzh68J8iW4oNkTdDS6l5Kf0c6lrlwM5eCkTErGpSBEjWnq2wZqcs9If3XX7xfkV+jMNlcPzq04xqcLvTOAtX2BcHOnNYeir9nURjDVMAp9q0N8IVbgiMBUZwID2ruoUepvUgDZvjorkeFICLQEeKY4V62sZxyzVWL8/L08r5M4XNsWMGgsYttXAapZ+GYs3roOuJ/tOeIwatSP7FMlu7mbARBs8ofs6C83Z+z/r+Ysf3CnxeZNH3GUXA2AXQx+IqdKuXC6wI0PNC2X m4MwHFut 3F4vd0FumgO+nxf2CfwBYNksJnwrdQI+XKpmb7Qr/kK9FtWEemJjKshyuOxrs1y8XHywSLEUvZAlp+nPLSmvrW6oPcgCorMcXteyQ1zcRPD5oUgGxFURNohf+m8JCBn1/oVRk9cYpbhs521jNM74DvAD73CHN4vSx/mjCKkhPsh/oPM2XQgaCorwV6Lyyzo3itodXxUpg+vdE/54AkPBqaFWtgLLpWFQExk/FJaAv9pRY3NW6OL8yvts+bnj6G6hi2yinpfgOrRe4Dz1r4NCKBxMVSQMpazBezi3Xk4B1doRas/lJ6/d4W+nzUo9RRAJiCS7vyZAuGvaDiDKsTK9EWjnJ/gqHlYrGiwSwHjx57d1lPqQhZrZhO80+j56n6LrVZf18A7jR5X4DHVNEy/oBlH46W6a0+BTJX0GWWh5WL/oScMoyvG4s9mAemxoVNMzfoUjqDor+LLjXhQnVSBNUcN78l8pTUEGUXbvdOrsrluRCSlwVqZ7LC0Y9gvgua6xueozKobAGf/0HRA0yI5okrv33StTZoE6WMKitiqyC6BxthuY2fdkUo9xYAVB8ck0yYuJh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 06:01:49PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 4eab358930711bbeb85bf5ee267d0d42d3394c2c > commit: 62754e4df9e04c4576e989f5ea2b909e824d8164 [6398/6705] mm/page_table_check: support userfault wr-protect entries > config: riscv-randconfig-r001-20230105 (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404171745.Zd13ydca-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > mm/page_table_check.c: In function 'swap_cached_writable': > mm/page_table_check.c:192:24: error: 'SWP_DEVICE_EXCLUSIVE_WRITE' undeclared (first use in this function) > 192 | return type == SWP_DEVICE_EXCLUSIVE_WRITE || > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/page_table_check.c:192:24: note: each undeclared identifier is reported only once for each function it appears in > >> mm/page_table_check.c:194:1: warning: control reaches end of non-void function [-Wreturn-type] > 194 | } > | ^ > > > vim +194 mm/page_table_check.c > > 186 > 187 /* Whether the swap entry cached writable information */ > 188 static inline bool swap_cached_writable(swp_entry_t entry) > 189 { > 190 unsigned type = swp_type(entry); > 191 > 192 return type == SWP_DEVICE_EXCLUSIVE_WRITE || > 193 type == SWP_MIGRATION_WRITE; > > 194 } > 195 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki I'll send a v2 of this patch soon to fix all these issues, after I check with Pasha on some other changes. Thanks, -- Peter Xu