From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77BCD1296 for ; Wed, 10 Apr 2024 10:21:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C18676B007B; Wed, 10 Apr 2024 06:21:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA2466B0082; Wed, 10 Apr 2024 06:21:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1B236B0083; Wed, 10 Apr 2024 06:21:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 829326B007B for ; Wed, 10 Apr 2024 06:21:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F382680782 for ; Wed, 10 Apr 2024 10:21:12 +0000 (UTC) X-FDA: 81993229584.14.48E8CB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 7711E1C0012 for ; Wed, 10 Apr 2024 10:21:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EaUhhvyd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fIfk9ycY; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EaUhhvyd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fIfk9ycY; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712744471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTPZJUa6o8DNX3o58pTjU3gfWwjeq+jTuiWPSFuk9F8=; b=cgPjaP0M1QdCEEUwAuYIAXDZUBITUEm8BSTUngzxx8L/K9PBkmdwuZsXcx4L+NeQww3xdR bV7eEJlIlCetXyPrnufRrl6f9FC+jJJRbdlBhyxj5xVEJbk1w2j9Lz7T9qRGwwrxNaMBwy n+lmFh2PBQ6j6gxk89kEVvubdYiEY4Q= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EaUhhvyd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fIfk9ycY; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EaUhhvyd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fIfk9ycY; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712744471; a=rsa-sha256; cv=none; b=rMgrGZIxt3/VI2S7PKZThNWh6PpKcN4gH7a7QN0jwR6KA17iPa1jEKC/ZGn5AMllJdgcsb zxCLqLSmKo3y20ugVYSkCo7ywWYon/x/a9R+md3yTMvcVLrwu5rxaHdbcC/Vkqa/pGYNeq rf5ET0CLMuOVFiYXvjF9yYOdiINGMDk= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E356A34E8F; Wed, 10 Apr 2024 10:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712744468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTPZJUa6o8DNX3o58pTjU3gfWwjeq+jTuiWPSFuk9F8=; b=EaUhhvydFI1WNogkCPADw4vbZdipgFVRdIxnL2gUn0IqI31vjaMCQNcn6nZd4CRcMQNUZ/ caPcUqMaZkPmO3yWu30nyZHTxmFZffZncIVFOvNYhf/ngcm56iPBRO109zlcGUHfAjOThZ sk3fbDsy+SoKJrnl8uStdR+5IQqeww0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712744468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTPZJUa6o8DNX3o58pTjU3gfWwjeq+jTuiWPSFuk9F8=; b=fIfk9ycY3mooxWSUkE03Zbhdneq1KwY32Sku8YFv4tKnPgOLASfve30ET2cFlIDuuJ0Zib /ZnDQnt5KXaF9SBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712744468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTPZJUa6o8DNX3o58pTjU3gfWwjeq+jTuiWPSFuk9F8=; b=EaUhhvydFI1WNogkCPADw4vbZdipgFVRdIxnL2gUn0IqI31vjaMCQNcn6nZd4CRcMQNUZ/ caPcUqMaZkPmO3yWu30nyZHTxmFZffZncIVFOvNYhf/ngcm56iPBRO109zlcGUHfAjOThZ sk3fbDsy+SoKJrnl8uStdR+5IQqeww0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712744468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTPZJUa6o8DNX3o58pTjU3gfWwjeq+jTuiWPSFuk9F8=; b=fIfk9ycY3mooxWSUkE03Zbhdneq1KwY32Sku8YFv4tKnPgOLASfve30ET2cFlIDuuJ0Zib /ZnDQnt5KXaF9SBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 9B1CB13A92; Wed, 10 Apr 2024 10:21:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id +D0uIxRoFmaeawAAn2gu4w (envelope-from ); Wed, 10 Apr 2024 10:21:08 +0000 Date: Wed, 10 Apr 2024 12:21:07 +0200 From: Oscar Salvador To: Jane Chu Cc: "Matthew Wilcox (Oracle)" , Miaohe Lin , linux-mm@kvack.org Subject: Re: [PATCH v2 07/11] mm/memory-failure: Convert memory_failure() to use a folio Message-ID: References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 7711E1C0012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7omq1nafpcp7rr5f5yxn515pj41kkcge X-HE-Tag: 1712744470-733782 X-HE-Meta: U2FsdGVkX1+eITSoV1OG6qNQGZHwSbbi3R4mP/wsgZQrZi8vwAGcywEOhI3zc4MDGIsvRoBevLJelWwTILUPb7W84mDSpLFGT3vDanQ3dKgSo3s6TpKopnLYJfIQ5uIpIgPahl8mHobg53k0PpXih+kYD2Z8vhzsDwGuOCdCDWv5EK0YRgsQBmowwMFN5bK4881NOkkEYrW1SXszvg2R1nudEzrM8LG2LIAbB5kEl2R+VqmkiXRLqPKd83S8U2uIlpboS5GgeENO1gpAEC2hbYo7+6qoWv/UqssRanLtfiK1h22JM+WIClwFqvElRG4KRZt0DRPq0pKOhB8OEBKLFdhNdQJSRj8f97YfJgdxsytccspMlGRuVtdU0FsSwJiRrTlgHZ8Aq/7LFwjyQH0Xj0JYCY1ftSYDH0Az42lLGjBOk3TjFWRCmGnKzIN4+ZXb0mAg/ar9lVPAxRNOvPbaCDUNptyV+dv+92fJPIYYn25+mqekihiGXMGIBJ9AZAFyU4CcjZgX6i2Mc40G42Ey+078hx42SWQMRmyr/XxnB152ErSDNdGwyx6xs5xWhza8rx6xfF9xQ4ZvtvfOGQ8LGb+vol60fTU94EaHCF0LjCy/w/byGVBfQlp7lNH3RIWJ2MjD5zMQV2iKbD0u/CQJpV/8bHJlzxrwsJDrZcxOPjPpstwFyWrUyjhtWgpUAXVAC+eE610Qbku8XjMYQAmnlrosVIFb0gY1TXZHuAtOtY0d1xJ438QX/ISYMbpgEpZlcBHPHjpzPJMHp/ivtOHqeaF+1INU71VV5yhX7ozJi2ca2/Cllcrhjr2GMEkycQIEqOGo0Liv8Z/xkwS6HDRqSV0AHjurTm5n6S/s5JRfdcEtuFtEDxG4JsVj43IXW/mjFT1CfIt9iAUwRjYQxaR184wAb+v0veSLN/NL/KoXa9bm9ICPsKL3vvwpwFTWztQCFus4i7m1zn7mQpC4Fa7 cbS1a+5f Fn2sf5E/ILCoj+sGWI6ikUkkvgqZp+pY/ZwylHYrJHX39CyJfaIs1plmfYfoe2HZnyJWNErOFa5LfGNCA/i0VivCRWw1k1C+g7sh4dcJ455j9ZLBN5RYknkoMa8CPa4dbX5d5VhRcyFbe00asI2q+3PnJibdhZX9svlupkuT7RTv/dsa9fRa3HHiDkof83GGcnFIfzmicLFLHjq8SAYkO/PX2YNVK68geYYjgv/8OfvXIjluu7i1UQRl0Rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 05:34:29PM -0700, Jane Chu wrote: > At this stage,  'p' is not expected to be a large page since a _refcount has > been taken, right?  So is it reasonable to replace the "if (retry)" block > with a VM_BUG_ON warning?  otherwise, if 'p' became part of a different > large folio,  how to recover from here ? We might have split the THP (if it was part of), but AFAICS nothing stops the kernel to coallesce this page again into a new THP via e.g: madvise(MADV_HUGEPAGE) ? -- Oscar Salvador SUSE Labs