From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B15BCD11C2 for ; Wed, 10 Apr 2024 09:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F6616B0083; Wed, 10 Apr 2024 05:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A7776B0085; Wed, 10 Apr 2024 05:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E1D6B0087; Wed, 10 Apr 2024 05:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 38E806B0083 for ; Wed, 10 Apr 2024 05:38:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5B721C0AD0 for ; Wed, 10 Apr 2024 09:38:43 +0000 (UTC) X-FDA: 81993122526.17.7D7E9DE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 648AFC000B for ; Wed, 10 Apr 2024 09:38:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WWtCIwgh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="7RcM0P8/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WWtCIwgh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="7RcM0P8/"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712741920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sEbTovvpkggXnqPsXhshLPRqy+tZddfyZBrmsjNAUSA=; b=elYVt3z+lyfKejm21wLe0JwpD9ewTqNoThZ8ji3CA0bVykJbd94Nifh+BhPtXFz+D6LEms gAGCWggJN/SdHsWMXYB4sIePXnRAwX4ZszSwXmFbPfh2L5Qp60ejPii+yJT7STSO6RwYVr aQgons9jJ5M3rldAeEaJZSzFgt9wObY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WWtCIwgh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="7RcM0P8/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WWtCIwgh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="7RcM0P8/"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712741920; a=rsa-sha256; cv=none; b=rW3Wit6nScsmq5OJd6eMrY57vPpClzRee9GpYIu8Qr/tdOwhgSNY7f0Al2af2hI2IV4s+I 3QV3AK4bus3cgEgoMcoa523rdRFW8IWBFXAMm1uQqonKtKhcGRGjkXMcHvyLMqaiSPH9ro GtAtrsKB2GtcS9PO8GJfKD+jDA/1Tfo= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F31F34DB5; Wed, 10 Apr 2024 09:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712741918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEbTovvpkggXnqPsXhshLPRqy+tZddfyZBrmsjNAUSA=; b=WWtCIwghskWXeXfTJXyqk55yisLhRQ9RT6QhJT8Qjg5sh7IWk3oN8Qdl5cgcbKrqhK+WZ4 AM2ul66/4bA0Y+4eriiCgimvq1N29V6CijBd7gekaf3EywgZB78+AYhvTk/rzM6Bb58+0B oL2Q4dI9Jk+7b7JneUbO+7SVt1uy7i0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712741918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEbTovvpkggXnqPsXhshLPRqy+tZddfyZBrmsjNAUSA=; b=7RcM0P8/S6/dBGq6nrIcD7b6AfQKaSUW6kYp/SF01kRYkqgAqX7dHh3QTQra973Vogyj2g gMqp5JQQTmbskqCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712741918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEbTovvpkggXnqPsXhshLPRqy+tZddfyZBrmsjNAUSA=; b=WWtCIwghskWXeXfTJXyqk55yisLhRQ9RT6QhJT8Qjg5sh7IWk3oN8Qdl5cgcbKrqhK+WZ4 AM2ul66/4bA0Y+4eriiCgimvq1N29V6CijBd7gekaf3EywgZB78+AYhvTk/rzM6Bb58+0B oL2Q4dI9Jk+7b7JneUbO+7SVt1uy7i0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712741918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sEbTovvpkggXnqPsXhshLPRqy+tZddfyZBrmsjNAUSA=; b=7RcM0P8/S6/dBGq6nrIcD7b6AfQKaSUW6kYp/SF01kRYkqgAqX7dHh3QTQra973Vogyj2g gMqp5JQQTmbskqCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 2E9D11390D; Wed, 10 Apr 2024 09:38:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id XsI+CB5eFmayYQAAn2gu4w (envelope-from ); Wed, 10 Apr 2024 09:38:38 +0000 Date: Wed, 10 Apr 2024 11:38:36 +0200 From: Oscar Salvador To: "Matthew Wilcox (Oracle)" Cc: Miaohe Lin , linux-mm@kvack.org Subject: Re: [PATCH v2 03/11] mm: Return the address from page_mapped_in_vma() Message-ID: References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240408194232.118537-4-willy@infradead.org> X-Rspamd-Queue-Id: 648AFC000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n1bmbk4aiet57bo9s8jkoaipj388intp X-HE-Tag: 1712741920-516930 X-HE-Meta: U2FsdGVkX1+4ARt08B1WXST8J4rr2gftacBCXQaHFWaLBbtsyFBFJZKVkVfSuec6zsa+0HUD5VrGryLtJzTA8XLqLaooV9m8aUCLukNY7LwF5hVhmCs5oUiM8ITCMFq8v6A09AG8zUFRjfyJl23LED9+nL1xMTC3syrQPW6O3GpdvIzgwfNasIvi3wGEt8BW6DJrir1IiAJFqxheDXtz4y9wCKJhFFkbFRRMNhlMthVihjFJvg+hJshWGKYaDx2rWbFMirjA9uFz5ylIw0eEmM/dq7kfCjRCjPjjKUlTcP9njL2rR1d0Sql2DyKYGs2P7oO57J1ZaFqjxcOzeY3KwlAlahNdGDgWfARhPR2QSJN2GYRAF8ynYUQeLGQOqIYvo2wCx+QFPm6El8EWpDelNStjHLfPfXVidsJ/Z8JeMC/IaIzhPPdQ6ATzINsAbfvbYSXjlshMEaQtV7yDWeq+tlkb6KwJr2qA/LEZE+PQTuyLwRR3THu2r0nvaNRHp6WglO+KfiObeSbvTc0xzTimMrF0c+vR4V/s8lPczgNDPzv2DDrWbQAFxFTKU88OvLIxZHf077nhFssgAF0RplZ84tqT3625q8oiGqeqmFPXZ+XVs5xXOr8/lGppt5MsnC3RmSDBpLCysUeY+kAWO6BE4IzaH2ieoYz6koCci64mWG7OcIGY0NA9eZDJjG3qgBmhCSeywGAnrzDDinnf9UK1T0Z7xPFlGzyC1+vZhl0BsD9lxHUed0tnLZCec6FySv0bSff9npWka1nxouqkayMDrRf8vYZtWDMloYuat7m29KDeoCFG9L9GvyvfRfODpWnLcyyyT69x6XOZBs/xOZxGtK1nPbQu7S4iS65TtwKolrTvlBIe+RjL4hBbApk0oDIIIDIScz7MHVLS4kbB27TeMlgGEKc+EgKMyKRi0dlkRvddq58R4KA8p5WIL28Moxc54vqbUBUWSBrRa+0KtAX xQrA7er4 OEKNtIUYRM+BoEEwNA3HL0fkA6+RvShatqN1fUWg7OMuQfhlDkh+g6VQkSkHcVhjJRJWPzGmCASDnM84wx7mEFGjW7d5Dfm9jFrNf3faBc6H5TPXX/JplIVk2pF6PQMlMmxqiOVWidlPtJPHyN07drer6Qea9ejljNzLqS5w3+2E9VwfFvQBFR0jT5VmlmYZqrwYL+esyTQw8CEN4XUv4evqXMtkt+yzxZ1dl47wEis3xf1dM9BDtpOjmurr68+A55Dfjv41kwqPAz1Rk4J4byuXgbNT+vKzr1XpCdKOLNfGmTVIV36731eqrRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 08:42:21PM +0100, Matthew Wilcox (Oracle) wrote: > The only user of this function calls page_address_in_vma() immediately > after page_mapped_in_vma() calculates it and uses it to return true/false. > Return the address instead, allowing memory-failure to skip the call > to page_address_in_vma(). > > Acked-by: Miaohe Lin > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/page_vma_mapped.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c > index 53b8868ede61..48bfc17934cd 100644 > --- a/mm/page_vma_mapped.c > +++ b/mm/page_vma_mapped.c > @@ -319,9 +319,10 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) > * @page: the page to test > * @vma: the VMA to test > * > - * Returns 1 if the page is mapped into the page tables of the VMA, 0 > - * if the page is not mapped into the page tables of this VMA. Only > - * valid for normal file or anonymous VMAs. > + * Return: The address the page is mapped at if the page is in the range > + * covered by the VMA and present in the page table. If the page is > + * outside the VMA or not present, returns -EFAULT. > + * Only valid for normal file or anonymous VMAs. I am probably missing something here but I am confused. Now we either return -EFAULT or the address. But page_vma_mapped_walk() gets called from collect_procs_anon() like this: if (!page_mapped_in_vma(page, vma)) so that is not gonna work the way we want? Should not that be converted to if (page_mapped_in_vma(page, vma) == -EFAULT) ? -- Oscar Salvador SUSE Labs