From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345C1CD1284 for ; Tue, 9 Apr 2024 14:10:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A156B007B; Tue, 9 Apr 2024 10:10:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B48C36B0082; Tue, 9 Apr 2024 10:10:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10C96B0083; Tue, 9 Apr 2024 10:10:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8768B6B007B for ; Tue, 9 Apr 2024 10:10:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F566A0AFC for ; Tue, 9 Apr 2024 14:10:29 +0000 (UTC) X-FDA: 81990178578.08.706B453 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 834C018002C for ; Tue, 9 Apr 2024 14:10:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bAJDz4o5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHgBKUin; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bAJDz4o5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHgBKUin; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712671826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g5EGKPwkjwjC7/2V5eZgVJUDYhN24KSQzqGl9F+xdpE=; b=qZ4yf9tC3uGe3RGm5CiDxX2ZV+5m1VozgicL4luj2r/Guq6z3fvk7sjav9v6h9aMOdSEEs MAcfImtGE4lM9z0zOTEjH2G8fhrXOJJGWBbVg2NrxbwUaCc11R0Ngk8gZbCQEuA5VW5nsl 4DEo3xtY7qB/YK2/I2ZPdceV46iyYG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712671826; a=rsa-sha256; cv=none; b=nVHV78neqjKdYEzSAHqYIpV2+ELPLdUYkGGMb7IJgDCxkoylRo69k5fCCPB2HnJh12buoQ VGl7l6mX5YrfAalYRl3NR3zmlXFvpXwKBYVZfTE8U5RkhIlsxdosVWwj5D9PEK2uKO4wv/ bIEGhAUiNatTq6kSqh+4zuDSqavg6Xc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bAJDz4o5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHgBKUin; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bAJDz4o5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHgBKUin; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B986033A22; Tue, 9 Apr 2024 14:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712671824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5EGKPwkjwjC7/2V5eZgVJUDYhN24KSQzqGl9F+xdpE=; b=bAJDz4o5gJ8nuym0JcOaYLtPXS3BrX8EFKlqYRyZOa/l+Y7oLyUynscQ85ZfxC7rH6vCan C1H+4yukjkNba2fFtUZUD5tsRhgNOj4fytk2mnrW8zr79DJ+encWReiPcRbXlaMT6G0ncB SVAWf+5a1t2JhLOSzGGapOvikKStVY0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712671824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5EGKPwkjwjC7/2V5eZgVJUDYhN24KSQzqGl9F+xdpE=; b=qHgBKUinOs/RCSj+mJalvLvQWP/b5U9KID8WpNJStbmYCSo2o3baSo29ZMrNtbez4uzZwf npt+RGngFuNJxeCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712671824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5EGKPwkjwjC7/2V5eZgVJUDYhN24KSQzqGl9F+xdpE=; b=bAJDz4o5gJ8nuym0JcOaYLtPXS3BrX8EFKlqYRyZOa/l+Y7oLyUynscQ85ZfxC7rH6vCan C1H+4yukjkNba2fFtUZUD5tsRhgNOj4fytk2mnrW8zr79DJ+encWReiPcRbXlaMT6G0ncB SVAWf+5a1t2JhLOSzGGapOvikKStVY0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712671824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5EGKPwkjwjC7/2V5eZgVJUDYhN24KSQzqGl9F+xdpE=; b=qHgBKUinOs/RCSj+mJalvLvQWP/b5U9KID8WpNJStbmYCSo2o3baSo29ZMrNtbez4uzZwf npt+RGngFuNJxeCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 621451332F; Tue, 9 Apr 2024 14:10:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id R3kAFVBMFWb6BwAAn2gu4w (envelope-from ); Tue, 09 Apr 2024 14:10:24 +0000 Date: Tue, 9 Apr 2024 16:10:22 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memory-failure: fix deadlock when hugetlb_optimize_vmemmap is enabled Message-ID: References: <20240407085456.2798193-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240407085456.2798193-1-linmiaohe@huawei.com> X-Rspamd-Action: no action X-Stat-Signature: f7ibrt9tpoe1ejma115hcauj8zh77i11 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 834C018002C X-Rspam-User: X-HE-Tag: 1712671826-139634 X-HE-Meta: U2FsdGVkX1/sYP80N2y8t+YHRNjWrUhKiCdGUHVGlGIEU9Std2Nd/qQMLXsqScbhvCjTyMMyYgiuzBTypktw3wOmkXwTa5zms3ck0/KDFatRxf467TJ2PG2bprxngsR5JjUJLsq4irRGdzhcZQf01A2LitxRhZ9L5kvuV/KVPnZv7JiQOAarkS/61kO7rXF+WMZ1U/klpMbc5kYZZ32fcDTB1lfmC36SWYTHTsSmjxbvJ3F0dzmOeTAdVmNL3Q4HSwwJCyn+DaC6Gse+Dt2Qn0ete3fnH72cinbORG14XwXy5FmyiLS/ndK3kqm9ineoOd+tNFKLlSpTOIjiRlSFjG0Zi1cQzhUV/wlmVj9fhJwKjuul/jFNN/U4RfZDeZa5N+z1fECQ471twFyrG3YRsxnSkuLt1CYysC0USbcXrMMRkfXnq0F6zNv893DLAqzTLmsouuV98DpOyjuId2DXcNz0dIDp9c6fsl6rZ1NhJHe7q9lGUT4fuCpciLC0VizdJ4z5+PiZrpkiRF9vB7G4ixZ9iXr0n/1XALBckHUdx42W9+InrMDaehOXJ7R4jxG2SmW+xO420hyOAhhwA+yBuDwqLebgeeq+GhNTa/U6uXiU8OJWN2PqnmWhwNEqRD80PH1FWJk6DAtUR8Hr1gUTAQrLO363gfb3JBKfaIsSq9J1SkA4751PNUI+gA1HGyWqrbsw9GT97X1ZuJ5cpJh0CCDhDnbKj/ti1jDkO5CCro/WKuB0s5BLVMzgR8OSTtxTWNNu2Nmbe4F2gLS6LcvwrPQ7cLCVADr0ePhMG5jYjYa8hLIs1qcgy53jZC1TIGHRpJyhiOu7HsNwYewv6DhvCRvOUgBm6er9D3B5RiMZnfHL/LOoTC23ilHlw8Ufa3SVY8d9iwQ0TSFUdDZisaZFElXGI3y3yg5EhAGzyneK8/ndiuhvFufoDw5NkQAc1kmLJVYOerBa1ALLf11MeVy mcATRBne 1eicnobLiwyCfvie7ONFlmafr1IsroBMi9Vn9QBIm4ZK4Urghsphm47Qtl/C39i/QIM8MHNMYGMcf1tBtk00cVT1XtB34Co3mTNB9m+FzDnkYQVESiIvtOI5ZadJ+Odke3RVWrLpjuc/N2xp3+CLctgyL8X0Qn9r5EexIBCDXi4Vt5+XK3aeLUSZE5kPfm/EUaC3JS+HKUPNMXpS6stl7EeZIys1BZr7EeoywzDKQWbCHDAXW5vsWrdQmzx8yNTNjt8reHiODVWL4VHnhRmSdqFs5DQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 07, 2024 at 04:54:56PM +0800, Miaohe Lin wrote: > In short, below scene breaks the lock dependency chain: > > memory_failure > __page_handle_poison > zone_pcp_disable -- lock(pcp_batch_high_lock) > dissolve_free_huge_page > __hugetlb_vmemmap_restore_folio > static_key_slow_dec > cpus_read_lock -- rlock(cpu_hotplug_lock) > > Fix this by calling drain_all_pages() instead. > > Signed-off-by: Miaohe Lin Acked-by: Oscar Salvador Thanks! -- Oscar Salvador SUSE Labs