From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD01C67861 for ; Tue, 9 Apr 2024 14:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E09ED6B007B; Tue, 9 Apr 2024 10:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB93D6B0082; Tue, 9 Apr 2024 10:09:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA8996B0083; Tue, 9 Apr 2024 10:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC7AE6B007B for ; Tue, 9 Apr 2024 10:09:46 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6BEF1C0440 for ; Tue, 9 Apr 2024 14:09:46 +0000 (UTC) X-FDA: 81990176772.07.EADE5EF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 7E0B91A0034 for ; Tue, 9 Apr 2024 14:09:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fAtD7d7A; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712671784; a=rsa-sha256; cv=none; b=KeXQkXDHBojIIS55bQg0MkdbSr5HFr7KTVlHwjHWRvS63VDAxxNMVNUp7+wFcbM4y4ctaO g3nePgc9UxeSNRBska1RedphWQePfXnxOnpwEe00MqcyNub3e0O57AbT3KhJjW3/uItTX7 XPtz1Tl+C0spSsv5Ho3B+xezDrLATjk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fAtD7d7A; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712671784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BQQLUB5sQos6pI24WXbQ1RLhAkO7yA5AUlgdiU+dzI0=; b=ipjTZ51SMzUTHHku08snFx7d3p0hYcY83Pz3x79BYipQHvsjf2CelSxpjg4ImgeifI7Wm1 o8F4PtxVtknWQUUljD0HPMseYkM11jkLthTxqckOSWUleSG3aiIHDlNZ1bFmQBZO6D+35a jKtITuWtvVAicTwNcQk5dJcix5va+QM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BQQLUB5sQos6pI24WXbQ1RLhAkO7yA5AUlgdiU+dzI0=; b=fAtD7d7A2nmyW+6JMbURfPumMq B8/RiGuVdYHCfVhKOf6VX5ASD4UcTDylZ3VAohXsTpzG++LZCWAhP0fCKcGG7a3M66DOFikWVu7tO 3cMPQ6jEJ5d3J2BvQtVvELEqhZljeGTEbHGFvBjlTa0SmSHv19CkIHoMtFYsLMuNrG0dfqkKYkUe7 eQJXZcZ2QH+i1fML8g+dwmiz013iUComIrmHg2Dks65SND2BBl/TwX2bys5Bl/y4LYIw9aWVOYBrv hZ5lUb8C2aonU54onFtj5872cInTYwDsGUNMXtVY9BLg7REksMx/WFUHttRgU6F5GYkzZBC9SWqh7 6o3NBX4Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruCAO-00000002GWl-19sG; Tue, 09 Apr 2024 14:09:40 +0000 Date: Tue, 9 Apr 2024 15:09:40 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Pankaj Raghav Subject: Re: [PATCH] mm: Convert pagecache_isize_extended to use a folio Message-ID: References: <20240405180038.2618624-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7E0B91A0034 X-Stat-Signature: apmfg4dfas337z7hibzxyiw6w6ax99zo X-Rspam-User: X-HE-Tag: 1712671783-602830 X-HE-Meta: U2FsdGVkX1+HhktJ/PLuW2Gl6luFWlEz9jFB5/mzoMEgkRonZ+BfXZ5uGfzd5LGrdLS9dpvU9+m7TVLVVTXoVuR1cEJCXRTUoLRk6D3yyLTTOZif1HxACEUpy8Z3Cx78hyg4EKkWlNksZn+OP9FxyXwoHgbuu6DD2b8FEkciisbY5eMvSr8N+yajpNw/YqEfnHRCRxqJLcHvv2L3xsQ2c9FUEFEimpI7tzQTYsXSp2YKvBJq3DMJyXBZdoaEluhbpEZ+VubrhxGBjtxFCxaAHymUlsutpd8qX3qNJYZ6LTlL4YPK3YAppyDkOe6qnxvAnnW55K9VyLX1mvqx1xWqBQGviyU8M1X78+6kN48TP+SyAaLhu5Xp1lLRSSWUL2B4jMVn0uHGqwSdHuuCoDfzaD2n+SCI6jhSHWxstBkrk5sD+a+uc9R6yhj6b1eBubjKvkY7FwS93V4iU1Q7ECR1nZAlV/2On0TKVvxAspDSJe/uC1/2oVoXJnhXPiz0cy3fVeWJgTKaTjR+YWD873L7S3JaMuI3P2zhSyQS2JUPiA51RHeeelfMTcQCFc+9H33Vm6+qc/5vBeGhdUp1ZoKoRXO/VJNpkltBVnyA3RhWVtnQ1AL8paUrVo1K99hdQ2HTxthy9O9yOlL9zt+mHwqk8hO9KJjxkJpGyZ3gePISHW2yQknAvpJVwOH0ajIUcKoSPTpreU/6G746O2hRAArCZJ5/C4AvYF/WdHL7ypMvhRJIB8jmOeV0FW/drIa2YyZmBAD7j8JSJwtSMkceoYKQAg6V5+FVWBETczmhahl0au7mB9OD1q1Yozyfaa3NzZ2S4/VAVBCoElJVW0JJXUnpDkVtAUOTOANWhyKXG9/SlT5u7mVAM/aGgem1wB3AVxGWqfja9swLuR9XS6x8YQ9QKPZKeQq1nWkA/dmiGUb/AY0OS7t0Sq0BAc/ZbhX35GY5i9122lX2hJpdLbOkka8 oSDq77+Q Cp6xBPBjWx6gKUNfWNNYcVUBgHUZ1C1CzOcgPcKyigG0mOy25Nsx/fWSxB8UkAejx4qRKghJ9X2+HHm8a6lzfATrJa9d2gW9nEtqwoDEAzYPLts45Kl9Imv2/T+G1VeNQYo5LmistGX7N5MKvG7P4bwvWsqC2ua1UNdiErZ5Zv6CA2XD8z1vXRhRVY4lnBJOf6b1o8Z2mLKYYzfg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 09, 2024 at 03:39:35PM +0200, David Hildenbrand wrote: > On 05.04.24 20:00, Matthew Wilcox (Oracle) wrote: > > + * Handle extension of inode size either caused by extending truncate or > > + * by write starting after current i_size. We mark the page straddling > > + * current i_size RO so that page_mkwrite() is called on the first > > + * write access to the page. The filesystem will update its per-block > > + * information before user writes to the page via mmap after the i_size > > + * has been changed. > > Did you intend not to s/page/folio/ ? I did! I think here we're talking about page faults, and we can control the RO property on a per-PTE (ie per-page) basis. Do you think it'd be clearer if we talked about folios here? We're in a bit of an interesting spot because filesystems generally don't have folios which overhang the end of the file by more than a page. It can happen if truncate fails to split a folio. > Reviewed-by: David Hildenbrand Thanks!