From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DA9CD1284 for ; Tue, 9 Apr 2024 11:15:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F38026B0096; Tue, 9 Apr 2024 07:15:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE8A76B0098; Tue, 9 Apr 2024 07:15:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAFCB6B0099; Tue, 9 Apr 2024 07:15:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B95D06B0096 for ; Tue, 9 Apr 2024 07:15:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 40F431402D5 for ; Tue, 9 Apr 2024 11:15:21 +0000 (UTC) X-FDA: 81989737242.29.784346B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 620E614001D for ; Tue, 9 Apr 2024 11:15:18 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712661319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bl26vGfITPUFavwbxNlSXBD1IzdnYupezgFe96iIClk=; b=PRNmF3/HFn3T3+gKvYl2uCSMRoDrCsxxa7agp7geYYh2O6bozbbO69hAfeM3V6ancHu4tm mn2lUl0gTh+GY43E2wlSKXJA2unSCKafpZ3lIxfrKr2qjyONwK+pxCBL1uxiPqq30lLQCV JBNmVJE1IsIlRa3xPmOgY0wlFCjLjEk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712661319; a=rsa-sha256; cv=none; b=pFcRU2q7JjT+8sc3t1CZSX58Dcls9seyKIDs2us3etoPbLkeUWI91r2s8C4ydsho672csB s5D8yjVV0dvCyP3WjbwqqEdYuE96cveZy05OD2uPBoShDDUpdOE3fKllMs6u6QSfkeGcW/ n7dRIT8Co1JCN2RRjZR9tiTvMgEKTfw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2D5BCCE1E45; Tue, 9 Apr 2024 11:15:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57168C433F1; Tue, 9 Apr 2024 11:15:11 +0000 (UTC) Date: Tue, 9 Apr 2024 12:15:09 +0100 From: Catalin Marinas To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 2/7] arm64: mm: accelerate pagefault when VM_FAULT_BADACCESS Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403083805.1818160-3-wangkefeng.wang@huawei.com> X-Stat-Signature: 8ksak93swyuh3t5ikhp744s8w9s1qq9u X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 620E614001D X-Rspam-User: X-HE-Tag: 1712661318-454885 X-HE-Meta: U2FsdGVkX18j7J0oioyr+W6D+44jMucO/HdDPobBvV2znXWIZdDQLUCr9LgDkSKDZt5J8mcr8YQ7Qbbhw53m93cJl3jX1/1PibdPm13BNgUlif62wC2MNdsk99EsQZ/Fkn0vmDlwKbO2sYHCR1PZv2cXvjODV+u5CwUAAxZP2VvA8EQ3KTt53ybYf8P7HjqgLKoadYBZDcV6NKfyHGN3Vs7nkSMhEV+QS+e/6QA5PXfN6JiTBxdGygMPhtG5yB1tahYthVjU5m+S6vEyL5lM04qnLYalpVe7AIJx61MME21+8XtWnKt3IP2Scj2pkMwGVwrNsAMv0R+zq7TND1+6KT1PAMtyoxAZ6gmhNRprCStelR4zg9kVLIxtitmlEKFfoIdmhllBtY+tShZtIg0VTFRKGaLNBvWcGqyzDnUwl/3bWpmoeuy1Bvxe0ex9ITPYdmDbL0cK2P+KbfdeSHAQvTsXofK6iVT4m0FTTR9L2MUn1uAhrjQb+n4p44l/63tEH1+x5bCSaMpiIbLss2YTlbDczxso1MMwNKCFtg6GvLqOCtt1/D4OgmROXkm6SMeDvsdVTWawJuWjjR9/avWn+IHRuuH83LEld4/PQBDLE86LB6eYKynQHiOgXOV50QEVcTA98wnb5xG6ui/Tm5CtTPrZj57/lb0nO3sSUEDDPzvCjynQ+N10JQlGiJx2GpqIOLM1HJWS6nJ49hgYnPIllkWPnAupr5TRGSGcZccY/4/HnbaZHA2bsMUp+eFrR4CQ97k+9Atx9mQq3GuNb7JGA+b2NQd2nJZR6Z9vUDje09y1YfG9s6uVzHptY3eFElB7o7P8qbbK+KhUZ90cCwTKSPP+ls6mpsN6BJtUqRHh+uYsd2Ta/jpDOcUyM4VSuHr5DpAIsBCXgLocMQwuOIyTCQZhNDO9vOXtM8uCbvFcRViSiv0bThmAsg7dG1Vq2pLTl0ySYLPiNZ+6kJhDIEy zVa6YEUX 1K1E2mHKx0sZVS3XTjbIQsJrwQ5KS8DdvRmlDTVjMssqWnCn11+s7Ini62kwAyGZGpM2BgpePmHMKDKYZtzI43p+d9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 04:38:00PM +0800, Kefeng Wang wrote: > The vm_flags of vma already checked under per-VMA lock, if it is a > bad access, directly set fault to VM_FAULT_BADACCESS and handle error, > no need to retry with mmap_lock again, the latency time reduces 34% in > 'lat_sig -P 1 prot lat_sig' from lmbench testcase. > > Since the page faut is handled under per-VMA lock, count it as a vma lock > event with VMA_LOCK_SUCCESS. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang Reviewed-by: Catalin Marinas