From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9851CD1284 for ; Tue, 9 Apr 2024 11:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3406B0092; Tue, 9 Apr 2024 07:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 682DD6B0096; Tue, 9 Apr 2024 07:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54A7C6B0098; Tue, 9 Apr 2024 07:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 37A346B0092 for ; Tue, 9 Apr 2024 07:14:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB3F412035C for ; Tue, 9 Apr 2024 11:14:52 +0000 (UTC) X-FDA: 81989736024.05.EBD2AEC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id C0C17180011 for ; Tue, 9 Apr 2024 11:14:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712661291; a=rsa-sha256; cv=none; b=F9mQCe8i8KxsutBLxjZioznsQ4d0V9K8iRaYG6P/cFv0wKEO4AsH3kn4WLRj2WcdugoUlf n3PMwsepDdZ8YYn9+d6P0x907W9sNGExiBsC7Is532kcfkxf25IT9Bixl1t2V9PYHCzxDA LZnOM3U9kIM/ZsYJZXvQ9TSmQxXqJCI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712661291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ol9XTObyBmKnuAvKhbhGV7CMxws4M+BZK1fYaN600io=; b=VTdzqfVcYWTnj7rRp3kVPfStmAFFH3JK9ty5KUs0/DvGWvVwDUgaZ8dhX0vsdtCZxPi5mB xcqOW7Kg9VjUmLEoZSfy95jtGvjfj5gJB4eWSlIlr7vm7y4TqZFMvpoC2OVD9XS7m0mfFy N4ZGN6VcPDjkWTp9ne8e8wt6zJkstj0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4F12CE1DAF; Tue, 9 Apr 2024 11:14:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FC7C433F1; Tue, 9 Apr 2024 11:14:41 +0000 (UTC) Date: Tue, 9 Apr 2024 12:14:38 +0100 From: Catalin Marinas To: Kefeng Wang Cc: akpm@linux-foundation.org, Russell King , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, surenb@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Message-ID: References: <20240403083805.1818160-1-wangkefeng.wang@huawei.com> <20240403083805.1818160-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403083805.1818160-2-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C0C17180011 X-Stat-Signature: kxzy7cde5njbwrbtr9dojq3qap7wt9gt X-Rspam-User: X-HE-Tag: 1712661290-680421 X-HE-Meta: U2FsdGVkX19Obhob9dmK+iMYoT+OOdwyH7HW9u9JR0OC8nyjCv2LxkaJF+2Q58OBcbRJnIbfuh9V3IWbHeBTeexGybUj6aOArwzMe5JR8p+RqGgAUeb26CHZ3Oo2EfcRjYapoJo6zkY8lFiyU/lcmtc/osuQCBMjyFEqRsI0qzEbPZwrNH1rewRUiKgYu6q5E8YDwJ5+nObCShzaTeWaeGldtAMt7qHOGnXOaRaPEOLarvIolCa3RB4a2F2XmMcCnOtXFQ3XevR/4y+9DgwfvMiehBSPqJmwMznSBTcWl7FFze/jy5ZnwNme5fop/G7vbuf1l9dbfFoSuMLYSL7rnhBDwQgY7hNq4pWJlSf/WAL0CPFaRXFS89u22aE+Kl02EW4Wnfde8AyFNN48s2LOm+Yi2qGu5Xu0YQW+djrdJXg0zDQ38VsnZmJh0gKCy4SnejEvFX7Swp5Qjtb0lCaijs2LtQfuFKvjs+T3VSjPMJsHd3A3WfsCJK/jZxzCH8FI5y8syGzM9U2S3D+BM8BB6dZ7Jpi3dRHGnKBNJ0m4c3730NRE9gpYcT2pgL6EoNOSNhqWsXUH/DwB7jbqi7G3uaFetwSu5Mq1GH+jhjFQMZXZZSfpbg07ZpX1ALP/ulGTCvxZITVSQDsJqWAFzz7+k9YZ/FvmDlgDMoSqoROpPFKmI3kUM+zFCSVZ9nyy6jzrnPMgQ6l3mZbC+uM7HXENCZQySaXHDvWGuHY8D6lAduXpjHRBSORyg5dpcKiILgmmI3lbUTzu9zhvUow6o16dUeNXIQBbp/bcGBQ9oZcEsUkIYFmhZzLxftditQjqLzWua35g/XLginU79v2h3LwHeig2UJVKQlNw9oF6t+cqyCWdN+WLsRFE4XyV8Nxu8QlRXUBRa12igQxja+xkuG/GbI7oIIQu4xigjoM7gQnVpfrruElG3iRpBZLG5+TE7GHlCJUmHNWMJTvQl7BIYwh JJOteNbw dBaFHFnbrItFQhA5xiXZ0hJbITDLCOIY8dpVNd4N5CtpXaIBrMJxNxr/ZSKF6HZgMcUXgWMBRpjg331FqON2te3rS/Pf7UKj0DR1jY8byccbK4QtfzhQiyFMt2bP5jRIh4J7bRAfLwZY0lkbLaiSL0/D6aoDnjBiTAtaZgOU5fCzbbkpaDKha+bgbejBxLJjcwAkH1RemtoiFpiAwZtksdQ3KFFd8vBTQDJ+VoMMam+D48/vpfPqipZOwRx2NQWs+scJuOsvP/KHyn9Hw4P88mlaWFNh3/WdP0xLS8VggX2/0rB1J+ebXZspHqPgDu21+qTSeEPkcGQJg8FwPcGJ8ncXuTndX0wGJEBuY/zZz8hZR14qgsKND3huiUlfLcP8BAW0Buav8wlYBkcSbQk0VWIOxQi/sZlBMXMKr18VGWsQGKdS2sYOhr0KnCSHBQeNfpQagyHRAJh3KVV+4nPAlcbMqMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 04:37:59PM +0800, Kefeng Wang wrote: > The __do_page_fault() only calls handle_mm_fault() after vm_flags > checked, and it is only called by do_page_fault(), let's squash > it into do_page_fault() to cleanup code. > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Kefeng Wang As I reviewed v1 and the changes are minimal: Reviewed-by: Catalin Marinas