From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3BCC67861 for ; Mon, 8 Apr 2024 17:55:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B1706B0087; Mon, 8 Apr 2024 13:55:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 662536B0089; Mon, 8 Apr 2024 13:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 529836B008A; Mon, 8 Apr 2024 13:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 280CE6B0087 for ; Mon, 8 Apr 2024 13:55:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ABD2DA0195 for ; Mon, 8 Apr 2024 17:55:40 +0000 (UTC) X-FDA: 81987117240.30.3B9BAD8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 597BF180027 for ; Mon, 8 Apr 2024 17:55:38 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VU9qvBGB; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712598939; a=rsa-sha256; cv=none; b=perGzFaB1bYXE3SbBkuJsWMhOi6wI4p9ysOKUrmjZV6duuLCl/yAJIgwEKSvxY5A3xvNYN ElmYYVRzakDPnL01lsc4udXZGDwIftLAslK6cbxASbUg/tb9fSVWM6F9GJ8Ub35tU7P7As Zfq4ed970R0hjweyFt/oAlPmrm5pvnc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VU9qvBGB; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712598939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vprri69ntE5tXl2ejHYWa++Fhx4661tQjtCllU5TZfM=; b=ycccWUgr4AWoE1kG8vNgAK9cr+X3QzW7f0bN/PETB1T1xRF2vnF0l3uMbAMN6I63dk+wPz QVznC2I/Mn9FXtlxko8hLTgBaPayJP/OXQJft1B7WpbNj4PN9Z5bRCqy9zDl/4k/17Or/p YOycRg4PehKAm75ROEAvCjSxhdSmedI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Vprri69ntE5tXl2ejHYWa++Fhx4661tQjtCllU5TZfM=; b=VU9qvBGBmxEoWgYzjI8zdCVZ/6 SvoD7Tq9v8jBXn+Wjn1JYHI/t6YLeXlfa2sDpK7JF9a6C66vG7M/Irt+HBmihjAKAcKbuIit21MUF rzsqWVD4B5ABo3JISbVk0vo/VUzuqhJwK6PSgarQMfwOaMmNGyi80sPG9R8tFQNfhM7y8BydZvGvS PvJ9QBUv2LK4kS/9COxpsn+IB8YH/5fUd5is5JJ+xc3IRme7C9yVtNlgv9hZvzS01yL6N6eHGeNYA 3J+yYo5Ud9v+mhXcOUglBFzw963SKO5VBTVk2jAoEn83BFrZt2l+bn7nAEJCwI6Gr/FwHfRE1l12J zRT3JBAA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rttDS-00000000Kgm-3C1L; Mon, 08 Apr 2024 17:55:34 +0000 Date: Mon, 8 Apr 2024 18:55:34 +0100 From: Matthew Wilcox To: Vishal Moola Cc: Muchun Song , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] hugetlb: Convert hugetlb_wp() to use struct vm_fault Message-ID: References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-4-vishal.moola@gmail.com> <7d001108-157d-4139-bfa9-5b4102166f17@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 597BF180027 X-Stat-Signature: eaz7zifwysfgxf6cjaje4gy6a9nys6bq X-Rspam-User: X-HE-Tag: 1712598938-851561 X-HE-Meta: U2FsdGVkX1/FWaSoJPul05GBEOEp1gpQHqX77rEPan+wTsPK2bfJufLkerzFo54Hp3NF+/Zfo5y33uDgyANsXlCMj0fEMMt/ua4LtmJpbDZ6flxIriMkRA78UkbAzoaDb817UgIeWMqFIybSr5eaK+IJc8Ah4A9x6eDBhtZ4BwxOBqIurhW0Ae9ljMXfoQMvpHgl77FVEEwEZRrawdrMDv+DwtQb8FPOZHTLT/50OvfzWodev0me7Z8UerTjH4YcqLPNGCLq45UzgUiSO7sLVMpBY/Af3O1h8jFVzk2FJd4ZiN///zWZaJpKpkW7g0EHxVuNrwuqS9jssP0q26CX6TnnrmCHzFyZGFbN9WyieRagjQwKY8ckZ3J7O+6sbHiKwAgzRke7FFTQ+9l2UnS4MuYiUmi36/Ap+dEIRQKSyxqOSp0R3NQ20wjVuMDAnJ+5LTpFg6D66hNWNT3+PUsyd7d/2eSVsuPO/q5rBmu+mMA7x6eWQByE6LnRJmqJskD6v/hJlZXYtdGQ5WndpnMf5kyEM1RJzN00SN7sp2jjVFf7G5TIvbLqQaIkmrG9nazdzwGl3YLmPT2yW3foSeCZK1Q9POg9hBM90dgUVZPJOPsP4HkNe7/CJU4ievlfwKr+xD/JHKUOd9pPRAyJ3HKHfiDPNr4jGjVs57K5bwlu2jB+nSzItZLww/oFMEm6nuv/OXNQIqxcrrbvOqWcDzdS/dCdVChvHBgX0xfkymG3h63KPD5DmwWEZQET2HAp9QTZuusrIHUJ4O7rxOsGCpFFWOohw8H7+9xcPpRzEnyEjiKvho+hCM9WuCyj/XQiW28itixMH0bZ8NeLzbZEdyeAPHpEMN555lnfLnOSOqdGEZ6GsV/rZI8BBRhFFLOE9hkozrGiqTN+NHNtYxp3iOaog5bHPkgZQ+6cAIHkoSefSDbJuD/tWb+BAyrrS6TrEbp7jo27i6JYYYE2Ve0oQi/ 5NUHee4M Xwr1T9/8SfC282e3bpRXXEVhC2BoXpVENy3bijHZN13Ll3EjQIMBTpm5ifnXt9FA2nASdue9SMyf+SkiXqSyT94ZZirVRR4ux6VNNJc6yScOw/fJHsX+RIC/UOPqvY6D3Xvxb5i5UcK/TqMkW/OW30R8qoUszFEgy1R8EU++IrkO+8SvA5ubZBnm7yptznLxDwEAMN1KDMdvHYdhXcx26X1OgciKaiLOt+RhAyulJ0MGdHAOhHbhIAg3VWX1ktcz4XZ+y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 10:47:12AM -0700, Vishal Moola wrote: > -static vm_fault_t hugetlb_wp(struct mm_struct *mm, struct vm_area_struct *vma, > - struct folio *pagecache_folio, > +static vm_fault_t hugetlb_wp(struct folio *pagecache_folio, > struct vm_fault *vmf) > { > + struct vm_area_struct *vma = vmf->vma; > + struct mm_struct *mm = vma->vm_mm; I think 'vmf' should be the first parameter, not the second. Compare: static vm_fault_t do_page_mkwrite(struct vm_fault *vmf, struct folio *folio) static inline void wp_page_reuse(struct vm_fault *vmf, struct folio *folio) static vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf, struct folio *folio) static vm_fault_t wp_page_shared(struct vm_fault *vmf, struct folio *folio) vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) void set_pte_range(struct vm_fault *vmf, struct folio *folio, struct page *page, unsigned int nr, unsigned long addr) int numa_migrate_prep(struct folio *folio, struct vm_fault *vmf, unsigned long addr, int page_nid, int *flags) static void numa_rebuild_single_mapping(struct vm_fault *vmf, struct vm_area_struct *vma, unsigned long fault_addr, pte_t *fault_pte, bool writable) static void numa_rebuild_large_mapping(struct vm_fault *vmf, struct vm_area_struct *vma, struct folio *folio, pte_t fault_pte, bool ignore_writable, bool pte_write_upgrade) static vm_fault_t wp_huge_pud(struct vm_fault *vmf, pud_t orig_pud) numa_migrate_prep() is the only one which doesn't have vmf as the first param. It's a subtle inconsistency, but one you notice after a while ... then wish you'd done right the first time, but can't quite bring yourself to submit a patch to fix ;-)