From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95104C67861 for ; Mon, 8 Apr 2024 17:45:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 103C76B0083; Mon, 8 Apr 2024 13:45:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B2B56B0087; Mon, 8 Apr 2024 13:45:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBC046B0088; Mon, 8 Apr 2024 13:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA5AC6B0083 for ; Mon, 8 Apr 2024 13:45:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C810912016A for ; Mon, 8 Apr 2024 17:45:33 +0000 (UTC) X-FDA: 81987091746.13.837D20D Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 0AA474000E for ; Mon, 8 Apr 2024 17:45:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hokiIh9p; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712598332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=89Lw7HTouxopI6/9WS538BdZwzz/6yubYNMtG8C78zo=; b=Bnpsa3AMFwTsoNmK0GMI2noeM4p/3kclemYmswR66CqFFx+RbHZy9w/aqoCuznuQGpqYJZ JtiA6TODMW0eFwO0LdA4ZPJDkA7bDLQm0npZrmfbiv46tw+6V5mU2Ju6bqq/Oc0AaXg7zj dJsbqhiJmsNgz98kcgQ5g8omYKawwaM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hokiIh9p; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712598332; a=rsa-sha256; cv=none; b=VZhUG0A+HhMk/KRE98UkvTFoxFFVmuICEuv2T8aU/v2XfRNa6pnNAq5okZrozWYnQjhP95 t/lo7eiDaLm75wVZEirqhvRcNk7q9vEtlH8O2eoUvX2RGdjTShh3ubzGL8i2nBm83pL1Cw Bt+yRyuIp5jo8YArguwaf4i2ZxXhxd4= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dd02fb9a31cso4173242276.3 for ; Mon, 08 Apr 2024 10:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712598331; x=1713203131; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=89Lw7HTouxopI6/9WS538BdZwzz/6yubYNMtG8C78zo=; b=hokiIh9pe6nyrJCu0Ac452fIKWjVeJQ2c56HwlgP2pg4ItFr64nZgS+6LNH/eDMASH SLqa1F37ifyYmPdVh3g05nTXX5VeLXDlftvxvR/RyhyTTeT6plxLcQq0hqruKE6vRfTq JSNzeSG7Fyp9ntjxEvTfOaTu6v2pJ6bOgP0EYmFmvIAbHW0vp6snN082HnwB/VdbWqew 4cMG0xadZPBpePF4fP1eUguvSmIwgIh39LOyBCuLLlyjuB0BbdAoO4HpL8/2eaqkN9La fCu0UxIWQhyaMxRY1YKRXUEU+70wf9CDRQThfdc/T4qS6HwdONX9e8GZkPwQSmCVt3qZ 2rsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712598331; x=1713203131; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=89Lw7HTouxopI6/9WS538BdZwzz/6yubYNMtG8C78zo=; b=JZektE3z78zwjkKzk3CFyu+Y0FeBR0WxZAxSvRwpP/7yyvoue05BqsqOf2aWTwg91G tbVYBtG+LRunL3rqnuk9z9oo7V6OgkdmEnKI9CM2dP8kNRf3nymkafwbqP/D6CalVix6 SbJrCEKBeG0DqlZXvWO+LHChqej99ilvHHeHvl/eDgH1qzrgMdQKmFARzQA3FuQVgvud ctlp1sHsd4SQLdVbQjjIV26W/09olE5Gxqzst18xd0AD/1RFNqNeZD7tBNH4Af11EJbY rpP26P6GPN7HNYb3hiN9cgiGlcccXFZuyWO9X/EQuovlCQJ9P3cNM4UMsov8Ggd36gaM 4IJw== X-Forwarded-Encrypted: i=1; AJvYcCU/e5cuaoJQzCHWI9k6SAA++zGF8pcu+pmpW8aGNcARt+KRzr1yQIMVRoCHby3LMqLhbMIXjn40qs9UTVg5wUbk6ag= X-Gm-Message-State: AOJu0YzSAXrqI93JdmI1FoKHWkY21QWkoiM2aGsWPbKfogJSK2LU+/kZ eQHEMb85v9m97rgUMX7s9/6T79WDos6TqWC0aMbMEStrRuDhd90S X-Google-Smtp-Source: AGHT+IEm6YRDHs61khG9tjG9b4v1huOlor4vb4vgaqiYYmsDaD4F+0+1tqRmf11BeO3q64bQ3mbMxQ== X-Received: by 2002:a05:6902:c07:b0:dcd:3d6:68ad with SMTP id fs7-20020a0569020c0700b00dcd03d668admr10387292ybb.0.1712598330754; Mon, 08 Apr 2024 10:45:30 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::23]) by smtp.gmail.com with ESMTPSA id f123-20020a255181000000b00dcdba3056e9sm1475495ybb.25.2024.04.08.10.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 10:45:30 -0700 (PDT) Date: Mon, 8 Apr 2024 10:45:27 -0700 From: Vishal Moola To: Muchun Song Cc: Oscar Salvador , Linux-MM , LKML , Andrew Morton , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH v2 2/3] hugetlb: Convert hugetlb_no_page() to use struct vm_fault Message-ID: References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-3-vishal.moola@gmail.com> <73DFA2EE-0929-4801-9C7C-A393F7796CE8@linux.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="oNi0RqCEoHgaKVsd" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73DFA2EE-0929-4801-9C7C-A393F7796CE8@linux.dev> X-Rspam-User: X-Stat-Signature: kxnu61d4siddsn9zg9uufhi6b55ird87 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0AA474000E X-HE-Tag: 1712598331-29616 X-HE-Meta: U2FsdGVkX18g4i/j9N0LVwXIBFVZiY4IMRCXlL2yXjy71B1voe0xNgUKAT/P2CZaRCkK4OaaGm23fuL/yjrCYQshm371RAU4jAkkI3GxuCTfRbJxtqqSpudMyeN+sVYFRUKPBKMmC5Rn2timli6DRXwQXUe4yM0AGNQrxa2zhOIpgPgSaPBI5ozTfhOevLBjql6ZvlDr/XSFuiEm1vvkWP23tgTjvF/UgmwxXoiqTyTnxEzI0BB7xUtlv+AOyCaAQld/NjxHOK/ARtAb5ju7/6vNqLBGhVCQvXR+Z2ebvnb+n2hmCzn09IG6JJzNuGk1Iw6WQmR9Hlm/5DplzdIKk0zZlAsB+sPYbAXgWKFfVHFXQIO96/Ld035ZFaVY4l4skI0f+gQ8KhBkM0hu9MKYKppTB4Tosn3U2liLboLQbixPREY1WaCwKebo0VpSJhBkd1/BTFHW/HPllMCw1EL+a/EefteLlsYyLewLgw5UiNURzqZncFdoWC2YKhyOQefnWjVNxLsV/jruLgi7QTFRW2NnkGtjEQkh5QVHkqLrxVx8Oe/4cuOEnIH4yq+YZk/AwpxBO2Z92V+ph1gIcdKR7YvoxhFBOrJG2dqkQMVKc0IlQXHAG+mNqzp6t5U+PbisWqrrYFKdTfwj8ffVsN+XThyY5AIwnA8GZPB4xvAFB2zZoJKcrc9Ak1qeEEbYPNpefRlTXwU22OixSgULkUsQaY5L7TODMnh6am3JRWDelT/d+K7LAMiRZbOFZkw/kDxocC2NAmw9gEnyDNx5kxiXbNrPHkZGgny7bXihqE9fw9H+RqdYpjfvMKSb23n1sFchBdqV+9E6R+6BdO88vu9EGXU2jtAsim3q0FIlPY8+V8uGr/8NqZlyvJUxdFw+gDUHiFra6eLMIAlGthxQdYm30lpin1uh2kWFzOYr4cb8/IcbZBTxmd6uY+QKifjr1EMEAZdfS0018Ure2BR0nho 9jvwSsfZ UkHiRtj8ka4YX05GS9mqzCbK7Di1ydH+l9wJ41umYhwgBWdT/gLBHekLSPdU14Lwp8H2mYiJDs4Zz4DWjrDx3mfQ+Z+ceBFJyLhOf3iSPUDRohmUvDUtmxqEYpSS/lgXn2CcAmDIsmeT5vZSNyN40N+N5AH3rursHFTsyVt3O+AKQfmsyOzUeL8urQ3yjN0ZRaDbN4GcmQ6oH9LAAIIsvNKai4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --oNi0RqCEoHgaKVsd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sun, Apr 07, 2024 at 04:59:13PM +0800, Muchun Song wrote: > > > > On Apr 5, 2024, at 03:58, Vishal Moola wrote: > > > > On Thu, Apr 4, 2024 at 5:49 AM Oscar Salvador wrote: > >> > >> On Mon, Apr 01, 2024 at 01:26:50PM -0700, Vishal Moola (Oracle) wrote: > >>> hugetlb_no_page() can use the struct vm_fault passed in from > >>> hugetlb_fault(). This alleviates the stack by consolidating 7 > >>> variables into a single struct. > >>> > >>> Signed-off-by: Vishal Moola (Oracle) > >>> --- > >>> mm/hugetlb.c | 59 ++++++++++++++++++++++++++-------------------------- > >>> 1 file changed, 29 insertions(+), 30 deletions(-) > >>> > >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c > >>> index 360b82374a89..aca2f11b4138 100644 > >>> --- a/mm/hugetlb.c > >>> +++ b/mm/hugetlb.c > >>> @@ -6189,9 +6189,7 @@ static bool hugetlb_pte_stable(struct hstate *h, struct mm_struct *mm, > >>> > >>> static vm_fault_t hugetlb_no_page(struct mm_struct *mm, > >>> struct vm_area_struct *vma, > >>> - struct address_space *mapping, pgoff_t idx, > >>> - unsigned long address, pte_t *ptep, > >>> - pte_t old_pte, unsigned int flags, > >>> + struct address_space *mapping, > >> > >> AFAICS all this can be self-contained in vm_fault struct. > >> vmf->vma->mm and vmf->vma. > >> I mean, if we want to convert this interface, why not going all the way? > >> > >> Looks a bit odd some fields yes while some others remain. > >> > >> Or am I missing something? > > > > Mainly just minimizing code churn, we would either unnecessarily > > change multiple lines using vma or have to declare the variables > > again anyways (or have extra churn I didn't like). > > I don't think adding some variables is a problem. I suppose the compiler > could do some optimization for us. So I think it is better to pass > only one argument vmf to hugetlb_no_page(). Otherwise, LGTM. Alright we can get rid of the vm_area_struct and mm_struct arguments as well. Andrew, could you please fold the attached patch into this one? --oNi0RqCEoHgaKVsd Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-hugetlb-Simplify-hugetlb_no_page-arguments.patch" >From 891e085115a06f638e238bea267d520bb2432fba Mon Sep 17 00:00:00 2001 From: "Vishal Moola (Oracle)" Date: Mon, 8 Apr 2024 10:17:54 -0700 Subject: [PATCH 1/2] hugetlb: Simplify hugetlb_no_page() arguments To simplify the function arguments, as suggested by Oscar and Muchun. Suggested-by: Muchun Song Suggested-by: Oscar Salvador Signed-off-by: Vishal Moola (Oracle) --- mm/hugetlb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 456c81fbf8f5..05fe610f4699 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6186,11 +6186,11 @@ static bool hugetlb_pte_stable(struct hstate *h, struct mm_struct *mm, return same; } -static vm_fault_t hugetlb_no_page(struct mm_struct *mm, - struct vm_area_struct *vma, - struct address_space *mapping, +static vm_fault_t hugetlb_no_page(struct address_space *mapping, struct vm_fault *vmf) { + struct vm_area_struct *vma = vmf->vma; + struct mm_struct *mm = vma->vm_mm; struct hstate *h = hstate_vma(vma); vm_fault_t ret = VM_FAULT_SIGBUS; int anon_rmap = 0; @@ -6483,7 +6483,7 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, * hugetlb_no_page will drop vma lock and hugetlb fault * mutex internally, which make us return immediately. */ - return hugetlb_no_page(mm, vma, mapping, &vmf); + return hugetlb_no_page(mapping, &vmf); } ret = 0; -- 2.43.0 --oNi0RqCEoHgaKVsd--