From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDECACD128A for ; Mon, 8 Apr 2024 13:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55C3F6B007B; Mon, 8 Apr 2024 09:56:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50CCE6B0085; Mon, 8 Apr 2024 09:56:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ADB56B0087; Mon, 8 Apr 2024 09:56:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1DB916B007B for ; Mon, 8 Apr 2024 09:56:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DAB2016036C for ; Mon, 8 Apr 2024 13:56:28 +0000 (UTC) X-FDA: 81986514456.14.2110285 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A7F9040010 for ; Mon, 8 Apr 2024 13:56:26 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jSkc+D6j; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712584586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rmNJpHW5Hyb1elegWpLMoq/S1yVvTDK8DJLj5yKd5mI=; b=Koim1IORtwVJQJvB12He0C8WBpiCCSbr8TzIL9J3nLomoODyycU/agT8QvY+N/WCb+FxZA 87rmuMvRwoL35x+/mbwpaJnkq+NrjrV40RVxE3S0fOetFlzJp54Y4R/vAXdFefblqyemqX kaIyktlnobXJ2Ygb/of/R6Sr1WDbO6g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jSkc+D6j; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712584586; a=rsa-sha256; cv=none; b=mfdn5JzbEO8QzB5yE9pw7SP9N5Hi8bIn1pQWGR9qneEp8cHR7V+Lsb1QaEBHmQUISsA91G KNfYgi1KQOMw4//y2HnOtumAteSwtaiRVxPtze6sYsEwG33dSY0rNH261DmPDY2SxskO+i HQ3F6mtGXOGjv5awur6eTYP5sNUv06k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712584586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rmNJpHW5Hyb1elegWpLMoq/S1yVvTDK8DJLj5yKd5mI=; b=jSkc+D6jQ67V96JT6DTwSNSLxH1rUBZFARNc5R/BSk3H3V2rn8hWEMn53rcmm7qECEhwzv 4DlNbLLRfAPjUgG4ztQxrrxWKNMTWd3TDmrn7o+jk2HQhR30ZhaNTPBH5Cvke1QkWwDuGc aITJkULCtA6UgkkomweJs2wnjLj5alE= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-_uRnxpMSO4yrldExmcwAhw-1; Mon, 08 Apr 2024 09:56:24 -0400 X-MC-Unique: _uRnxpMSO4yrldExmcwAhw-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6ea20a966b0so46689a34.0 for ; Mon, 08 Apr 2024 06:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712584584; x=1713189384; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rmNJpHW5Hyb1elegWpLMoq/S1yVvTDK8DJLj5yKd5mI=; b=PMLwqKu2p87wZpI/sg5Fyew9dQWf0Mw2nipVk8UUOWtSXAtk3PtcrDal4v0xjEw+gY ZmFNrwF13rvGPUwXVL9obrWasxCL+TNiIDWuSOYuzGKlSQrZ7jLOxAhAZ5w/bQBaAZ3x OkHn7FPqRtVsKJyCpRfJyalpzwgATjTT9SB4M7pxwneBESRa05UcdhfuICBQ1r4WVyAA RxRcQMTCiNrltYe1PzKE/J56wcC8GyZO4F98OdnGCKdcgTg5n5cqEFCUjHHZRctPvSSx JRrzA518tcnwRrIyDp7K2HOq1Gu59DJv+68XaBWVnfEuCQB/G+++HxqVSMbr7nfX0eOC rrsA== X-Forwarded-Encrypted: i=1; AJvYcCWPDsPpLi9azakUYRnEE4RBAwhQu4PhBTMvmtRHyrutvN7V+2QRpjjL4VAiOmzBzGtuqlHz6ZzVatq8Vsk3ktPlH10= X-Gm-Message-State: AOJu0YwShPbcPG59IChhNfh24kDkgE3PCv6zw7f6u4Ls2UId4Hwiuoow yHLOG19haWbDL2JROMGkqX++P0yXxIfcryUhhWmnNIXG/NHvYJqO9aZKNefnxH8U4Za32Txb+ug eNE58iLY9d+QbuBy6jrnC1L3P++3xjca8FCG+Sz7qRQoiBHOc X-Received: by 2002:a05:6830:a5a:b0:6e7:592:87ab with SMTP id g26-20020a0568300a5a00b006e7059287abmr9702515otu.2.1712584583699; Mon, 08 Apr 2024 06:56:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/6cZVOu40ZE5XkeceEvB5GWIk5ESL9MdZGK/RmwIM5NG0Lyufyd1ejET8K1FRMeVweFzXgg== X-Received: by 2002:a05:6830:a5a:b0:6e7:592:87ab with SMTP id g26-20020a0568300a5a00b006e7059287abmr9702473otu.2.1712584583118; Mon, 08 Apr 2024 06:56:23 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id vw25-20020a05620a565900b0078d63baf516sm1301217qkn.129.2024.04.08.06.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 06:56:22 -0700 (PDT) Date: Mon, 8 Apr 2024 09:56:20 -0400 From: Peter Xu To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Sean Christopherson , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrea Arcangeli Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback Message-ID: References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240405115815.3226315-2-pbonzini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: A7F9040010 X-Rspam-User: X-Stat-Signature: tbx4zwtnng8wrytmqq7j9daxwbbzopya X-Rspamd-Server: rspam01 X-HE-Tag: 1712584586-825225 X-HE-Meta: U2FsdGVkX1/E5C+WATnkq65UhV2f8PPJ2SriJSceGJc2wbrlGWBgRJQtkwr1IBRsrAtg4N/EfH3xNT3dWsMOvpiVK0+XYLbSIDvdQ46ieYtO9mf7Re3N+9+KiN1/HvbMNhlxeoQOKoheAcuk32JMCGEgPy2nG7jVkNWoKdlnDB5sUFdg0ds81Mc5kJc1VvWHU4/7rKLMIlwZIOKtDfEoXHaIf0k2nGM4MgfDheywHHLS1a3SMV2QjcWok1NVwjijeKVS//Yc2eY3KGfv0CGfnkni7NG1Sxxj7jtWoC9aKsyXwYbBpHynOEliv4OWVy99g5xrxxXIFXPd8VFEVYSdEprj2FgOBBmj+oAyjJDPKLRGkZ2wg8D9mVXvasHRYU3iSPGwmVhOsxy/V/G4af6iupWgKgW+P90JWYbMHuN/nmEBkNqkZ/rulBEebsD2ozxKNs3ROUsVk+6jC/1KZWxJzxPYDZ+B7sdjKPCmkkGzKtFG6MzESZlX6lO/rjdX5CKex9b7Mb288MxP9QJM3pmuGLcMDx3R0efYF9B0FmoZYdbVAkWkQIBq544bLAvMAvdG/HK0AiPdM+Hl8FPtp29knbeQE/BelgK7MbRHey9O9iMY2BEanx/tRv9pyeyWgV46uyr+lUIwXCoDcvobZGKYiUTunrm2wvUJkwZ87w+gbZNsfXlN1QanKDJJMIWqMaf1xDGvZc4ePYb9/6VW0ZToyrFvSHGguX2799k2u1Jg/FpBwFUrrg+Vr0tJKNOt0s8tjfXwS/AxRj+0eO5SPjBz0VfnfzYspTfUfx4jSjBTfjkiTHF3YNsPFOPKtQNohxJIOPOsIm8AXXlgljFUSR8WkNkCYhLGVZQQ9OjPo0MwvmK8P0geTf7H3vTWIh+YOssd76c441H1gvOQg1Mvj273OTTDxeiMCXInwAAp5m6za96tAdqVqv+Zy05PlCLucFJhNof4ZhYnAvodD5L3Uqo nrMZhmuL VXGGbTAL0N+mI9JkB/4z4j/sCvTnKtj5mk8pFm2V4b9OSJT3agOB89blZ/N9wWlQsa3EOxU5cjDISKwf+8SzUY8IGlK24RozTUAKSv6+Y2eHij/6pkynHnVRxNDVqJJ/FOjbXD0ZC4tYLP3p8y+quu8StUX6vk1GSVw8MSlnlsyjvyIYMcoN2NSBp3GCSnWW8Bhe+3hQ9sNThJbX6Xs5Koflg5pXj6wuZ//jbz/n5oGsRn2wxXVfPSwnIu5Fs0h4OENArEIPcZA0LjyzU880UebUnjuabVcYXUNEuaT0/n8XH2ysQbGOvLflWfGSk8ZqcFnorG3d61FsUe4QpU4nemVTg/CXi8b8oCCCQ0Hq2nivmChYr7Z/j7wuyQrd2iR6Z9FywR6c5aUp31VB1V+jpZfiaHOW6y3sn+R48wR/O53sHVEKgMWpS+vr/QA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > The .change_pte() MMU notifier callback was intended as an > optimization. The original point of it was that KSM could tell KVM to flip > its secondary PTE to a new location without having to first zap it. At > the time there was also an .invalidate_page() callback; both of them were > *not* bracketed by calls to mmu_notifier_invalidate_range_{start,end}(), > and .invalidate_page() also doubled as a fallback implementation of > .change_pte(). > > Later on, however, both callbacks were changed to occur within an > invalidate_range_start/end() block. > > In the case of .change_pte(), commit 6bdb913f0a70 ("mm: wrap calls to > set_pte_at_notify with invalidate_range_start and invalidate_range_end", > 2012-10-09) did so to remove the fallback from .invalidate_page() to > .change_pte() and allow sleepable .invalidate_page() hooks. > > This however made KVM's usage of the .change_pte() callback completely > moot, because KVM unmaps the sPTEs during .invalidate_range_start() > and therefore .change_pte() has no hope of finding a sPTE to change. > Drop the generic KVM code that dispatches to kvm_set_spte_gfn(), as > well as all the architecture specific implementations. Paolo, I may miss a bunch of details here (as I still remember some change_pte patches previously on the list..), however not sure whether we considered enable it? Asked because I remember Andrea used to have a custom tree maintaining that part: https://github.com/aagit/aa/commit/c761078df7a77d13ddfaeebe56a0f4bc128b1968 Maybe it can't be enabled for some reason that I overlooked in the current tree, or we just decided to not to? Thanks, -- Peter Xu