From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21876CD128A for ; Mon, 8 Apr 2024 08:38:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 906A56B0095; Mon, 8 Apr 2024 04:38:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B6A46B0099; Mon, 8 Apr 2024 04:38:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77E1B6B009A; Mon, 8 Apr 2024 04:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5BC356B0095 for ; Mon, 8 Apr 2024 04:38:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1F05A1408A4 for ; Mon, 8 Apr 2024 08:38:50 +0000 (UTC) X-FDA: 81985714020.03.7B05FF5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 889E8100012 for ; Mon, 8 Apr 2024 08:38:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bQjM7iN1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RJuKPCAu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SiLVrbBS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xirxDqDV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712565528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uwj3JbLD7BKun3ExrCgpdE7EoWxAzmC5eFj4hgIUgzc=; b=AwpNgLy/YF4wQBSydSE7bTjIS5gNcRD7FGQqftnFYg/uPffVgDLpCZk2LWaBoPXDZdmr2j zM1WtrcUWjrz9FcSy5w59gXaFOarXaoNm/jhkjSDUF2vWU4UAYzHk+2pqFaoXUuP4yICQc +who3jJUcXUoLLAeP9YGUDEiycjOAjU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bQjM7iN1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RJuKPCAu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SiLVrbBS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xirxDqDV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712565528; a=rsa-sha256; cv=none; b=uCcNJN6hr2oasqY7E+DMTyxbdpqrhaG9kBBsSuc9Nm07o5kre9RSeQfK9CD6zhP9a3msWL teGAX58C9QWt8E6ZP3AtQKKNUMx6+Q7hoYXkp33tJhIyKbTOl56yvKICqogTiSp/3WKszT mwSWyWenGHWy/3jDjfgwOlydj2o7Zsw= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FD7F20216; Mon, 8 Apr 2024 08:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712565525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uwj3JbLD7BKun3ExrCgpdE7EoWxAzmC5eFj4hgIUgzc=; b=bQjM7iN1MOxIU5bzvPcqCwH5r/tNIMEzlCqXLYxXDnq+ub9OHTM5+PIiadc8+RUPPJ5Yyh VM7164xNrnJamL9DvMEjBzUXlBVBYo7ULATm7M3IFy4iKKpQqwDRitzxg533Q3LB9cN9Ws AE4B2ScfYCuyOxAn86fN2a7HhbhV/pU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712565525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uwj3JbLD7BKun3ExrCgpdE7EoWxAzmC5eFj4hgIUgzc=; b=RJuKPCAuwK2No9fzXyGUbVY31cWdKkZs8F7FUhWDK1NE4bf/1QH2qxr7ZWbkKWyQojf1i6 NgBP6KxxrGYvmuCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712565524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uwj3JbLD7BKun3ExrCgpdE7EoWxAzmC5eFj4hgIUgzc=; b=SiLVrbBSJnRd7N8cOdzaN634wlBtCeYIquZGxihR4+wENZdbf8P6PPiDa+qAk3rRxMl2Ol 8qmOLP3txCznxrGa4OxGqe4PYnzIXGOJASiLiHreBunsdHJLdXP8qrLjdfyhE1eJ3tco2M lrqek+1HxriF/O6nEnkkIq7W8RHKLVc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712565524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uwj3JbLD7BKun3ExrCgpdE7EoWxAzmC5eFj4hgIUgzc=; b=xirxDqDVmy4uOe8Yy+70NYnEAAHytWEHUnJGKOC7R2WIkbwTBblqGI4rsaplyUWtZa/x02 jppQn6xkNwCwW6Ag== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id B30211332F; Mon, 8 Apr 2024 08:38:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id zBSLKBOtE2Y5IgAAn2gu4w (envelope-from ); Mon, 08 Apr 2024 08:38:43 +0000 Date: Mon, 8 Apr 2024 10:38:34 +0200 From: Oscar Salvador To: liuhailong@oppo.com Cc: akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, surenb@google.com, zhaoyang.huang@unisoc.com, quic_charante@quicinc.com, yuzhao@google.com Subject: Re: [PATCH] mm: vmscan: do not skip CMA while LRU is full of CMA folios Message-ID: References: <20240408080539.14282-1-liuhailong@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240408080539.14282-1-liuhailong@oppo.com> X-Rspamd-Queue-Id: 889E8100012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s844i6xmjrndmpbq63wfi9mak1ydwxnw X-HE-Tag: 1712565527-487794 X-HE-Meta: U2FsdGVkX18/O6CPdmsvoenvK1CiLwVwKaXe5MDzQ9g5VFgDFR8NNWhyaN/8svjzzOghw9/OZrJ3MezUQcx7fODh31iSj68rfZOs+m/9dC6c1gDTQgbDx17RV4ys+iMAJC80dW/ziPefZYbQZbgUeWcUETiM3KTQABDvCWAZnY6qODOZOLm2oqrigStYJ/Kk+ygP4/9k78jDURuhIvvNPc/MXlwqeNS4tqhaRZfvfWTO7LT7uxOCwGCfxlMdsNB7SjAUCtCtI7Qmql/z3OJH+0Z9UjtTwT8jq3HMoo2b5gKtqhnkyO9M1e9PW7nDhWAxFuWEwuzM3mh+x/e7/47J/sYpAGboNjhVW0AMAMClOfCLtX9rjMvRtjjDMpXKeUUFa6yYat5pdTUfUB+DaHP1tPf+gmp6WiTP+mkNyMIvuWV3npJIAg85A2LlBaaVjuefMivd1NN3G7bEZ8UPWXBceCW5mca6YXpHqYJ4uqpahz81jtDMbMNJSg0P2FA8tL9BtVnRVgoR4o7SG+Qnt5bmRq9Qx8NaoX13g1VPfMLn4+aPkh8t76a2Z8bPAF7UbFPR2qzk29oZex+2ff+3q93iAsH1c1CdmcDGW6ZDIOBg4bL+/JLxL+XiK5S2VbMKANFN2eXPXHiEWA7gBGPbjVUxGEAD5mX9dHdtDFb4ca+c/2dYlDhV2khajnHghQqUS0tO0sCYGrmOrYEp9WsnDRBI08D3FTTijKMWcHfKwbgSga1tA7UTC58Hl6a0fHcN35x9hAkxn2BjnR/ZJhoAvLJxd0R7RhyUGADNR/o3MOZ0pH4G7+zvy4LRvY7tDr/+dymyc2O/CjLtICw8wS07xNcspBSAl3xVmtax+BsuuGWhhQmQzE1vcyCLpT9Fvbvem0NopIaxv1p7QuuAQ+x1mu+nNo5vRvupEVUhq351EXOK3rLmDg7iTH0Ej+si8zekcIMFKMG4Qj7vVCpQeOITs97 aZ3JJrO/ lAmDPxlz9KgCXUrCWbvuq6yUxx7n5Q5Jv6R0f1zwguZN2Fvd+v9nq+CCUMheOBuJtWEFPn2ZMV3N+KB/RtDWFHM4VadsxKwgf1uDfjBUV69k2BHf0wnHokT2Z0z1QwYdu3/9J4+URSUphvoxwvMLSGXHpwUGoTriHsMTOJ5IEQq/gKAlVN6nusjtx0NtEge5B+966Yob8PY8DY3pbPIXEjMTt91gJe0QnDPjFBvjoCyOdcxY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 08, 2024 at 04:05:39PM +0800, liuhailong@oppo.com wrote: > From: liuhailong > @@ -6202,6 +6213,16 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, > */ > if (sc->priority < DEF_PRIORITY - 2) > sc->may_writepage = 1; > + > + /* > + * If we're getting trouble reclaiming non-cma pages and > + * currently a substantial number of CMA pages on LRU, "sit on LRU" ? > + * start reclaiming cma pages to alleviate other threads > + * and decrease lru size. > + */ > + if (sc->priority < DEF_PRIORITY - 2 && > + sc->nr_scanned < (sc->nr_skipped_cma >> 3)) Why "sc->nr_skipped_cma >> 3"? It feels a bit hardcoded. Maybe the comment or the changelog should contain a reference about why this "/8" was a good choice. -- Oscar Salvador SUSE Labs