From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE3DCD11C2 for ; Sun, 7 Apr 2024 07:45:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 602506B0089; Sun, 7 Apr 2024 03:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 564636B008C; Sun, 7 Apr 2024 03:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38F7B6B0095; Sun, 7 Apr 2024 03:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 179B06B0089 for ; Sun, 7 Apr 2024 03:45:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C65F1A0845 for ; Sun, 7 Apr 2024 07:45:48 +0000 (UTC) X-FDA: 81981951576.19.CF698AA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf04.hostedemail.com (Postfix) with ESMTP id E3AC140003 for ; Sun, 7 Apr 2024 07:45:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gnZOL2aa; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of yujie.liu@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=yujie.liu@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712475945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hwBd3xA5nPVBhqOMbvVWWjX8dXmymPwkbVGwJqDJqy0=; b=HZS44RcefFRcQd4w/jIkGm3YmpBm9JROMwFaLdP3h8ci7V4NsYEulAPd2Mcl7zndbAgS3B GLFPmvv+KIIYD3kFuVvcH3wLIXvz+FgbUXleMiKwPBul0S0BhRyoTvA0PvszCHKmXceh69 YAM/H9fALqdO3+s6T3C3BTI3XcjXuyg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712475945; a=rsa-sha256; cv=fail; b=QeFR350JPiEFPHVeQ75Z0bxxoiIY3lwI1dpnO5o/9PGe6bRplffD3qeeDjpAjuLXp/loyM XgtqPxlgVIA3F3L6JyqvNVNdppeOzZndNXfxn8jNwj8uW99pBiJwUjLxJxSivhiXPRqs63 TnpoaIEZzqTymhNl+mpwzezE0/OBPnk= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gnZOL2aa; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of yujie.liu@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=yujie.liu@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712475945; x=1744011945; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=L2NX8RVti6CbaOhdh7W4AM0hmynILq75ttiX1M5zAqg=; b=gnZOL2aamjwT8QsSCVKnEOjIKkAxIZE/A7g/PQVpn7BcWMqK2ERVaXBa jQUmNp6cFGDqNRwwEN2W4WUBdfO2T8yunk5CctWFENqQtPF/itC3tXDAG SxIC+NLNpoBs8Eck5JeB78FEcbd8VAueK/0B3ONM33fJw4CS/ro9l0Y1m Y3vhFIgoVvJVq8FAmz5bet4uuAnNd8XgdMrgdpTWrNIlmNe3rmR0OYmnK UCTCSQ+kemezck+qBaXXqAWbwAUMgrf3l5kqFQz9lvwr6uSGoI+9GqusW K2oF+SZIozDn8D3QhCGDwk32/5LXjXVucvh+k8P92BBuV7ZcJ+ZfPpk1z g==; X-CSE-ConnectionGUID: P8ZZkBcVQVuki5ta41wq7w== X-CSE-MsgGUID: Xy8PX7EYTkSlIDIn9RyP5Q== X-IronPort-AV: E=McAfee;i="6600,9927,11036"; a="30251931" X-IronPort-AV: E=Sophos;i="6.07,184,1708416000"; d="scan'208";a="30251931" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2024 00:45:43 -0700 X-CSE-ConnectionGUID: RAJPWUmKTfuHGnX0ogM8Lg== X-CSE-MsgGUID: UZv1pl06QUipqum6Nx1TAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,184,1708416000"; d="scan'208";a="24068701" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Apr 2024 00:45:43 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Apr 2024 00:45:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Apr 2024 00:45:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 7 Apr 2024 00:45:42 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Apr 2024 00:45:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+6QDtnqtwT0rjzPrVbb/FJOdIKYYXcgC8kCeqzTvKzukMxnILia+1KSkd4aJrwvH82QYkv5QMkgZmSItYpVzYifhrYdrXjnP3N/jAH54L5ohnQ3ix+5wyACuL5MAR1Hwu43EigQExhdXMqvty5EdfErc7rsgELEcze4KX0VtjK3v/JgfwUO79PWoiWQbFDZ/FKwSpkm05aszDcDJrjisuFBGt3D6ec6vBe+SwyCVJL6jUy0GYHYQddtdrTDmlZ/pl49n5oH3mhU9DaWZuvlw2R/Qyc4o0udgQ6d94i4wcwJHDPIthMno4IjHwpEUqQwakZ1G7nTOl5Pvdf+e5qGtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hwBd3xA5nPVBhqOMbvVWWjX8dXmymPwkbVGwJqDJqy0=; b=DmNZxFLdLfcdfqb2jD+ILano8t1BniWJkPvEhwzC0YMqpAyLU8MHOdQZuQeo/j79P49FPMGbYp8BKyBFi64Zq9X7VKqsr5YpHBm+/zN9BdvnlcSGFxMMs+W7bE1YQKeFmfPRVvMI4YpqvBn64I9gWlLLTo4AJ+SOrO5G3yJx1/0o76Nvi9gpCU/TyJQJx9KW88nw904HWcXy4g2lp8K5GRFMzi79FPs0i4ECeDU6UAbx/3jf0vEF1G8eotTcgNFEU7RdkQwiwSwKsIkzuWfDFQlE3h90w07JNKmUeA283Njc1SmSseHgCME3/2/MeGxKig9zC2o1EXVtgyDOv8aiVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB8393.namprd11.prod.outlook.com (2603:10b6:806:373::21) by SA1PR11MB6736.namprd11.prod.outlook.com (2603:10b6:806:25f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Sun, 7 Apr 2024 07:45:40 +0000 Received: from SA1PR11MB8393.namprd11.prod.outlook.com ([fe80::c0cf:689c:129c:4bcd]) by SA1PR11MB8393.namprd11.prod.outlook.com ([fe80::c0cf:689c:129c:4bcd%6]) with mapi id 15.20.7452.019; Sun, 7 Apr 2024 07:45:40 +0000 Date: Sun, 7 Apr 2024 15:39:01 +0800 From: Yujie Liu To: Barry Song <21cnbao@gmail.com> CC: , , , , , Subject: Re: [akpm-mm:mm-unstable 313/322] include/linux/huge_mm.h:274:16: error: fields must have a constant size: 'variable length array in structure' extension will never be supported Message-ID: References: <20240406224038.5412-1-21cnbao@gmail.com> <20240407042247.201412-1-21cnbao@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240407042247.201412-1-21cnbao@gmail.com> X-ClientProxiedBy: SI2P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::18) To SA1PR11MB8393.namprd11.prod.outlook.com (2603:10b6:806:373::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB8393:EE_|SA1PR11MB6736:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fSXDGA1m4Pn9tRtmCK00rUDJQVoQWNv0gZV2HvzDVRV5re/W66NPVLPo9nwFuScj5RZhzwrmoBhEVU+0pM34v72j46i1ypbb4hJiUnNYJCq3AjIlRztaVz1RtW9U9tgGe9eI1L0aUOb9ALO10/vryLjYKuwBz4h3NP68ms+w3hmRJtTvKSCZ20UkMFA6J9svSkEZhtxN+LJhCyb86yGUsIOiC3JQTtr6RHffbYDRXHdJINMRHimn0k+aSWSHjKb6Wy4jUBn8qL23r64mtvQSlq2BY0z+5mjwPV8taLhTFfW9Mnx8kDQIzF3xKGjqHj+iXSrxeUhrkCSDHwlnTel5NwmBjI15H4cxh2McHA6RDHY7fed71jn0C7Dr5UN76kNLLhHJQkIYsXkih9xkU5gT874QFcPY3HfuA4hCa7wERyco802qdlipir1B12wYyseIYdg9AWQfk9SW4yUrUxgxaEY/Fg77DFYykM35tbImaXQ5mDqqsZBH9OADLtSGDRV/37+op65mPXKRUCEiOKFOat1VNbrtDBixdYysDkYNVrLCNnB0zDIMaYfWBlSGcGQgT8IRtW5Aa0GGiR4RNFSlE189zPuwkhsNhR6yRFBipNhng3IChXZaXcsK20SAEj0s X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB8393.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T6XbmzvkBfZK82PM/AwzIksPHtQpbbsK4PkislPjuSPJzY0FiLfeWacG8dal?= =?us-ascii?Q?vra0o1aDDf5l15lzp3sarSr9FcElrwWy4mG1UMHT5QMUCtBMdR06iGuKntLV?= =?us-ascii?Q?nyLIt7vhQ0qn2eY8QC15Gg6kaC/Bbx4awRVmbDEEq8rqIKaP3jGk51vLOVIE?= =?us-ascii?Q?1TlkPDI8Fo3rd31S+HKH97vTP7nq+NCnsfjjMrM9Lxnm6yjQBI3LYhRw+y5o?= =?us-ascii?Q?2OmQcuVnms9eUGUi8FBY2s2xfDox3J+Qmbs4foDmSKv0ybMjRNFB8+Bpn31X?= =?us-ascii?Q?1z5c9RbLoq0gGv+2MiZg3SnJut5zO7xQDmzL0Ww64Q4nSfIxlBaoFDidNaoM?= =?us-ascii?Q?K2oFW54TvtRR0Y8yMQS+ln/cVNAEB3ONV6UoYTcLNhH8v/tTM5bPcWTdM/4q?= =?us-ascii?Q?vz914vftAzeY2oPBOf373oY2RNVXibfdb9xNifGRptnkVwldaC4AuaZAjb6Q?= =?us-ascii?Q?ChtALOYrDqXBMDYUIomuglikgCNv4lUt9v/vn6Kp4uTaWwqe1+bvi1yAy/NP?= =?us-ascii?Q?wIZ7h15EGHe+iMTtPfpYQbg36ygcm0/KBrod2Dft9LTFrnJBs0d7AEIJp+AO?= =?us-ascii?Q?muaBVN83a53pfG993yOCtO9qe81o5Xf1o84i5gtxETFUB97YwfQBgGPtHoBb?= =?us-ascii?Q?ai2EAY+8IDQlCE5dbrEqAqTl9uLKRRV47Wr9ZC6V5cGmdmzcPUN+DhZTbugj?= =?us-ascii?Q?bm6a0NHntmc/EmXVXPDyd5Wc/PmFtv9ETAL7KTo5XHBsUp1Bp01/rXHauJM6?= =?us-ascii?Q?g83wvYiC9pL4QpTPEohkgO8fY5kzQoIpmvpLoKI6iDrO/5uXBFPIds0dTSzy?= =?us-ascii?Q?L71/yyVS9X7FoVxTZDv6wcY76mcpoimSrjwLk5qejfbHhM9yqgSMVWtCl2+8?= =?us-ascii?Q?LT7s849RoNuGBcvWpN9g8x8cNxQjVJ+3A8h2n33oFQWipFxxf1S03D6L2uMx?= =?us-ascii?Q?aq7pTop0cj9YMqMpyOfVhDQ0DE6z7KF3HFvYQlObMKDl2YMjlslQ/5w6QyKf?= =?us-ascii?Q?SZ5UZT3CJRJv7fmPGcZ4iZ1mLT2+uAwDyeWV/yvGI5sVCVVniz/VzPlXWDA7?= =?us-ascii?Q?GZk/LO41Z1WprQU1ds3LqQ8NfeMzsdww4PdGGcJcKRxkIome88NlJBCS3AQk?= =?us-ascii?Q?8qN8Oqg5qZzl0TVtZ8nxdCHvBCt08CyzQ+5vgFkgkf7JASM/VqtafH7sDZae?= =?us-ascii?Q?BWc/mByHdOXN8RHa4CQ7EgvxcbTE1aTpB81sykuNSgmufykcfX4rBXaOfOfV?= =?us-ascii?Q?kzkkiKUT7yKPY4S9VcQlDmE0qY21iNb7dn/A9oGMsFhOK8uIoLFI4Og4vMfM?= =?us-ascii?Q?d8YJs+e1Bash00hkIIGZI8cBGopRFq4ArEnxkT5vV0e8AjGVkDUYX5W59tWL?= =?us-ascii?Q?H2/g3AX9d828UF8x1OUX6FYJQ8iWzSjuykXREhGkp/oeeUJDkU7BT5Qt1lRS?= =?us-ascii?Q?qzputLxHGXKQhzV8pQVR67M+i8BY8ZnpkY8XiTHFmK/jwx2khNUKVrMpfxj3?= =?us-ascii?Q?qMAP7L+E1yfc8xUA8hga8cyQA4oKMgGh5bpczfTSLpBnW/y4+Ag96QBEoh7m?= =?us-ascii?Q?vA8Zw3FtNK2TuIXMef1tSiScXNRmf1LrM6ADi6fI?= X-MS-Exchange-CrossTenant-Network-Message-Id: d7a4fcbf-6c7a-417f-5679-08dc56d6b878 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8393.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2024 07:45:40.0732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5WEJHx80s03i+YRbanxTO46xQHwncTIRG3QxN0jgIZC0+DkyhqYpQYzE3yFoeSTfFBtMob5dwR/1DNsDJYOUDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6736 X-OriginatorOrg: intel.com X-Stat-Signature: rma3scj7tjnndyi8ybrg7yxba5q1bnzk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E3AC140003 X-Rspam-User: X-HE-Tag: 1712475944-71693 X-HE-Meta: U2FsdGVkX19AYOZ86WJz7dt21IefWAZQdlojOHWqxDcTm4ZVN5a5vKCFeGhcc3u8r4XRw8FrvZSNvLj7z7g5CF7186QkJyPF8Xq3yQy3m7l6S/jcG7uAF+qi5iv4W+0PjJMzN+xxBWNKpJTVS41v7c77lQLi+9HjzYtyWZxBpbhoQgAA51mbYu8qtJhfV975CnrPaHdE9ddKM3iJEKPlzin6CQHo2SwKSzGzP7f/tqbfOtT77PoA94E8pfnBYnP28QnVktVQ0A4tmoyyXgUyKac1NtxRT67PxLfs9t5PeFKkbRRWtV/lG4z9wZuORGUr4orCH9oI91+G8+dUy4tXzueBxr9qZLK80WWdlucUrl4sq38KYx/Yc8PDdD0D6/Qex6CHTrQZYIiRfFeITer8iFZczR0qOtup0TlDWDiLW0ct4oGq3BVX/gdpqGdynVcXKtiBKVHllI4hBaupKWxN5jNiv3EoL9W1e/i8WRF4AWKz48I535M/iyhdtG4o4rgCwX9lUsbzczHj9iOgeUVDA7vgCIzNhIkcv/lz9sFsa12ehJ79dzA7LS1CcGj9qXuaL/3RYBmDDz3NuphOmKMRAcD9MGkEhGtAEFIYnXljoQxkYe6bFubvkD11gM4hRsu6564MXrYlhAsFOX58zl4ETDe602D7blUL/6DVW0yMtfLFsYA7QjvvgdDkCsWCuTz2LMw8GkujYVAkAa3jJHrnga22oMfKveVsZ0WP75zmq1ILHqC6muN8fjIyJSuq/YQguC/gE0M0T/9AGtJej1D2i6QFIbyljb4vq+tm6bhrv0swbcWaN3qcBmLXHJkUI5YclpCjmOOxokCzOyTPXuTDW/z5aSXds+ooJXby58BaCpXQltnHkQmmYTZuhFt4x2XWIMtWgcsbKyNoqhT5EMTuz3OdXDBevwTsfgjIKOebW9+xyZSQCngGs+9LYXwF1RTw0KYcnQOA6kMjdg73Vwy KfsDpila m4aVh3Pm7vr5VkseTfM5iMfyw8qsqHYluQUaW09Xi8xuTgo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On Sun, Apr 07, 2024 at 04:22:47PM +1200, Barry Song wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > >> head: f43b3aae94511d62174c3b29239da0dd22d0eeb3 > >> commit: d4358ee0a075e232114dfec0cd162860cfa2771b [313/322] mm: add per-order mTHP anon_alloc and anon_alloc_fallback counters > >> config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20240406/202404061754.n8jmZ6s3-lkp@intel.com/config) > >> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 546dc2245ffc4cccd0b05b58b7a5955e355a3b27) > >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240406/202404061754.n8jmZ6s3-lkp@intel.com/reproduce) > >> > >> If you fix the issue in a separate patch/commit (i.e. not just a new version of > >> the same patch/commit), kindly add following tags > >> | Reported-by: kernel test robot > >> | Closes: https://lore.kernel.org/oe-kbuild-all/202404061754.n8jmZ6s3-lkp@intel.com/ > >> > >> All error/warnings (new ones prefixed by >>): > >> > >> In file included from arch/powerpc/kernel/asm-offsets.c:19: > >> In file included from include/linux/mman.h:5: > >> In file included from include/linux/mm.h:1115: > >>>> include/linux/huge_mm.h:274:22: warning: variable length array used [-Wvla] > >> 274 | unsigned long stats[PMD_ORDER + 1][__MTHP_STAT_COUNT]; > > | ^~~~~~~~~~~~~ > > > > This is amazing. powerpc's PMD_ORDER isn't const. I will > > move to alloc_percpu instead of using a static array. > > As replied in another thread, can you please test the below patch? > this is v2 combining the fix and the fix of the fix. This v2 patch fixes the errors/warnings reported in both this thread and thread [1]. [1] https://lore.kernel.org/all/202404061627.ungVloow-lkp@intel.com/ Tested-by: Yujie Liu > From 6f8604a51ff3333be467e2a681a1f1e8a5d41c48 Mon Sep 17 00:00:00 2001 > From: Barry Song > Date: Sun, 7 Apr 2024 12:23:35 +1200 > Subject: [PATCH v2] mm: fix powerpc build issue > > On powerpc, PMD_ORDER is not a constant variable. We should transition > to using alloc_percpu instead of a static percpu array. > > Signed-off-by: Barry Song > --- > include/linux/huge_mm.h | 9 ++++----- > mm/huge_memory.c | 12 ++++++++++-- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index c5d33017a4dd..0717063dc5e7 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -271,16 +271,15 @@ enum mthp_stat_item { > }; > > struct mthp_stat { > - unsigned long stats[PMD_ORDER + 1][__MTHP_STAT_COUNT]; > + unsigned long stats[0][__MTHP_STAT_COUNT]; > }; > > -DECLARE_PER_CPU(struct mthp_stat, mthp_stats); > +extern struct mthp_stat __percpu *mthp_stats; > > static inline void count_mthp_stat(int order, enum mthp_stat_item item) > { > - if (unlikely(order > PMD_ORDER)) > - return; > - this_cpu_inc(mthp_stats.stats[order][item]); > + if (likely(order <= PMD_ORDER)) > + raw_cpu_ptr(mthp_stats)->stats[order][item]++; > } > > #define transparent_hugepage_use_zero_page() \ > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 5b875f0fc923..7a72760dc1ce 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -526,7 +526,7 @@ static const struct kobj_type thpsize_ktype = { > .sysfs_ops = &kobj_sysfs_ops, > }; > > -DEFINE_PER_CPU(struct mthp_stat, mthp_stats) = {{{0}}}; > +struct mthp_stat __percpu *mthp_stats; > > static unsigned long sum_mthp_stat(int order, enum mthp_stat_item item) > { > @@ -534,7 +534,7 @@ static unsigned long sum_mthp_stat(int order, enum mthp_stat_item item) > int cpu; > > for_each_online_cpu(cpu) { > - struct mthp_stat *this = &per_cpu(mthp_stats, cpu); > + struct mthp_stat *this = per_cpu_ptr(mthp_stats, cpu); > > sum += this->stats[order][item]; > } > @@ -636,6 +636,13 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj) > goto remove_hp_group; > } > > + mthp_stats = __alloc_percpu((PMD_ORDER + 1) * sizeof(mthp_stats->stats[0]), > + sizeof(unsigned long)); > + if (!mthp_stats) { > + err = -ENOMEM; > + goto remove_hp_group; > + } > + > orders = THP_ORDERS_ALL_ANON; > order = highest_order(orders); > while (orders) { > @@ -673,6 +680,7 @@ static void __init hugepage_exit_sysfs(struct kobject *hugepage_kobj) > sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group); > sysfs_remove_group(hugepage_kobj, &hugepage_attr_group); > kobject_put(hugepage_kobj); > + free_percpu(mthp_stats); > } > #else > static inline int hugepage_init_sysfs(struct kobject **hugepage_kobj) > -- > 2.34.1 > > >