From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37A4C3A59D for ; Sun, 7 Apr 2024 03:46:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5055D6B0082; Sat, 6 Apr 2024 23:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B6136B0083; Sat, 6 Apr 2024 23:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A4026B0085; Sat, 6 Apr 2024 23:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1D3706B0082 for ; Sat, 6 Apr 2024 23:46:25 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AB2E91C0A15 for ; Sun, 7 Apr 2024 03:46:24 +0000 (UTC) X-FDA: 81981348288.24.B80B69B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 471EC80008 for ; Sun, 7 Apr 2024 03:46:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f8FHtQAj; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712461583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qC+RNHxgUQ0H6xwcdyP4R3ziVyvlBZj0FQIh8zpbxyQ=; b=MDKZw9zDXvo+9NYFbDq06aSxQNSNiFwDq88rH+4iVWIWYnApZE37arihAVcAUaEkSOnYKC 7uQYSg/E3nNasNlfNdMS/ItbuhiQau5PLbH7aQf54KjGeYQRacRTLFNKIF92iI5oecCNVl R7bp2SJjuaJVAS5Er6EPyh0ZmGqSOEQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f8FHtQAj; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712461583; a=rsa-sha256; cv=none; b=D3xBedesCauAVW8DvtK5vyvAyPf+kcMeUMzNR2QARI//tbOF5PCfugSwZC9n7Q91hwOijn f/GiE2qaedBI9NulMPOBcdH3BWHB8bJhsMzo3rwSwIaneHjwL9qrVgc9m5YrUL9GNLrhaT DI4opUDPW4ir0DGCVyuJzNurrY5weYI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qC+RNHxgUQ0H6xwcdyP4R3ziVyvlBZj0FQIh8zpbxyQ=; b=f8FHtQAjXooo4bGuwXV5sAoQFs u+zzc8fGj3e0cdJGZU3SBmfNbROTMKhHfh2g7nIAgrI4aLyQ92lid9gkxNWZG1eqXJXAxeyvb2b2k WDcBKsXql19HT2FDqF/FfNWg/yNqq2HrXcTMHTXNUJ0ATGGtIUAG2R8YHHVVwRJLCR7zRcz2RfH3g vjrqFyr7OLp07F3W01HOhlZv15KIUUw7XaBuAMfOZ0n24IhW+HpSl1Lp3+K/lhswYOck+U8ALfmUl eGECg4jAw0SWcmE4qfGBU8qVRDV1TLlZxjkoEJcQ6zhVvviiw5qUU+WITFqdkaEmP9NuCSuDsitrx HCFbUIeQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtJU6-0000000EGzH-0Cb4; Sun, 07 Apr 2024 03:46:22 +0000 Date: Sun, 7 Apr 2024 04:46:21 +0100 From: Matthew Wilcox To: Vishal Moola Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 4/7] khugepaged: Pass a folio to __collapse_huge_page_copy() Message-ID: References: <20240403171838.1445826-1-willy@infradead.org> <20240403171838.1445826-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 471EC80008 X-Stat-Signature: pr6xedj3z7wt3jsx31yz8ny4z96arb39 X-HE-Tag: 1712461583-499156 X-HE-Meta: U2FsdGVkX18fOntnf8jMtT/81rUh/bkNe/h7NJ9F/1JD2uG/pLtOsDaYekedQB0TOnU11p/KvTmZFwEL2rmsyAS5zAzXybM+BsILDRJC/vf5a6PnzsN9SQOMqMUF78t/YoQaWAiQcsGayK+6SUnoLyNvPYDgnKTtsfGVr7nqT/1rfl273Pzqdj5+ysqEVCeJWxO92VvP/zNKQfqe+BFa0fMrysDiXcjtizhYPFSbAc6KrDS9JwIphdaO39HNWVhJHbzw9SDHBqkvbeDFMdO6x44TBNGAdDnyT0yhRqaW7MHgOB2u7j8VdwyWfbgvYgznRwPKdAl4kcYeuTnEfs5V3u1Xb85ZCoHbTQ9zz3/Jl5FVwltm1DvrlOGZdozr2R6x1CXYTS2EDS1PmgJkXyXipIt3ikRRTFGM31fhUioIfvYcmJyAUthXX1ecTlbCqTAgtJK6UziKs70Cp/Zd7+HP2VU4XQNt9W8FPmRgZZVVgQ2O3d5V1El5oh9juXoGP1ptknfCkiQjq2bPAvG0ke5ijk/G6KZPjXa7osR4AbYxwqxyCeJxXlhJZVzQHW96S40ojWh3y541CZuhrLPCdYJBYximVuj1Y/hWBR+eCzcosCyGnodATzt/4U6E6FPK8JBOmOYXdIWYU7iZAiLMjcG+MxWUPdFUY4SIDpC9xNYl0WnMO8EelNCI+4jGL9jswlsYz1a0nG1Gis+auti9Yo79xBhsXUh2XHJ6D5a6D1mkaj0E2yQbSLvSBmgxcq0ERuA4giGkJ1vtoSp/zz7Cw/6N8QXZRcZnjqq+UAHlwtytmNCBanIB1iNjFmjxTukffF3TNycoln36yZMUwxFa1GvVMZ0eUskhS9kl9Od5tMDw2xK3DUgNSsv5RXcQ/TFXkyHY7hnz7Zb3F6lUa1uH+9OZBvTz4YzsLepG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 02:19:19PM -0700, Vishal Moola wrote: > Additionally, it looks like if you put this after patch 2 and before 3, > you could avoid modifying this line twice. Ah, yeah, good point. If Andrew hadn't already taken the patches, I'd make that change.