From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19CF8C3A59D for ; Sun, 7 Apr 2024 03:44:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 996B36B0082; Sat, 6 Apr 2024 23:44:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 947876B0083; Sat, 6 Apr 2024 23:44:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8361D6B0085; Sat, 6 Apr 2024 23:44:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 677756B0082 for ; Sat, 6 Apr 2024 23:44:15 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 231F8120819 for ; Sun, 7 Apr 2024 03:44:15 +0000 (UTC) X-FDA: 81981342870.05.2A6415A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 79FB180008 for ; Sun, 7 Apr 2024 03:44:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IuNkIgxJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712461453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E2L2MFNPB1r+oHibU5GVXK15/Ijoq4av1mQ1nIlGfEI=; b=d6tTw2GA9cvGbtVE+Z+xLGorLCiR65KOb5vuGP4oJ4qhuSY+MPGffgj8unh4TE8QiqK+3G 9dVIbNufEDQH6bzVazDeTw1VrCwSvYSA72+oakqtQvhOcCKKwAk2A02PBcxHXyZTY5vAns JXRhggBK7HxDre64qAHYyoH05zLtDOM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IuNkIgxJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712461453; a=rsa-sha256; cv=none; b=tY73oxP4bjsPzPLh0Ml/JwbOVm1sGGgNDVAF04MyHQhFY4d8Sr12pxjLtFNsxRaWi8d+RY lCrbyGXCy+a0s3SqI79HWLA4Twrh+o45oqTu+SD9bnzgsXV0Gg5ZtP48UsG0of7AMo1UAY CkYJtHJiD6t2A7Q8DvFNHWEwwFekfPg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E2L2MFNPB1r+oHibU5GVXK15/Ijoq4av1mQ1nIlGfEI=; b=IuNkIgxJs8dwhHeBBrLc8y1mri I+Wb6A1QVTXG6T4+jkqisxMlKYkT6eqiikIV2Y+DpisS58PjIq4gZosncxo918nspziyKB4w4K3iZ 68yoXKsVYOnZdhhkPhnJceLXxtEyyghFVAcF5cLAay12S8nUxZwDs25Atyt6dY8cXWJu6KJL0QE/O 0dpAeh+gByb5JxvyOf9lJler5CO2ZF5RJOW/+wZdlEMIocBh3N15lkILiXO32ae3ybT5ne5AbKCvb C3M6HvZQj3mud7jAbYIYnJxQkXxxlTViKYDa/9oNAck6A3QlRulYfRFIHzPR/M5MPZL37+bY2wGPX EhR5TeUw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtJRz-0000000EGsD-2Zhb; Sun, 07 Apr 2024 03:44:11 +0000 Date: Sun, 7 Apr 2024 04:44:11 +0100 From: Matthew Wilcox To: Vishal Moola Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 2/7] khugepaged: Convert alloc_charge_hpage to alloc_charge_folio Message-ID: References: <20240403171838.1445826-1-willy@infradead.org> <20240403171838.1445826-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 79FB180008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fgxkb1xcr8jja4op43cu36fsexfhukkn X-HE-Tag: 1712461453-82972 X-HE-Meta: U2FsdGVkX18m3Jj7C1BqI1Nunisf+UdREtItYFYswp0PfiJtl2ac1ZvxaJCUziGRcQ97BRRdbSuIv+h0FEGzqEotXcXO7kVcv1YZjgvvHUCQi70igXxmahj0O625xRcIN82Vp39j7hVmj0zIr43t36YZvrLa7eBL7LDY6Armm32DDWdt2ZZNpZjmE1YDXFq91djmW241UisLQXRx9rVv6YULBktPXdv3m4Bektk8URRf14r68sJRe0ShPjMjR10cjifjmx/aKpfUTrAHSz877VW07dO/nt5Ul2r32qDh7cLgusftcKD6KxmFZhvUl4pFf8sbd9a007PAhf0eTjjBEKFfYuG7B0cPTNmTfmQ/RwlKDKlFQy3MTGK6fXM+enBvuUi372dZNu68q+VbF8k1tzNOYI3cg+9jkB5UBHet3khvp1EsqnF+i/SeyqK1rH4r0AulXC7bd6zxBZ9JUWBSvbivdbxCgFwElzhGUcapPmQTAiSDavp/xInYEz1e0mTt0a9jn2WhKstf11LxPK7w2+e20FpXY6JXESU655g7I/74rDXTLB2mNBDydUTGZ/j7Od5I7iJ5/ZLOmURC/29OII40dsVLdJDDnGM25iYvepcrcESBek0BhcXJ4fqU1CxOl4UExte+FxRN4aZPFk2lZ33uiwX+tOlcib3Pk0e2H8nF3ZGwgai/0ZXvYZjQP9H9982r+juh1pgqslWiPWCqfACUs1C5pAYgyoX1JzsE/WJfWeEnLS/ysJvhkdcHYcecoQXmrowDSvw2CA0ZI19tLAL14SrGhotYnRrG67qXh+gwfwjE9OcPGQmtmS7vF5IAr3a0o8Bd0P0DDL9mo3FYZCi1RRllfcnlUItAOTuSzTfHR+rATjaE49UPUgx8aOOnhUdP5raxOlqeW/v5CvxmDHoLrSuyz/Iv2dq1DWFWigAoZxaFFFjjjjXbRgMneExnmqvtIH4thkhwlgmHe/t 6WPWV/PM QhKeZgzt7wUTCFtJOueHk7RBQ1L6P7Hsr9yUsZ3Pc7vjfuv/VuxRXdrtUCnMw6x0buQqQmv8S8JJqGJo3oedK40lZdQ0qPRVdmKSuiARtRcD0BmxTLptbXGE0WNRx+NNJ7NcoBqEB//vMjgjss2qTCg0Qk4q0UdXTDLWLKxRQxRZpBkKYrM+T2AX2YrWH+kvGBKr9FP4AF8sS3yNUCPBZwrj3tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 02:14:10PM -0700, Vishal Moola wrote: > On Wed, Apr 03, 2024 at 06:18:31PM +0100, Matthew Wilcox (Oracle) wrote: > > @@ -1789,7 +1789,7 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, > > struct page *hpage; > > struct page *page; > > struct page *tmp; > > - struct folio *folio; > > + struct folio *folio, *new_folio; > > Would it make more sense to introduce new_folio in patch 5 where > you convert the rest of the function to use new_folio? I think it > might make the commit history easier to read. I went back and forth on that a few times. I ended up deciding that it didn't really help.