From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CBACD1292 for ; Sat, 6 Apr 2024 03:17:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 501956B0082; Fri, 5 Apr 2024 23:17:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1766B0083; Fri, 5 Apr 2024 23:17:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 378E16B0085; Fri, 5 Apr 2024 23:17:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B38A6B0082 for ; Fri, 5 Apr 2024 23:17:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4DFD81612AB for ; Sat, 6 Apr 2024 03:17:18 +0000 (UTC) X-FDA: 81977646156.19.B41F5EB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 1C27440005 for ; Sat, 6 Apr 2024 03:17:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zi+vyXrZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lE5wQbyp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="oXq0I/qM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YD+dZhTE; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712373436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EpgaMd6orF9J6xhkgaKt5jg3h/PGv12uwnvhyGZ7p8k=; b=51CpG+PvK33i1eWanLp+tMEoD2nHUHYDol+aF8o6Qf8EmDwpix7Iv9K8m+xjRJx/8ZlZzM 4GIh+RHRhK14I348bOuC1hpEWYn3UmUZgt/mUgkbQ7SoVEGZUpBev5acLGswo/5VgiHee/ A7hRRLY5H7x/HM/an72MRruQXBQD3F0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Zi+vyXrZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lE5wQbyp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="oXq0I/qM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YD+dZhTE; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712373436; a=rsa-sha256; cv=none; b=wE0ekzORuqPistB2czCGc9sDSDqY+e+CfhIr4aKp9z2yXXRKKoKUAQGYej0df8k+4Ra7oG KizLA96pU87zemRlxILvjocYuvI3pIalYQua4YO/HLc13NQ00AiJQ7HUQ+vIUrvPYRbNOp mgHk60W/Qf0hCyanlejDkJgYXvp0eWU= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 26DF921AE4; Sat, 6 Apr 2024 03:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712373434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpgaMd6orF9J6xhkgaKt5jg3h/PGv12uwnvhyGZ7p8k=; b=Zi+vyXrZcKUXPhYLhs6NjjEupufetEio2z0rovOHayByuScK/V6XPjhMJabwxwVCq/N9+i 7iWN8eIbY8P1i3PieEKgsC/bk07FTVaH1ikjrg3w8gAgKOVaPEGvJv9X/GM0MaGJi4KAKP RAj8xxWohmrQ3ViCPZGFJZYrCJ3VlFY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712373434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpgaMd6orF9J6xhkgaKt5jg3h/PGv12uwnvhyGZ7p8k=; b=lE5wQbypc1iCrLupM+R2njzT050wduDUqdAXzgHlVwLp32j1B7Ar6wP7jPSEFbUp8z2SQZ BqI/QvZC2KfZf4Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712373433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpgaMd6orF9J6xhkgaKt5jg3h/PGv12uwnvhyGZ7p8k=; b=oXq0I/qM9vxyE71iza/9g0JDrWrFkMeIzsNsNGZpQy+Y6CAr/RyrK0JanUB1ldtm0CX4PF n0SlKdSHKsikxd0X/XWcd7VSr8zM/IG3YSGPgJz40CfIJe/G2QR2a+j70OOdbkTWw0m63Z NGkrREBuPVkxukPkgR22mSEQLmT0LXg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712373433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpgaMd6orF9J6xhkgaKt5jg3h/PGv12uwnvhyGZ7p8k=; b=YD+dZhTEof8CpPGLOcYKHTsURDB2mCklfBTLrnUCXaElr1QR33gAbJBVC0hIBGMBOP/tZR On30oixO6qWC/sBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 43880139E8; Sat, 6 Apr 2024 03:17:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id 9dQfNLe+EGaxHAAAn2gu4w (envelope-from ); Sat, 06 Apr 2024 03:17:11 +0000 Date: Sat, 6 Apr 2024 04:18:41 +0200 From: Oscar Salvador To: Tony Luck Cc: David Hildenbrand , Borislav Petkov , Yazen Ghannam , Miaohe Lin , Naoya Horiguchi , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: Machine check recovery broken in v6.9-rc1 Message-ID: References: <1e943439-6044-4aa4-8c41-747e9e4dca27@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1C27440005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yc8heyqtgdbwdb7mt9f3qnourcnrdrje X-HE-Tag: 1712373435-136604 X-HE-Meta: U2FsdGVkX1+Pcj1X/10kT5X3zlHyWuusYvJmye/DBIDtffhLaQ1Vum6XXSgTKdMVmKI40jTc/AnvGm7eCGT+bb2XL7gDH3y2uFYb0COYkjLNAdK7nPsqVCWZ71OSn43PPCZQZijyN5OYfIAcJCUcqmELoEl0M4uHFVOCXn739anMfUo3mnEHucAi7CDG3OIAI91snD3gvFv/ngbXFXJY6RE3InzaLcWA75N9v8tdlM07uhr0MhBING+FBaK8NiXwEjPOPjLbQR7UhRcwuvDSmrcIsHfA4GhQ1M79cHIQiJrNlKsGHOg7Nu6U84sE/fUFulDUevLxLlmO9JRLMp3X8rKhFjRPWcUtf6rUSVURro3j6xa2dB1Ikf8yHpT000pYiYZrWDqdl3IbWHvukSwoj9asHJQFsFNWK5S8gHb9WPkzqgG9QMgh+4oKR+Z5pOajHVRt3MYq6PwZ/JayfOMmS+4sfISpo+vic8TtgH0myYIRpp+/QDEr1LOB5Xi97ySxHwaIzKR7fqzywMEJISp3uB5OfsUJgAaD7WFuDUCXQlK4saPrbgup58L2OI+nn/JDjQqLVVCLerqt/iBQv4WsqfqWCO2t5D1dUkkXnPaSlstYDHduYDd13ch8wPgXk1ckFsFkybKZIcEhZDBytOR0/Gm2vN6yIAyE6KS0Fy/QWXXHzP/zsYLX/sP5zJewHFomTZO/Bxb18FMOFw7lxXuGCfBj7gr1Utq07pywNiXxgvpzmO1wbl4t1SX4mkhjd0HT1MjTZ2IyfXFXO1ciONcUgxmaSVhOzBnfj8RMoqT6Lfm+KTuoaxyaOMkB2q3vFGqa6inVkdV1HI8Fi4X8w5uktc3Qic4519QFnk9wHNr6SCEiQC8xCR+O5+8yi8jgtkXZLQAX/MG3IrTrzSJDlqPNH9jvY6AVt6m5/eH1tQ+GWDMcPsosOdtnLi/Txp+J2UgI9G9heLjbi2+qmHKeLnc ZV0eaCuA eNzsJtYtPzo3dT/N5Y3+hG1CdXHBTzzV174yDeZ0d0Owk/5QuhfMgmPFVe5s+CJMitsKh4qgwEGZYhOtHabuEyRL+aui+XIZM9RFEVzwJlnkvexV0f98HKZ2BfaWUkCBp+C2tZxJ018hrDWJ/zds3emGexIl+fJrxkd5t11FCsxHoJuLw5SoVA2fHKszTsIOHBhS9iJO2qY48Wu6YnUA3762n0M1gVbIhOjxWFw0ypYAAnapaXIUn2gKFrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 05, 2024 at 04:58:55PM -0700, Tony Luck wrote: > So a problem (not necessarily the current upstream problem given the > amount of additional changes that happened) began way back in this > commit from v6.1: > > 0d206b5d2e0d ("mm/swap: add swp_offset_pfn() to fetch PFN from swap entry") > > This commit gives the "kernel BUG at include/linux/swapops.h:88!" while > its predecessor runs without errors). Tony, could you try the following patch, to see if that goes away? It is against 6.1, but current kernel has the same problem AFAICS. diff --git a/include/linux/swapops.h b/include/linux/swapops.h index 578212fbf2be..575d428393c0 100644 --- a/include/linux/swapops.h +++ b/include/linux/swapops.h @@ -416,7 +416,7 @@ static inline bool is_pfn_swap_entry(swp_entry_t entry) BUILD_BUG_ON(SWP_TYPE_SHIFT < SWP_PFN_BITS); return is_migration_entry(entry) || is_device_private_entry(entry) || - is_device_exclusive_entry(entry); + is_device_exclusive_entry(entry) || is_hwpsoion_entry(entry); } struct page_vma_mapped_walk; Thanks -- Oscar Salvador SUSE Labs