From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC5CCD1296 for ; Fri, 5 Apr 2024 21:19:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F47C6B0098; Fri, 5 Apr 2024 17:19:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A4D36B0099; Fri, 5 Apr 2024 17:19:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 244C86B009A; Fri, 5 Apr 2024 17:19:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 04F506B0098 for ; Fri, 5 Apr 2024 17:19:24 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B140240113 for ; Fri, 5 Apr 2024 21:19:24 +0000 (UTC) X-FDA: 81976744248.10.8D5420A Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf17.hostedemail.com (Postfix) with ESMTP id D63E040010 for ; Fri, 5 Apr 2024 21:19:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j9caCtPS; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712351962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IozL/g/yYORRVzmeJaHfKv7O0C+fJ90EyEOnn8ADGc=; b=spPXfIzjtQ8m/aKhBCRlJrhQ9Pf7xqPDc1u8KPCjLsTTxS2Y83Qh0+g8K3X8UXO2baO20q iKkow/H2MQm+/DKB8loTWfLeD5AwJYC9SMZ/leJZ4yU3ugxVjYqCsgQN3MIXJRKqMhuSwq gKmje5hkUDmsgED7uU+eAPjbRc6OwzM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712351962; a=rsa-sha256; cv=none; b=tys5WDwT40U1/5KF9xn6D+YFtAdIsJamrjnzYQ4ABccqJ6ezreqqWBbAC1wEjxhJiWO3gO o3RZLSy7Yl1Wf1o69Lq3NNt6yfI66VH7W2WpEr/5IUpXChYa2aAQgVoYeW4ZAMuf2ErdLp 5IALtWrPIcHrkqIDTaP/CDNOTd6z48g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j9caCtPS; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-61587aa9f4cso25696627b3.3 for ; Fri, 05 Apr 2024 14:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712351962; x=1712956762; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+IozL/g/yYORRVzmeJaHfKv7O0C+fJ90EyEOnn8ADGc=; b=j9caCtPSJcZkRZJDHEGtp0u0enWKaFJklx2Bprel5JVnq9y8BubZjP6LeHaJCWLL4c pNBuEYEa7ptCJgt6vLmFGMEZVQVtAFLI3mvGTd3tx2gp6fh6h82MGp6EwBJGO7JgsS+s GERV1yZgFgIRx3YvoNio32ydbsd8d9DoqyhbIKuucoLMbSr4Ed/9lWJe1naoNIdsZ/i2 tQ7SDrPtJjXEPT5RtBGYEj2Pm90MRERCsSdeg+6V/9AJjPd/KKDa+JE/1dQQJ1s36kkv kgbhvREdUDFy/mmC2GHWy5BQY/+KOmjZXUjDCmGIZitmREe9EDevJzfsbimwFWF0uurd LZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712351962; x=1712956762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+IozL/g/yYORRVzmeJaHfKv7O0C+fJ90EyEOnn8ADGc=; b=pxbzItR/YNX0y0CzTzkP8U4aKLd7oC33BERhj8+chPCiwZRC0T02CKgueV3dq9Uouy xubP5LzQ6bxCPNcVQkV1dpQZwnIXhsUI2HpI4ajikHyMe31y64HVovTccGA3kM8pg4dJ zVBavw0VC0ZzTcxmuD9wTR8B1aduje/FisVxjJe/4qlFw815JzE93ZxxxT+bsRXeLvQj Qfw89XZ0AobZVZhOvCw3knnnduYU6dyz6NinGDbQz6oLomnCOgt9TJQITKtXYu6zeuab LoERDuxhakJc49l+omhjEKYXAzvlHVm3b8muXZhzOPf6CMsMqW3Fv0zskN3xl3Qq4htX GFBg== X-Forwarded-Encrypted: i=1; AJvYcCW2cpK/4OiZcyza41yROg5tlCf9N7mZPweHITWKvc1ESfoC5g272i2TcWfvVwpmYsJxbcRrDzbBjwT89ArWq4kGnAY= X-Gm-Message-State: AOJu0Yyx0SyoyVy08CE6AgXQM6eUZYQeAm0yRExSeECp+s/weAYk18G0 uuQ0tZ0S9JuE2tKjZRfIwztEpt5axRjidcEoVEOPk+NIEgvMq8oQ7MvE9mb0 X-Google-Smtp-Source: AGHT+IG0Y0PMR+mftBB5JwsUSLMHqkRBzNRO52Xcfn6ziuWMRGvdQRdycK5sokLrk+U5qn3bC9BMKQ== X-Received: by 2002:a81:83c1:0:b0:611:3105:93e5 with SMTP id t184-20020a8183c1000000b00611310593e5mr2771967ywf.17.1712351961922; Fri, 05 Apr 2024 14:19:21 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::40]) by smtp.gmail.com with ESMTPSA id w133-20020a81498b000000b006167f45edf9sm539857ywa.89.2024.04.05.14.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 14:19:21 -0700 (PDT) Date: Fri, 5 Apr 2024 14:19:19 -0700 From: Vishal Moola To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 4/7] khugepaged: Pass a folio to __collapse_huge_page_copy() Message-ID: References: <20240403171838.1445826-1-willy@infradead.org> <20240403171838.1445826-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403171838.1445826-5-willy@infradead.org> X-Rspamd-Queue-Id: D63E040010 X-Rspam-User: X-Stat-Signature: niicdxenuzhqaisjjmbbxnhdqwy7t6uf X-Rspamd-Server: rspam03 X-HE-Tag: 1712351962-938730 X-HE-Meta: U2FsdGVkX18Q7fyMLnyaMMd8lnMNrvCJUVWORPLzF2QKp7C5V8wvBHFH/ilyh+ZTSMymCGeSLgGr+Du7Z/g1lRVSYOEGiXuRQkHwffYf3IRCi11YQIc8CtuoGUfqVaswIQqSrjlcZq2le88kV2uuhMbfwj7CEQ7VasD38O70bqCoq4IstQxy/DVKaNrFikzyN+Lpk3kKt/cfu+ifTzDxWKcqaVIg7wsU4e0qHHV536l/DH4IBoe2T3bR+b129TM4ZA73JzH036fREVp2tSdgvac4X9dsB8UFgdTFynPA7rZQ9FzAXNWUy8BXt30WyL9/8dfNRFYqEZwgDrYeGJouXFv4REFuOm2UIJUs4EKhrV8cQ08XsSboXljfc48YJJPpKe5MC7Z8bhVa9geoYNcqVZLPUvvgCzV2kM2HbbKg6Z+dzI5Ly17M64mW9C5DWBJUJaYL9JCHEicUwmvP6d24BBBbWJdoEyuTbyzezbq0qlVppw86efop/5amTp79qiO5exFZdMETxu2bf1ZRwEx547LdW1YTOwvQoqSaYFvbA0dFvm3+U1vgr6SK5zAjSsyK89Z3ZtiSWXa0MgrNpCnI8oIlN/O0M9dTy5Ov/miFltGS0AAl/Fj7PNW6t3FxNFQ40SqWdTUCWAys/Mt1Tp4U+aC4+2kFrzCumB0xGxlL8pFaz4FOyynIUNumUy9DGR9WjRzTd3PvgUKOQiNjRdy9esv5dWpO8c3PphzL2cRO1b8/dUSx8SPR69X8KQ5x/hkKjmqZeeOGhRToTg2Bl6h8clG4VKSpAVFXGZ+n/2XuWX5m6rxfnR+SEdB4xdOqe8fR76Ax+4VaLJyhMwX2+mC/276hcg0zY2h3oht5qzG4O4shhrN9Ys39ytecwawp/Da10uG8LOrotGBgdPWHQh9lFthxJYRcOtaFW8QAbFZDyuWSKLy1wm4105ivhc2bxsK1X5AVvZxChY9J/NzRRWB Zuee+WL+ mNOkvKc52DJDuHtHtS9YgPMCnMcgwhee/5lNV6yNSXTMVUDrirU3A+jAcAlFtmpDdhTCRL9elBhc86woRZxzz4mjK/oOAUK0JB79zh08lvg2B5Y8XkxqngrHPmf1Nm0Z/jgWEaPZqFPIpG8V7GIvUP0uo4zeNOedxT5DoOvWWODrn7BLWG+EtFj10/BHUHNM1917QUD4x65eVTIxJd2BRwl/ERl0H87L+8HXAy1u36PyDk5bnr57PRMQx3HZhr8EE6FnQOQVuE/JlTVlMz+eZWeGT599EVQ3r869XnYdHcGNxoUzfRhn6vjkRKxsd8Hy6/P+mM3I5HgUddTwcVC3BrrTg9ATj5TNvLYZt/4YJIACSsfA9oViASTHS/wcM8uhjudCIdOCTc6GE89tfB5g7UAwaTxn/kNjrj2pWFOZYxVG87x3IGA59rEyxoVo7vAn/oalcV8SKdqkSNj5tLU2wo2GFCkn4CXgB4bObG4dmy3jsx+Oc/3H7EVfR3xw9mK+YDt2a5MddzD9386uxTwT9ZEJNoIU0PF8rt9d+fbpoeHS4IFz1681H63PLXy7Bf3ODUkZKjyc6wed28izCUQlM4WS5ZIOBElSyA+LoH7KlGUgWbHWB3zbb0x8fwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 06:18:33PM +0100, Matthew Wilcox (Oracle) wrote: > Simplify the body of __collapse_huge_page_copy() while I'm looking at > it. > > Signed-off-by: Matthew Wilcox (Oracle) This makes things so much easier to read! Reviewed-by: Vishal Moola (Oracle) > } > @@ -1196,7 +1192,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > */ > anon_vma_unlock_write(vma->anon_vma); > > - result = __collapse_huge_page_copy(pte, &folio->page, pmd, _pmd, > + result = __collapse_huge_page_copy(pte, folio, pmd, _pmd, > vma, address, pte_ptl, > &compound_pagelist); Additionally, it looks like if you put this after patch 2 and before 3, you could avoid modifying this line twice.