From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0965CD1296 for ; Fri, 5 Apr 2024 21:14:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D95C6B0087; Fri, 5 Apr 2024 17:14:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48A0E6B0088; Fri, 5 Apr 2024 17:14:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32AD06B0093; Fri, 5 Apr 2024 17:14:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 111E56B0087 for ; Fri, 5 Apr 2024 17:14:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C91C1141045 for ; Fri, 5 Apr 2024 21:14:15 +0000 (UTC) X-FDA: 81976731270.05.476DE0C Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 02A518000F for ; Fri, 5 Apr 2024 21:14:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hYlKtGyk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712351654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+nK0IACJzkqOGtfWObekoYbFQAOktwf86ojkGdYVfcw=; b=PzrWWbsKEjP4fw7CgRQLoXcGG6mUWDB32ORSHDMvSUgfkOHLDaOqOQX+smIvNyuwAQV0Zu JCZ8nG/3LORYQYssc0bfR4EdRucea5nx2o1Q5gw8hIyItzaZchbtio99ESP1e+q2ZjqLjH 6z0ht+SnaaRNnCdfXwHubq8SIkEf0Sk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hYlKtGyk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712351654; a=rsa-sha256; cv=none; b=l26aoMGH5y0aTwTIppZw3bWRvIKAN3mv124TnskJ4uS7x5kV5r3neQcs0dhgdifipe7uqY tKf3wIyCBTjPSzjmVwiBHGmEHDbKwkzz1hCH++jOvNrXi9Tfs2F/O3hHsy2ok7jn8zCbph 5S7Nu8CJIxiTizQz08oZ3761HSF1Pv8= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6164d7a02d2so26346167b3.3 for ; Fri, 05 Apr 2024 14:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712351653; x=1712956453; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+nK0IACJzkqOGtfWObekoYbFQAOktwf86ojkGdYVfcw=; b=hYlKtGykc7N/d/SqdxbW29SlVqM7wQ34ZvU/rJENGFsfVc2QAn4nzXy2xNPbr3a3Xq V2WJs1GUPlapL1l83wAQmDOlQ11peWa5lrpDKY0Av6CKvBXAA1WtTBXBGWTVXeZiaSmx 2b/sxgLRGvpeY/AG8taLTBT0k+8iZNcJqdAiX2Al/ZirXqaxha2D+0bvwmJsC45tsFxM Yuc/h/PlxBV+hodwtk+tFbtrFMCoEeLlgKU70fWWzoPmcgx4krgaUaD92gSfhKi1D6Rc wnkVqc7bPa6QqIsGdeRZT6IoBblaJH7B1PIpNBYfULmesW3MzECPb8qXd7NAHV51hWHA rJSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712351653; x=1712956453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+nK0IACJzkqOGtfWObekoYbFQAOktwf86ojkGdYVfcw=; b=dyb5TzuH/XB9URktimQ+zIwyF9S/LdgWOImbtmxX8FkSoVoDs9eGTXaENLAaGjdFFC K/T99UN0AfGQU1NSE3OhZUw1GTljMzlb8obqppvt1skZCypOpF5bmIZ1oNKTOevuoC8W hYZ6ivelHT5echTJ10pAia5uj7MpvRpgGmX0k5KbXIQ4glS+ViRm02Bwbjuxw2aFn5QL iSfOce4aU9vyWK1c7KUa1/FSdICm19Bpz0iOD/yMiWTCXHEgVz8M3bgdSCm9LCSf/UAp hHfbL7Oyybf0QpYixrfE/Fnaf8Ab8TG3FHfWWPSAL598oPcdodq7x59BuByiO63qCNuF gOlA== X-Forwarded-Encrypted: i=1; AJvYcCXEkOsqwSeH06lAHcBnjIUF/vSaO/CSP7yaQS2LAB9dLLGf46ULItcKmagz0X2jNYZ3Z8EbyzAN+e0QJZzQb++L2Bk= X-Gm-Message-State: AOJu0YwbmCrhMnjX3J8Q8oB57k7yGgMbTvIVg7QmeqhsIm6J3bf9rYL+ xrLHx10UmA2s/ZSE9ddaQC5Rh1Il5mF+yH54SMUm7/+mELc6menc X-Google-Smtp-Source: AGHT+IHXO/bTSPmfJIU5eSxd6Ye1Gw8Id+S4UXhxHCZJVcjmkYcBzSxGOXWUc9PzQmBNt1ZDNmYoqw== X-Received: by 2002:a0d:eac7:0:b0:611:200c:9229 with SMTP id t190-20020a0deac7000000b00611200c9229mr2901005ywe.8.1712351653079; Fri, 05 Apr 2024 14:14:13 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::40]) by smtp.gmail.com with ESMTPSA id g123-20020a815281000000b00610f11954b1sm529799ywb.67.2024.04.05.14.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 14:14:12 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:10 -0700 From: Vishal Moola To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 2/7] khugepaged: Convert alloc_charge_hpage to alloc_charge_folio Message-ID: References: <20240403171838.1445826-1-willy@infradead.org> <20240403171838.1445826-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403171838.1445826-3-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 02A518000F X-Stat-Signature: 94xiioz4chp8kaickg1f3t73q7r1zx7n X-HE-Tag: 1712351653-549 X-HE-Meta: U2FsdGVkX1/zhwWqK8GLrr53FX8Bv5Ne+cDYI51lbrmA7i8KIGuHWiZ+VOpxbZAnpobuhKmcDxq91QUz16yh8w8OWnmRWqXAiYW58iQpc7nEnf225SUoCLHHGUGyEC/XuSeMmy+Pqsz6s039XbOskdaIcN2CkOB+BG1H8PeWvoo3uCovAvzAOSiOzBeBHw80UIxHLaVwgFz3y/qEnL7QY1JTl3/6lxNuygLbuEWtPfosPDd5ut/QNjUsPPvpjdDtYtYon/6EcES7+G+eJrkBhLz0PRQtYWhpHL50hKU2+YQM1T2i8B+jOAkkFLZ55JvK45iyEjpisuuPFDx7bpDT1Al3/drA6yuHVbTwczwFqL7CsObPmSZCxcmY006Kv1mOMK7nYXLH/wElq155MKyHv+4pZsGcrGWjInGNl5sO9p62b1uLTMMNTUFYvuD2/EqbH5ZnrsK5DdE1oUIRP8XSUly/6JsCR/glPN9dALrGLtJbmREa5cYq7BBgumAKyWBOEGe7kMfioWrXiy5KCz66qh4jHEeS+OA7qgUOUPlnB/NduH2WTvQUdhigOhZ8RGkP/HHLmPu6lk0Wp2+bndH4hNRk/qqkwAxjXhMc6OREWPBGLnRCJPcXF0NeL3fvhlFD8RL2pykfCxoQcsXIqELddGKKyQ23rRMHaBQRorLTkooFw5c+OlzvSSlnji3tOzRpCfoaL4b0fpBRpUMJzkvmqKWf/LhhS1B+HaK9M+hGPoE+J29JZhO8X9up2k2wbXvhAsHpFEUYj+raR9Q+VmGqV8dGwIaVzqEuxBincOYswHFiKGwJv58hc+hLAGrlZHyQHRDrtmAsT7S6k8bODwcXsQ4FNiwjgYvEjovGAS3HYuidurPG02KyaQRVCDBlM++tWcyx7mxmOMAsW5+Idxftr4duuPYuPwJPFclogZftoVnQtQ2r+JPDqCmWqqtIju3kI8gi4Di7koXj98kPyAi L97I/Qxo Ag5wWdu9bgSwTGuRNURnFjW1ZgsfciDmvdyxFvFR8vMgL2XpH167EF6Bpv7EGoh4i1fDboscIOYHNxvLssptOWyAAjR5UqJbwnGIuwaYe4TmLMWivu8MyXot9XUD/dP/9tgeR+BX7RM/M6fkVWvSru5jCbl3MqsnjHUnv7ocQfWTUuA5k2OkE02aqhVEiwJSqSQw7BfLvFfPqmEW7Y/lmxv2gEaYD57sLVZxs4Af+tGV+MYw055Iotq8pLlJSBLr5ZhBY+3+zLhAFPrwohgoEv25ZB7Ne4HkdlAvYJjIs6/tzAcpYDodXXd0MP/eoT194VuWbkDvn49X68Lyg+l1fiusO9Z+96SLPWLcrlL+LgqghfNUxp0KuD1UbogLjeWlw2zSeXuglUVD3ohOAZClYkP1KCWgBaPEeywduvFBPb4JHlY/wsVxKujj2lJNGJfAgJZMVNd3FOaFHxlxFVtyOBSiBcVOF63qJ+6JfcoqrqnmTbUGQVrNsFtsI1z36vyY00xWamTbJpWBerlK0Fhfan+sDA7R0pm3Q8izqqpq+DGks5fwVFuMyFDYp7UFU1cDARnrq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 06:18:31PM +0100, Matthew Wilcox (Oracle) wrote: > @@ -1789,7 +1789,7 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, > struct page *hpage; > struct page *page; > struct page *tmp; > - struct folio *folio; > + struct folio *folio, *new_folio; Would it make more sense to introduce new_folio in patch 5 where you convert the rest of the function to use new_folio? I think it might make the commit history easier to read.