From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99973C4345F for ; Wed, 17 Apr 2024 05:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3B06B0087; Wed, 17 Apr 2024 01:55:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 183EC6B0088; Wed, 17 Apr 2024 01:55:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0727B6B0089; Wed, 17 Apr 2024 01:55:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DF0576B0087 for ; Wed, 17 Apr 2024 01:55:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4509DA0A97 for ; Wed, 17 Apr 2024 05:55:56 +0000 (UTC) X-FDA: 82017962712.05.2034D33 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id D96F4A0003 for ; Wed, 17 Apr 2024 05:55:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bPH4Drlv; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713333354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7EZuFPBwc/TVSBVQ+KC4hiBUgyr0u3XfMl0r7Cshbw=; b=bleHyOWV1OYYQ5mAy3EzOzjx2FzQ1zMXn6McFIzJqX567748FW40AtIw88uwdkMlMuFtC2 2cZ970yVKYEezLatX3HT+1PkRljGhWO99a53/uMtiwOXTWxigP28G+MqxnP9vbX5gurXVH 2EZtI8nXqrzIGlLXOYbigdeQzNJM9B8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bPH4Drlv; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713333354; a=rsa-sha256; cv=none; b=qMsedOaO6nG55nWkC9OhKKycVm4lcUp8gDGWHn8DGAiE515nI7834cFtI8cY5Yv3Uqyc9r piQlnWANsoavx3DBK7PWbIrSN9Hmdbrjw+DhKMlme+x7f1WqRoqdzX1kNGfrZGpFLzhfNK NVgy6uUo9gsxzdzLRPrsXOc+yPzw7fs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 14AD761268; Wed, 17 Apr 2024 05:55:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AED07C072AA; Wed, 17 Apr 2024 05:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713333353; bh=O9FmMFUzDkQ7nDs/vZHy+9Q1QnSIFEtJv05CC2EKQho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bPH4DrlvslPNp+oELqW1c6KOj4BdlN908yjOXXy3O2woVIYezrjAdETI+jSlN7zbI 9AhsYYBEWWEZsNp8/YDr6UbjkDpPuDgOkq0pcXlgTtxcZmToWLt9fObgazLXt86arS B93gTUirCfd5lHLYVMcziUzaIcr6KX5yz+YBVB0wRk0obVw2VOd6ZaMh5e8z12i2Jr RaaqN1vS0VOm4rHMD+oVvZtOUWCsRB4OqExrgg01aOjUXHYHTkj3d/5s8gbpmwzTfK 1iO3uDagRMgIXRvu3ba2grpPM5Z58rCFjFVYRH3j+VwgT+WwzJGkVy6m22N1wGjtzf 4N2vdLu1l+ySg== Date: Wed, 17 Apr 2024 08:54:43 +0300 From: Mike Rapoport To: Wei Yang Cc: skseofh@gmail.com, robh@kernel.org, saravanak@google.com, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH] memblock: add no-map alloc functions Message-ID: References: <20240415142448.333271-1-skseofh@gmail.com> <20240417023147.ybefdy6fn5drvq5w@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417023147.ybefdy6fn5drvq5w@master> X-Stat-Signature: k1tjosc5azscwju8akph9m4oq5ac3bk6 X-Rspamd-Queue-Id: D96F4A0003 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713333354-932658 X-HE-Meta: U2FsdGVkX1/sfVf9tB1dcPSD+c4r1SRSMmtW/Zhv4y8PzXW1Ours3R/9LwM4yfgBI8qmLAa3ZE/UnGQbpcGKlzzJhhuLTRmK7Hn8zxad3NWrPYF4lA5DV1ogvZ1b0wWxKHZTqUfZ0QBSnAyBL5ZDlNAWLqzB148S/2sIFEW4CWrjxMeebRLFbJgo+83gUaf3hQF5rl9WhkClcsZYfO6VWMnKW/ATfHlEn44+Hn+pvInsvSFx2DtYIjItw7ld1cIerAbV0uTQFVVmlkgKfhb0CoLAE9c7Nlf7MhrfUFNTUDomDhBIXSQBsRF4KfeDyNkW7cdlIlt59vlmPCOobYGVgELhuQaxIuoTcD/EsBW3ba5QZQ2/6zdtU3N3VwmG2XuzhO9JabItIS6MUflREehVHE8vuWHVFzBQk1LRB/wnrAFBdepRgw4x5yhH8CBnqrUuxKOdpyCYUms1Dyc3qDa/Qs8a6jS7//PfK8sMiXoLs7xHvCF0vER2AjWVHnp/u77erjxBUkecNh6Q9zpwafGBw14e/SQh4QzFjejerimwZSfM9UMFuHuiv31MQE003PXwvwHT9ckQB4giie9YW7dPfLLdeVRcqhrNQ1VM/03l7cmAyosPbbD9zGtSX6ESSlBJ7ekPqNZhzIvKjnnZbWLV8Jah1UOkHrj70dbLcPAFqjicXXwLONZcFT/hcFosuQqbsVE3zvJ/8T+x+3F8nZJZ1iuGJPqAsE99AfsWDLqoTTWkWibSFoS4DKNGY163Vo+GMKeFc6ktixen97IgCVi5iMaOvq8YcSTsQbzjf0q0GBajUeTdYBcExK+xafrbCMGWU3VgYLGeUPsM+6g6e5WmnyzqXH8tHYRoBoihX6lZ+vO9zbpIOtrRUixZ6BgQ7UHzyUPzQjDoC4HXFk0enYImCp10a5m5Ky+lzxNOi+Jv09U6DZDqxLUPHBJY3rlUTR76OAgipUyKSNvS+X0KoZs 2UQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 02:31:47AM +0000, Wei Yang wrote: > On Mon, Apr 15, 2024 at 06:26:55PM +0300, Mike Rapoport wrote: > [...] > >> + > > > >This changes behaviour of internal function, what effect will it have on > >the users? > > > >> if (!base) > >> return -ENOMEM; > >> > >> *res_base = base; > >> if (nomap) { > >> err = memblock_mark_nomap(base, size); > > Mike > > One question may not directly relevant to this thread. > > NOMAP doesn't apply to all arch? I took a look into the direct mapping > function on x86, memory_map_top_down(). It seems iterate all available pfn > instead of skipping NOMAP range. Right, x86 does not use NOMAP. NOMAP was introduced to ensure that device/firmware memory on arm64 does not have an alias mapping in the direct map because MMU does not allow alias mapping with different caching modes. > >> - if (err) > >> - memblock_phys_free(base, size); > >> } > >> > >> kmemleak_ignore_phys(base); > > > >-- > >Sincerely yours, > >Mike. > > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.