From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5091FC4345F for ; Tue, 16 Apr 2024 20:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DC226B007B; Tue, 16 Apr 2024 16:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C606B0083; Tue, 16 Apr 2024 16:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67B7C6B0089; Tue, 16 Apr 2024 16:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4DB766B007B for ; Tue, 16 Apr 2024 16:54:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0ADFC0C5F for ; Tue, 16 Apr 2024 20:54:37 +0000 (UTC) X-FDA: 82016598594.16.68DA8F9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 8781516000B for ; Tue, 16 Apr 2024 20:54:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MeZrTq7d; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713300876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CvfKII9Ey67SD+8qh7yMsDVcRpvNqlMhWe2P/D6dDSQ=; b=eESEwt4+j647dgkkxskKgKBXTBbK2TkQRlpIJyA0tGmcjrF3CXvC35R8Yz1tQpw7MWQMjW CYIs473oSChs4e1VSFU0LpKtbTqUljjCVV3fYMwMo+mmoF9UG1yL4ZW4omwxDcgR6jvMys 3B+DJYMGc1PsTCtRq/Vfv0zTxaTmUsA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713300876; a=rsa-sha256; cv=none; b=Xm+YrgjIEifNRD2lSVnwnzr9mc5t6ZvsLwjRHWKpvNbXybkcIHB3KGAofexokPM/1pqUcj qTvOV1Gza/G2eW1h79CXt85+6AkVyXtfIphAvvFhqgcWI2hPu6iqMqVVldvRpe5FIdsFyr 97/P2K1hQXW9xWkhPAEuay9Ah6y7Vmw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MeZrTq7d; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CvfKII9Ey67SD+8qh7yMsDVcRpvNqlMhWe2P/D6dDSQ=; b=MeZrTq7dInM0fW1d4LyApMradW diRVdeeO0287HG7lWB08jMShf06reiRYo6cQXffE+rHrAMCkn52vV9rcs/rMSoiBdQr/Ek+ws/3Kj nUuOPSxy3MBHZjJQgaT+4uqXcXiuVpVymhp9M7I4sCcOk789C3LKz02aK8WBtuxZOVCkCE+5eSeMa z31e0OtWV0T8rXKhEqznvlezTzD0YWbfI21SDNJ4E08jsIzRslNWZ/0mcn5w+7lvsSuGAIYy9PsWL 9YSb0glxtmA4yR/KzKYB4I//Tkz0NkzU3fv/gQOj0TSg8Qe7NTWTLhjSappGg9728TN0X/lNjDGOm WowEWrJw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwpmk-00000001OPN-2QDc; Tue, 16 Apr 2024 20:52:10 +0000 Date: Tue, 16 Apr 2024 21:52:10 +0100 From: Matthew Wilcox To: Sourav Panda Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, weixugc@google.com Subject: Re: [PATCH v10] mm: report per-page metadata information Message-ID: References: <20240416201335.3551099-1-souravpanda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416201335.3551099-1-souravpanda@google.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8781516000B X-Stat-Signature: pi6yhyqca4tj6tjbb6w8gtqbt61d8hp5 X-Rspam-User: X-HE-Tag: 1713300875-763657 X-HE-Meta: U2FsdGVkX1/ds6UAP5w4DE4OdAdcW9J/pUWAH8KB6C7Mc8beMPnWw60DpWCWXSYhDTORyNbbQD7u6I2Df67oId5Kr/mXDBeBIEiQzqtMPgxqPSOk4trV/po7ejANIeDYuHUFAld2Jaml7r+eqObwllV1WwkQajFoVNuJr7RUkTZ07lgM3DKxD6HBt5ZSwz4mczoR6iQj4XPohnP3LCUdN+fS2xlgA8vDe1UhsF14qv9vQz35AQyNCwRSV9BkdYqtqhxZSJSWMpbdVJdXNGwWiWnlHYj7C/wEHQ/PGxwqmxBqVxyucUWIxEmIltBZEZrfw4UYEmvHEaI6RT1gBYpeX9ZIQ4R9QBmmVT6t6sFAkqhwsegexZW4xcMH1XcUh4VgCzO/qKMDDqRPR2h6710wfVhO7D2sQQbjJdmwWAZLo7cT3rsYtEikOIrJJ5lA/km9lyJde77TBtsSQUrtWJ+0iXDofEIf4S5Rk7PD1kX57KQHz5PhuKYtKcmzKTAeri1X/OVDanDubDL9iRhexrBpd0MpiY/2jZtdqOuq6a1+2sF6Em4LU0Y2dtlQP8VK6tlNakGcjYPYpcPA3cxvup3au/Pqf/Yglgvqwzlm1l57Fs6wszmwaEfRfMgrZLTHq7pvRIs2Zk+eV+0uu5nOIgag7LZJidT7u/Bsdio4vfgOfS9Eco4ghBG8ipF9A4wbOVgBVBDFtVH9efJF7T+U78+AcCRoUWxlLLmNIVxAFwmAcoBNVjPRBpi3TlmQPjSU8rSY2TodAYpZy9s1uf4x42h0N/sH3wuEWoQiu1lZApcBVVJ/trVJRufkmXUfagGXJvkUKfsgnxFjh9PcVujX+eFxliYu8CJ5y/w5uKRHmvVHLLnDP/ETIIjMy55FFit16tyX1puBLjANeqMncm5SQWZeA0NiIGxRTkfa/WYfgcs5Eqps/vJ5yu567pbAZOmP9cNrQPAmDfkLBJ4gAQ7ijAH YUmEPt+X Si5YwPV7rDlz3JQROGudH8fabZEFByud6iZUiTY6Mw97s1tdH9iBk/dP3sXVOalDQC4xMyPIwhYmBFCEzsKNBElM7mZoK2Cn2L/7BNmZEJAsiQQbmY1DaQBWW2B+m2R5+OBye2D43QU958M+FowljOZTHqLees/5Zx/OKRBlRIAfi36yS/0U6BCGWzE1AVL6WTaNsN5TQbRFPmrQ3KBA2H/0cAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000288, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Panda wrote: > +++ b/include/linux/mmzone.h > @@ -217,6 +217,10 @@ enum node_stat_item { > PGDEMOTE_KSWAPD, > PGDEMOTE_DIRECT, > PGDEMOTE_KHUGEPAGED, > + NR_MEMMAP, /* Page metadata size (struct page and page_ext) > + * in pages > + */ This is not how we write comments in the kernel ...