From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA94DC4345F for ; Mon, 15 Apr 2024 18:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 580DD6B009C; Mon, 15 Apr 2024 14:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50A396B009D; Mon, 15 Apr 2024 14:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AB2E6B009E; Mon, 15 Apr 2024 14:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1C9D26B009C for ; Mon, 15 Apr 2024 14:33:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DB407140777 for ; Mon, 15 Apr 2024 18:33:04 +0000 (UTC) X-FDA: 82012613088.18.2ACBFA6 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf24.hostedemail.com (Postfix) with ESMTP id DF232180027 for ; Mon, 15 Apr 2024 18:33:02 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gv9tQK1L; spf=pass (imf24.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713205982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNcHy+TzPeXZ42fji6L7sScXpSVOyjoITtnKJA+IyQI=; b=C9dJnsUbk2pHL7gurV0frI0araMovAgRRkNyENxCJxomwjps65iZ3tWWcegZgF0ywqHd3r hK0oG13y2tHMcxB+6/aSrdcfru4xKebOGzIRIcsaxeAsfVREH1R7AWKKnpNFTPyFC1YXi6 Vko++x6XQtb7Ehv3XiooWEmhDWiA/X0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713205982; a=rsa-sha256; cv=none; b=59p+VhEg2MmzGja54AbrIuOMlugE4PfqndQs50J2/HQDLBBS/AqKNFI8/ogxJsxasRScL4 yYy+e6pOAH/Hm+8v1ToE+iRaxrCm2S5hEqCJQ/mTbovMgUC74Qq6wVG5l5252mmoihPDkD 3HjtQJc2jiNgnmwAj+1KI5CFsMOgUa8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gv9tQK1L; spf=pass (imf24.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-61ab31d63edso16445947b3.1 for ; Mon, 15 Apr 2024 11:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713205982; x=1713810782; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eNcHy+TzPeXZ42fji6L7sScXpSVOyjoITtnKJA+IyQI=; b=gv9tQK1LH6+ZPXpeQC4tri09OFEFtMcAiUVOtvj3jS3B2uIQf8jXj2WrXAP4RxQSSq JkAZy01T275fw3Gq0wov/J0X82K8X7i0L9Hwy+AEWuyunBIBXGQFzreF2HQ+W/Q94KgP G8kUXiHiQ8ONghKBgMjkE8SoM0qVbVUDgAN/C4MLJONnLuMSPR2raowjAJL3n9DQLqEd y5O+HY0rYzhBOnqiVzRqfHyGJZJjXZOQ6DTeBc0cja6OX0GsNjHtyzooh7RisUgjlOLR SJdpi7BkNMoieBnoNbe0wXXtHyOi0dGApU0GhssTQx9xRAOr5NUzmpV6Bbk6Wllg9B3P gycA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713205982; x=1713810782; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eNcHy+TzPeXZ42fji6L7sScXpSVOyjoITtnKJA+IyQI=; b=pVxw7jzqowV+zNsJuyVxbo+eFCeNht50so5RFEfTdnHlpuzfbuyE5RJ8cmGbsG9YaR hJ676doSIu0xzObrVTFuzjkfYqBVAa4J0AbajnSUqcbVam/8O0JdzdZpgBo87IW9cxrm tbPCawRvdra1Y/2h4tsKeY/6L7uqEbc1DjkiZB5pnD43z/28FtURlZD0CWgJ+wcnfbO7 B/9bgAWv2w7RHrauvLv2pnjCzqo16wXveWrQyoBIC9tInj+JR7JOsTRs8oY7DdsNGEjj GPoZSb0B15yhLq6lzbGUXDpJrtvMNNtp6XTwmKeWpkxskQJlblKjiQPiblrViiGzDt7J fAIQ== X-Forwarded-Encrypted: i=1; AJvYcCU+2VaWVeYIyt3TX44Jh4BXxwcLNQ8sjU60tQR/tX+mroLlcYEpJdgOvyYBzq6BRwe/SmVZKAJwO16EvfiqjZZkf3E= X-Gm-Message-State: AOJu0YyMgq+QxtXEtGttrIJOgl2iQ+x7wNWS+032YXv7k3raMWgJR4kP dk4doZhQSNVfHfTKsl85sD5WSYaJM1U1s/9msR3I4O0+wkev3zL2 X-Google-Smtp-Source: AGHT+IFd41E0xJdFEcj79NR6aKf7SidRiPcSVcgBmo4FP5MGfmt/Q2iLAkLuDmynUN7XhOfNcDBFtA== X-Received: by 2002:a81:bc4d:0:b0:61a:db4d:5f16 with SMTP id b13-20020a81bc4d000000b0061adb4d5f16mr436941ywl.15.1713205982014; Mon, 15 Apr 2024 11:33:02 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::23]) by smtp.gmail.com with ESMTPSA id i194-20020a0ddfcb000000b0061ab49c04e9sm1016739ywe.76.2024.04.15.11.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 11:33:01 -0700 (PDT) Date: Mon, 15 Apr 2024 11:32:59 -0700 From: Vishal Moola To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, linmiaohe@huawei.com, jane.chu@oracle.com, muchun.song@linux.dev, nao.horiguchi@gmail.com, osalvador@suse.de Subject: Re: [PATCH v2 2/2] mm/hugetlb: rename dissolve_free_huge_pages() to dissolve_free_hugetlb_folios() Message-ID: References: <20240412182139.120871-1-sidhartha.kumar@oracle.com> <20240412182139.120871-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412182139.120871-2-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: DF232180027 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5sqnsz68pzrebtdphemjdjfrtn174h6o X-HE-Tag: 1713205982-915225 X-HE-Meta: U2FsdGVkX181YrWFjylUXmTyezN82VAXZskfXiZnigV0sTrmMOufSNQTAu4H6wkvKEe+eixI7N2ShlF90SBNeGM+Mr4+VcHSY3s359tpHNDNNk4uiJ8/DnhdKPE4pY5rdM2HlAEpFM8xeiNrEfJEFXl14TWnGCP4fzpsZIxPg+E4sMsHSdUaJsTzKpNpBCNOGXX7mDDMXfpL2Lc6ymjPmzoJ0Hn1plrbBVo0Qv2DwdR2aPTmTpKdE+q4+xxury+34s8Xehj/bbeT42ovtwsajgYORhNrI5ao+fOZQQEG8fB5rPxMhEz6J58q80dBwYirjEX3uuudSMoBGiCgfurEEXf7yMptkbG/a45os9vH0NENBuyt/1B77fXr3PT0z88dkGw5eTncZtt0lfHzT3rf/+TE9gOqRmVGFBln/VG/sgskNV0GfO0jEb7qwIL6i8+8KNvcgLBHwq1CP9/xIqNUCSQZFfvfC//XYhBisUv870gu/dLcdazthFYXUCDlN0dLOlx6s98kc3R0p1jlWf66QNgn62dSl4BekAFEZSnp97ZIz/ry2Oa8y8tI0Z3OQQgrMn4kPQQgUcvGPtXZB0ay/E0N1gmZfJoxXcNjC4foSl5nlzAIuOJmTSR3JPJVMNVd5Wc5nsgMQDyizv+4J5qHep/WX2tu23E/ug70QZ7CZS7aZykky/51IUGgoODBJYEqaB+MvGtcqUoCLTq2Xq6ahkwGOZCooJx2lbqQBxjGjG/mCD+uAtbV2dkoFJ0N4sHB75C/uHh/sEya2NHdGxok7qA4odjf5/ooxobeG08+GjlAL8aYI0C6aqBvE/Sis480pifljKqMhENlcBfBpp2NMJn8IQS6bonf0jcDVxOEKMTy/ayhdDG5V1XVzNAqdU1Di21WR0tE6F+UHC5FfJgS/TE8L0PYhsZX+sf5ssrBfKSUrb910/sX8H9TI4ARXCXx5CGFNpPCtvFEzfHuWb/ DeY8hh2S af3Z+fAAz87FBxubkzdi/oE7glhaQzT1OQ3mpMokV3raa7pbYqvwQIeYw/ta1508uF+mkhd1sMC6CKb65sQcHZ23HloiK1GZVduJKBzetSCc+BJYHTlsBefRegw9oIRkqif18u7NGRmwTkny0WzZ5kAeKQamYe+zsEfiz3Ur0yVYuI3u/ldxj/6H/WQhIoawOpw8eX64Ajce5UxjSEL8YEdq/nX5jxwNYXxZSQOEZcAnHJbYu9qa5ak4xwFWxuvDLMJOS800xzhYLAyVqS6Czb+KuX0jLXaq6Qw/azkrqLnaK3DbbIyR1blZUsMlQiUtSnZ+4ybe6fUB/zWHkXyjtnx0pEczlXt7vE8/kzQ0VW6QcD+Prt9ZPmgvtXKf0uRRP+uPjkXNqdOx/aZ6VJNYXzgaqNcVUtSG+hjsLuqyYOL6UeyF3OV6nPUM+zA+ZnRvHtf75l7gVgJnJGUIEM2KPZynq2FgSj1H8XjVOfmlMDu2oFyFSzn+ey/uXKLPjk+J8ASQ6+8zcZVwowRzUSSmW32jcSjMKh9LiROmBCz7yhRHMfg03aQEKmdY+w4dE4hY+FvKpyIcWQGUOj0gWap75XLLzBCGOqTLKdI4yY45pzX8yVmksw+8cwT8TXONHEmnzyK8i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 11:21:39AM -0700, Sidhartha Kumar wrote: > dissolve_free_huge_pages() only uses folios internally, rename it to > dissolve_free_hugetlb_folios() and change the comments which reference it. > > Signed-off-by: Sidhartha Kumar > --- > include/linux/hugetlb.h | 4 ++-- > mm/hugetlb.c | 2 +- > mm/memory_hotplug.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index f4191b10345d6..9ad7b97069cda 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -862,7 +862,7 @@ static inline int hstate_index(struct hstate *h) > } > > extern int dissolve_free_hugetlb_folio(struct folio *folio); > -extern int dissolve_free_huge_pages(unsigned long start_pfn, > +extern int dissolve_free_hugetlb_folios(unsigned long start_pfn, > unsigned long end_pfn); Same comment as the prior patch. Reviewed-by: Vishal Moola (Oracle)