From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9E5C4345F for ; Mon, 15 Apr 2024 18:28:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1FA36B0082; Mon, 15 Apr 2024 14:28:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF596B0092; Mon, 15 Apr 2024 14:28:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96C06B0095; Mon, 15 Apr 2024 14:28:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D07D6B0082 for ; Mon, 15 Apr 2024 14:28:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 331341A055E for ; Mon, 15 Apr 2024 18:28:09 +0000 (UTC) X-FDA: 82012600698.10.62C7D0A Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 6A2AC180003 for ; Mon, 15 Apr 2024 18:28:07 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DoXDKGPb; spf=pass (imf24.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713205687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gzpn2mqeQXvBfqEE8KRrKxdSsji4vYUEQ7aPRX98tS0=; b=ta4qJTFUbWVjUv0Is1oV2wtkfS1bvILzcrxdCdK7Xj026iFyUcBa1xB/slrjyrwVgn/1ch uJojaCIV7pyQgvx/2tj8jpiiT9GIfOJMDZm5w9A4UATkh/ztM1VS91pciaIJGwyT0uCVUa +aP8F8JjU1wKtiNdgm2i4YdZBzuU2Yc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DoXDKGPb; spf=pass (imf24.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713205687; a=rsa-sha256; cv=none; b=J+NgVBzDchWMIEtAcqj6y6toRaj9KmK3tPgZ9CqoU634Kze7fe7s+ypWtNgAM92yYVM/Ec 7HKL91fXvjBYQNrYEj7anmv/6OV/eZmFXPmsUBB8Y1xW77RWk6+j5SkbcK1JWBwbICb8wO j0KOHXt1pBZY6A5b7Vg0kJo2Iw0KooM= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-61ae4743d36so7091527b3.2 for ; Mon, 15 Apr 2024 11:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713205686; x=1713810486; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gzpn2mqeQXvBfqEE8KRrKxdSsji4vYUEQ7aPRX98tS0=; b=DoXDKGPbLznBbysimqS5OPV/8h5TbRtDqyLf7sRGuaJ3YzskWE/HNjNSGOxLMBNM0v Jrq0zC1Q4Qltv4b49Y+7iZQBV1F5osB0wgCvjrnxd5a36yW2IyZobBNSadGF5qIL7cbZ TQfCMkH/+uWT43GvHBqTqf9cKV8zVz1g2hoCtYcRvfH9Y3ld0NuyhO5mfbzG6Zsmbv7m oHHvHP6oV4VHKF1K55y3DXJw9T017bvs9jAaIg6ICCLkDAEruomgSn3PaTAIreprqqFk uFesxIz7/F9YTKAHyInBYEQvSADMWvMT7CIbzqEgIr6MAz3QdK0jsZXVcxHXiZbBt7b0 ndQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713205686; x=1713810486; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gzpn2mqeQXvBfqEE8KRrKxdSsji4vYUEQ7aPRX98tS0=; b=R4gxrEYGw1t06nv0fxI+BgVxwepni79pESIHkkv5esGiCs5SEAPoxJiR0Dw+ToXPgB WVGdCHqWsmeETQvW21D4T5jjwtoPyAeb2dMLvfif2c9xvaV1+V169kijpEfPSfQB85Xd sC9WRTeW5C2wa5zyp6hznRs53lpxQhK6dal+K0HLZEci1ZjD2oEcvuw4j1lXBJh1jILp KQQL2ELG4nMI4QuA2f41NMcuDrzTFua+NKodWxycoS215WEKPiZ2YjsRoedfvMPp5sR3 CtELQAE9IckEG0Y3GoK25hBkmN2oeE63l+p3qKLcPQeev/MhfxlqQ626JEkn0U8STmZ4 1NoQ== X-Forwarded-Encrypted: i=1; AJvYcCWgUQulDkiFkx1Ch/lj4z4/Y+9lSt9J8ze4IB+j3J25ktfDBP21ct1hck+TCYo3oB/MdDD3kuzREZsI58HamilRT5E= X-Gm-Message-State: AOJu0YweufPbRUyjNH+n1UYSEF08b2G5sM/DdapF1hRByYCF5HG7JHJj x3sq4TX+lctvReoqRe+gsLoX4A4tEocRpJuSl7yW8kICLqazWpFw X-Google-Smtp-Source: AGHT+IHCFw2fCgotXxAD9pFn9CQpn+mNHke37zPPOoQGGqkFVjBFZeisk/EqoUiYbmPkNLuTriL6UA== X-Received: by 2002:a0d:e6cd:0:b0:618:9470:bb2f with SMTP id p196-20020a0de6cd000000b006189470bb2fmr6114961ywe.30.1713205686294; Mon, 15 Apr 2024 11:28:06 -0700 (PDT) Received: from fedora ([2600:1700:2f7d:1800::23]) by smtp.gmail.com with ESMTPSA id y15-20020a81ca4f000000b0061ada21ac4dsm324395ywk.25.2024.04.15.11.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 11:28:05 -0700 (PDT) Date: Mon, 15 Apr 2024 11:28:02 -0700 From: Vishal Moola To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, linmiaohe@huawei.com, jane.chu@oracle.com, muchun.song@linux.dev, nao.horiguchi@gmail.com, osalvador@suse.de Subject: Re: [PATCH v2 1/2] mm/hugetlb: convert dissolve_free_huge_pages() to folios Message-ID: References: <20240412182139.120871-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412182139.120871-1-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 6A2AC180003 X-Rspam-User: X-Stat-Signature: r4wfbr9qb8x5nfqyjm1b8rdpbm5cjzfb X-Rspamd-Server: rspam01 X-HE-Tag: 1713205687-76378 X-HE-Meta: U2FsdGVkX18kSIytCjNG3OPgSbLsWX6pS/1YJ8S+Apu1WKeymJcl/cU8h8ZGkGZGV7IqHmp8Thwvr9kEuwmp/96MQVSe9vNIpA6yuuXwTcIfmJlHUA8vMY8yk5DFQAi8Lpe6bKEYtSiH/8gv7l5D/ke9fUkjQU9QCDBP3id2ReghI4KpnP3tN60bpP7jIHVT+kthk5wpp/Mtke3k8EVjueO0TREcaxjfF7A6Gbs5cdbhhZ+lVQ9zKecwlBLt7wfSUik1Ux6yLTieZZ5DUVDkiYJMDLredIclvbPbIIf9oN/SgQr6Ra0Bu9Iis14f8x61EPM357UpsRMlSz3ljXxOVIHD6oR1vA/5m3OHe0YCz4u203sNU4yuaXD9hiNeQL/YymbVqBDEXWDN+4kl0Decy7nwpVvkfVxw44z3WCt27dtxg6iuFJJdZyZtUnk84xsw5dnXOivcwx+dD3hlit0XXCnnNB6rUb11nVgUcOsKxE5b5a4mkIqhYERy/sCbWutVqRkl5jJomLuIddmJBZYmaJQ2Sa7sbKRCxAykJqibrIC4Nryaz+FQd7tz/DZNuM9TPIpibYd1vfYjtQNC322Ofd1eB9nv1EQwZuVu3685xVTUK1Csq3aCb8Wa5EKr/egWbspFoEyZy9/wPp+4Iwn7L7dtvWFps7UjjzeQKvKojInAMghBTpnDENM0ryRSzJUpecx3GRiNsYU68+CzjQUU/YhEnsAOgeAC19iPnRqFSIK0fimPXrtyrz6v2tDWSEQLvfPTetCo1oKyYwnBV+6wnL149fcr1JWZku+YJjUYpvO88swcqvwLNI6k7rtUeD5/t5rAWZeQTbwGGqITqa686bz6lweFANn3m7a8G70OQW+Z2NJK8OciXq+q+iYulzn/8yEXa1t4jvlp/NQklj3AAvaYcUgfjOeo7Z7mxc3ubnbR4To9LYro8wDsAqjGjgSGkbbe11x9lyIQLiIDv5V p01gbXWz aprf+U3ajmWnJOJDkW6nrIiKLLrUhULyw64chTtQm4bR7mNUg11Is2V8OlvnrWHhDP7Mrs+u+x5EhFnigP5vR+cQADryDXloOacEZyPNV36NB0pl7+jwMJ0I9nJ6tw9HKDw2H9WL8Pts0npYA+oWYzYh3druGa8TXTJSFBAjK+Tlx73PwogRDKH3N7m6wAXhRuYkH4U+jPS0OvVBNSf3Sg5FgU1gbPpQdnLZRaXdA+i4h0OPIFuc8RHUl0nDie/P8Dr94bkzYjG4s7DfBzGPxNE0zQYIwhghgKFQwTmxsWZ6a04yz+asoO8HO+5NiS6LKTa8oDZuESoi1FgHmtWE3FyV2sk9eYXSJjTiUNv0rx4/Wxx2jaJz9L935ECFWVQkcgYJkAT7FZMaR9E74krpDWyaNQphA5q+0nanUUXjw3CHOwFzZogLjcTbtaNCaDS46pyxIo9hMU7HOhGZcxG1CyDCEIGI+s+4qaZxY2T0JIzLbDu9kKrmdHSdc6uzWpSVV4/8h8Ub99aWrxPxapkbdMHT9tARCdKHm+CrRDlxdA3zFcAg7xIJpIGDNrW2MgCjnYLBQxjYXTX3mlv192BLS7j50qBAo5C2DHY+FVVN0J4eW9yPTQQZ8nCTLPwvx1bJjvkgT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 11:21:38AM -0700, Sidhartha Kumar wrote: > Allows us to rename dissolve_free_huge_pages() to > dissolve_free_hugetlb_folio(). Convert one caller to pass in a folio > directly and use page_folio() to convert the caller in mm/memory-failure. > > Signed-off-by: Sidhartha Kumar > Reviewed-by: Oscar Salvador > --- > > v1 -> v2: > - Change additional comments which reference hugepages to > hugetlb folios per Miaohe Lin. > - introduce patch 2 > > include/linux/hugetlb.h | 4 ++-- > mm/hugetlb.c | 17 ++++++++--------- > mm/memory-failure.c | 8 ++++---- > 3 files changed, 14 insertions(+), 15 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 3f3e628802792..f4191b10345d6 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -861,7 +861,7 @@ static inline int hstate_index(struct hstate *h) > return h - hstates; > } > > -extern int dissolve_free_huge_page(struct page *page); > +extern int dissolve_free_hugetlb_folio(struct folio *folio); You could drop the extern here as we don't need it anymore. Aside from that LGTM. Reviewed-by: Vishal Moola (Oracle)