From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F276C4345F for ; Mon, 15 Apr 2024 15:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE6276B00A4; Mon, 15 Apr 2024 11:28:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6E8F6B00A5; Mon, 15 Apr 2024 11:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941FB6B00A6; Mon, 15 Apr 2024 11:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 72D3E6B00A4 for ; Mon, 15 Apr 2024 11:28:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D858A022A for ; Mon, 15 Apr 2024 15:28:05 +0000 (UTC) X-FDA: 82012146930.18.D764A42 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 955BFC0010 for ; Mon, 15 Apr 2024 15:28:03 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ApDGQwSj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713194883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y72o4lVs8I+s3EpRCoX8VBod89ZgxzbxsoZNzX4AWEs=; b=BHuk8lFS1bYbo4547XLD8ipW+qh2ToDJIaAnZaYPKtQrxlRsTdrdk4FJWNdx2h1fr59f7g 8pFlZPJnpBeEOu9S+f1Fwln4vJMjngBbCrp5MtmH0kucqxL95QucjTfQhLB5ggXGrTYNbx 17aakcxUx9Yz4A+VW6F9kD4YO+bg46k= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ApDGQwSj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713194883; a=rsa-sha256; cv=none; b=VvSSpAbePCi/BDuw41pH6LTvF9ivNAfRhjTgCJknkQ+X85JFhUanKkAr+AG/knIAI/gBYr FyFgpu3iznNpTAT0l4MFQW7Br3E80TKJKmUIDBRkptlvRb7QnJMCE03XmdILXwA8L3lDmL DYHbRJ/sczUdam9A6siT9KkRnNDuxXI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BAD5660E75; Mon, 15 Apr 2024 15:28:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005C3C113CC; Mon, 15 Apr 2024 15:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713194882; bh=nFuB/EilR2fRv26CVIwpUuMAO5By/98lEvVtc9MltxQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ApDGQwSjGww+QFx/JBUZURMz/Z1g46KopFEuqYSkG/6mW733e/JV5rw0ppa96w8k+ 5K3DEoHy5Nh8mzFflu3oHifBaPSZuhTJ3rOP+7phlyRQ42DT+b5GanLkYcylCh8R/M bgLlUeuXJUoDxotpr2xf+0v3ihJ22S8BmYO1IMP2mrQTrwQv6aO8OSmVjpKe/RPjZ9 eHyBwZnTw/59ZxKY4SpdSrYdQRwoj18HWH5CO/vkgPqZNDWXR0vDhnIBzNszH7OxLh RYeAStgPx9oGW6OgJE1jjUHygivzNCoXPbiA8S5eDAZQaYZ25lB2BfEA6RmSuoEvLg rnWOwXS8JBDAw== Date: Mon, 15 Apr 2024 18:26:55 +0300 From: Mike Rapoport To: skseofh@gmail.com Cc: robh@kernel.org, saravanak@google.com, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH] memblock: add no-map alloc functions Message-ID: References: <20240415142448.333271-1-skseofh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415142448.333271-1-skseofh@gmail.com> X-Rspamd-Queue-Id: 955BFC0010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9hpxxaehgjaub8sfetsmony8976o6k3o X-HE-Tag: 1713194883-682229 X-HE-Meta: U2FsdGVkX1/ujNfKizjC99r73haPXCV5mW8qz/7s5KM1vFbq/fe8GbKlkkciTcIJ0MouqSzRHPDqDkmb4agg2NbfKMiwrALXxXVM+Y1Ycp0dXa02a5ajpoYN9en6JDx4KePla8z9p6GHuQ2jYFhYaYwF8EIQujOJNLSew7KdpdPhzZwLJWoSmyKKOUqth94k/RqqsmGS8gPU3fCrB0NAPJc7+7OyMyaNFZZmt7u7fwu1N7qIk7PGvxYrju60r5/6MIjDoQ+Zga1MNHSsk7jRoJTvmExKbhp4WqhDpVevjB6BI5EC40DX19u+YtAZEstkHpGRBrIpy3IFFeuwtLrKIEIKu+55cT6SDm06Zsz3eN2rjYKw2bBNicQ/Ki84yCALS2qK1Dk/YThejM/ojlv0Xx/KdpTLx1UAk9iVv0fi8Dt6RZTMwPd/JWfdeB2MPjv4NkAeYJi7z4TE+RuUAoU+/fLQrDxEVjHbfBh3XV6MXqh+teojvQ6HjiibtV9Jprd7Z9Pj/nW9dgHsDsoij4Hyzo52fyhWzbgTj/bdD0bh1pJXu9kODG54M7VeB6gsywzHpAtsV2DYI5GUk20xMgql2P/dW4TGyyOebfhyuDXWXcEeCU/YG3zs8Mr82gCtYJFrUXOQfbQ232N3MGgczlDGJLkHHYwWaNmuMsOsHlhAYRwcisKn+bBjGextsQRcCXOghFSf/BDu1LKGlbx4QHhelay/qi4b6rvsOmc5CoqC9EPKJtHl3LyBaXlPGUglvW/I0sR1A8HJTXMpPw76dkJHmay5Nm2+V3dS9AIF852sFj48q7ud5Im22lY9Dzngw1EqNs/SgRvI4ilbnrtU4f6nIyQQpQFLtqWjWeXfqyhDtCvN6qOZN2cEfkOhv4UGTxQWu4lqiJWJI1vKDxjmg2AmXYcGwCt8b1GRyfeLYkNdsAdmub6fSbpfZyRfPVu1Vd6MvQg2dTFMSRzWufeK3aY n9eFuVem h1oYRD8eTZRW2KErOgxHj5ZOwoOX/mGnzyF+jCDqp6vXvgCvB5RjRgXl9v6LbL/w6wX5xFkMboRSE+IAk1IJ/riRiDtrsmLait9DnwX67zXUlivjQZOS3HgZHhFM6Gwac+GcT8oAKMjDcQCWK5XgN3u+PcorFveY0D7jiRW10IEQ5EDyH2CcbYUxWRPV36KbvkwOm3ELmM7htEVHM/to2dmtZuq3sspxyPt0Gt2lo+JnD3JA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 11:24:48PM +0900, skseofh@gmail.com wrote: > From: Daero Lee > > Like reserved-memory with the no-map property, there are memory regions > need to be allocated in memblock.memory marked with the > MEMBLOCK_NOMAP flag, but sholud not be allocated in memblock.reserved. Can you please explain your use case? Why do you need this functionality? > So, functions were added that find the required memory area in > memblock.memory, but do not allocate it to memblock.reserved. > > The early_init_dt_alloc_reserved_memory_arch function was modified > using the no-map alloc function. > > Signed-off-by: Daero Lee > --- > drivers/of/of_reserved_mem.c | 9 +++-- > mm/memblock.c | 78 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+), 3 deletions(-) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 8236ecae2953..504f2f60689c 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -40,15 +40,18 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, > > end = !end ? MEMBLOCK_ALLOC_ANYWHERE : end; > align = !align ? SMP_CACHE_BYTES : align; > - base = memblock_phys_alloc_range(size, align, start, end); > + if (nomap) { > + base = memblock_phys_alloc_range_nomap(size, align, start, end); > + } else { > + base = memblock_phys_alloc_range(size, align, start, end); > + } > + This changes behaviour of internal function, what effect will it have on the users? > if (!base) > return -ENOMEM; > > *res_base = base; > if (nomap) { > err = memblock_mark_nomap(base, size); > - if (err) > - memblock_phys_free(base, size); > } > > kmemleak_ignore_phys(base); -- Sincerely yours, Mike.