From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B59C4345F for ; Mon, 15 Apr 2024 19:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67DCF6B009B; Mon, 15 Apr 2024 15:06:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62D206B009D; Mon, 15 Apr 2024 15:06:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C1B6B009E; Mon, 15 Apr 2024 15:06:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30FA56B009B for ; Mon, 15 Apr 2024 15:06:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ED7961C0A2E for ; Mon, 15 Apr 2024 19:06:20 +0000 (UTC) X-FDA: 82012696920.05.86C3FB2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 83E441A001A for ; Mon, 15 Apr 2024 19:06:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PJwG5pFc; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713207979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MChLp9ws+slgrxOBUGCVsKZbu7NB1tpz2huFIgNyMUM=; b=6FsZwUDfz+mWK2i4lB/RzKpxzVKVThK7g+RSugQ46kP0xI9i8nURXiMtzrWnnz7ywHIRIY fXMfG5Z59xAbTsut0gzEcB/yzs6opcMJ+faMSf6MXpWTZecxm9JhaL/zcPJV9o3jFsnIAD JcrSBSEXTUjWk6/5vAG+Qfc9T62szls= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PJwG5pFc; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713207979; a=rsa-sha256; cv=none; b=MbAYOeOENeJVVq6DwirBdxQsbXyKCzGZt/NHYqLzN3JGbeXOlGPNDxMsz2P22/5Bo1slgw wl7BnT4dJQCgJ3ww/Vkwxd7osnJloYNy/qP5jIJWWJYJUU701GuUb2VjYvv9bu6RvGF2hz XlnwnAYksT3DBcmYXTarHxV0vtx2r1c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MChLp9ws+slgrxOBUGCVsKZbu7NB1tpz2huFIgNyMUM=; b=PJwG5pFcev1RdMIj8qn6YK2j1U /X35JGgQp8HxsqhqFD9HoIdEnnIkypZpyZmXoJdWAWP/HFqGwg/n10lvoExA+pax2HMJO4WNxW8be gq/+xU3/ljtBvDcF5JKmNr9VimfwluKgVyBvqdVyDlnkT1WbkAgKky0UjJoVatMTpG5CRszweN9Jm Q4LpMJXidMN1e19z2I4zAWI5zor7mbeWFwuywTlnEj5q9Hv9D2E0MoUNZzRjM5lqTGOpnBsGStv5G GIpy4pq0CLYV6XkyOG0J0/nCLoc9wtpyz7GynB5/MJcwguZl6xDssMKJInwtYLJ4Fm50MTq1u2y9Q sjqbCS5w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwReY-0000000GJeR-0OS5; Mon, 15 Apr 2024 19:06:06 +0000 Date: Mon, 15 Apr 2024 20:06:05 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] lib/xarray: introduce a new helper xas_get_order Message-ID: References: <20240415171857.19244-1-ryncsn@gmail.com> <20240415171857.19244-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415171857.19244-4-ryncsn@gmail.com> X-Rspamd-Queue-Id: 83E441A001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 87fkrhp9x4q51cfaqgr8woe7nfey3h8h X-HE-Tag: 1713207978-854115 X-HE-Meta: U2FsdGVkX1/LVEeBXK4MBCgAobr53Pw54qsPgpi3pYS4QE/4VYagdnectP5B8ONpJ2J/cH3++pB5JXG/60/I8dbU56AKXNLcFuQ0bX+gvOOmG1TbUYrBPyzMt8rDqDDIJcI4ZUqG/sYbmkVMWkdvBXAP5btBRnbsJxPjKitbS/prZKYvYjd4let6QRay92RuVqeSpJC9YIqYjla/9TQ6TkxwJ2UhFKiSlh7z9UzDYzhPDhmVYXzMrTgMcsvkrg82JESihxOA+OQlSFhu2hIme7kb8iWfCxmIW3039iLLhY4CldsZT6qLbdWhCuf6DA/R+a7PdxEfnKPPMI4w7TybuInPr9cXlkATZlTtMlZt4rf38ZUi8eq+DsHFAwTFBVDPyMzEkNS3HPOc6nuvxoFXePetkWj8cJhsmqNg6OjghqMQPAeQzbtRglPfeMKBdS/SUbe55u0rHh6kNLRAJXlQ5qYvFm+Abt93FzaXmAtDJLzCJQQGnRiE8MgREmLyWReJrnvFTW8uq+9UsA4QOkY3UCqtgBV391CuuhGzsu9wOLdZRd+nLe9X44q2OQcb7tQ2TWQEjlRfEzphhn/IKU3NVITqd/lBmBh14mSebdrFMOm891XGWv0AmkGmSUdMyBAduHaitNANsLsRjQTzyzFxZJP3xECNJoE/+5qiMOaKsfJKVcKnuES9P5ke11MhjtyHyzVXZvonxtwcwnAiVl3exHW4SL+edJrnoPVTx3/5J3H6eSjY/MFPn5I9ZrKdzWWqH7lAzPBVIPS3Bgf7v/sSbQTFiEQlkfvN0SXn5WKuLrocE9F4bZ+CYfSD51Qhkh0oGQlry3zQGbFF2IGblZ+GA2WdSJ489EX+CQGBWoVEDVkJmBpLGeWHWFHVS0oqAETnJLvnhG3xc38sLxmPu0uR4Sp7xIyWuWQk4xGwZI98XdFlviQ5JnshzOGpCf0/lbJ3qwwD+PiptP4rcTZDFZS QYKBIFgb mGGlgBTN2RR+q7ghSB9hTV2ortKQlRBHLxYf1jzBFZby2vkkrNN56FlL2Xb/VxC7lOtn81p71FpBmDcn4tHsql2+9LWWMyMb1yOifEBbRsBnRJ8sIu0WDwY9VsFhtE2Qh1enEoo/FSTgltZlaVxdt9zL7p49SLjQfom1SII1noTgs1UgW4JY+aupF6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 01:18:55AM +0800, Kairui Song wrote: > /** > - * xa_get_order() - Get the order of an entry. > - * @xa: XArray. > - * @index: Index of the entry. > + * xas_get_order() - Get the order of an loaded entry after xas_load. I'd just leave that as "Get the order of an entry." as it doesn't have to be after calling xas_load(), it could be from any other operation that moves xas. Also this is the short description! > if (slot >= XA_CHUNK_SIZE) > break; > - if (!xa_is_sibling(xas.xa_node->slots[slot])) > + if (!xa_is_sibling(xas->xa_node->slots[slot])) Could you fold in this change I have locally? - if (!xa_is_sibling(xas->xa_node->slots[slot])) + if (!xa_is_sibling(xa_entry(xas.xa, xas.xa_node, slot))) That fixes a sparse warning which existed before your modifications.