From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB05AC4345F for ; Mon, 15 Apr 2024 13:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221FE6B0088; Mon, 15 Apr 2024 09:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D17C6B0089; Mon, 15 Apr 2024 09:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 099FB6B008A; Mon, 15 Apr 2024 09:15:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E304D6B0088 for ; Mon, 15 Apr 2024 09:15:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7952F1205A1 for ; Mon, 15 Apr 2024 13:15:13 +0000 (UTC) X-FDA: 82011812106.23.A017A4C Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id 3F53D40010 for ; Mon, 15 Apr 2024 13:15:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="AEkZu/Mm"; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713186911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3rN8HQolmFxM+YUKj2uZxSUDCD7dmomLpdfAKbofYKI=; b=BpXQ7JlTex/2SzJ7SNrnb9yNHhG+cZxK3aPk1qFyztwAgdbALa5ueAGJq0+iyUu/kyonzb 8rh2tnpif58OFICU/uiuG+RODSda1dBsrrviWH/mbdQX5HwrZ0PYip1vtPw2fyhibYlzE3 Cg2C1E9c1Uqhv3zgsm0+pINF8Y7wFbA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713186911; a=rsa-sha256; cv=none; b=EbEkPTmDVTA2HvzLWa6B/MAITpYrH8nKg7m1pVFendQJSZh1XGIww7KBbrNZSQvb9WmBvw CJT1Gx1266QdMl0nZLCj+S2e7wKlYuwYsJ8smJBpivfEjHsgWjy5uIrK2qd4ysrK4jmx6Y 7Jj562vcjKl++g4DLwYsucWEW8fnGgo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="AEkZu/Mm"; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43F7PIRQ026480; Mon, 15 Apr 2024 13:15:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=3rN8HQolmFxM+YUKj2uZxSUDCD7dmomLpdfAKbofYKI=; b=AEkZu/Mm7Ca+NFMCjtJrRKZNcU2479rSJi3pmnksZWpZAKnK+uxDRgxP+MMwdKoxpzdI m3LGYAukWvsk3u8UmLsK2zNqN8UnI52a/OeysImif87mmxx/17mmY07WOgzVbh0zmGnQ o/GV//yItdyYyJIEv/nkcSZs+Hj1m2cyV9GqmjVjU3S6Jo5nIvMJ2Rc5qhPwVYL3uvx1 JoXTVb8ZZNyP1kNrNGbc7kKNqjZMYmOaFJbrfn1DoO8id7M9rCPjjfjrDMwIA5IB+1za LQteC1XGnCcVdd51OgggkHnaP0HAMUQbD/jvAI5nrFX2/+d4YPVdrE7m0ZvL3zLKV6Md Ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xgueuh492-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Apr 2024 13:15:10 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43FDF9cq018621; Mon, 15 Apr 2024 13:15:09 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xgueuh48x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Apr 2024 13:15:09 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43FCF5Za027323; Mon, 15 Apr 2024 13:15:08 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xg4ryr51r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Apr 2024 13:15:08 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43FDF2Qe30736856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2024 13:15:04 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A94F72004F; Mon, 15 Apr 2024 13:15:02 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A8762004B; Mon, 15 Apr 2024 13:15:01 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.5.235]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 15 Apr 2024 13:15:00 +0000 (GMT) Date: Mon, 15 Apr 2024 15:14:59 +0200 From: Alexander Gordeev To: Christian Borntraeger Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests Message-ID: References: <20240411161441.910170-1-david@redhat.com> <20240411161441.910170-3-david@redhat.com> <2a4ce6bc-49cc-45b8-ba15-82eb330f409f@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a4ce6bc-49cc-45b8-ba15-82eb330f409f@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: zS_AuAQk6eAifeK-Okqo40-aOdlhSPHG X-Proofpoint-ORIG-GUID: ocuVy9OvAL0I0P9GUTSSneucdjWqhqk3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-15_10,2024-04-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=791 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404150086 X-Rspamd-Queue-Id: 3F53D40010 X-Rspam-User: X-Stat-Signature: kyc4imzudmztdwgqp136w58njesru1ot X-Rspamd-Server: rspam03 X-HE-Tag: 1713186911-614117 X-HE-Meta: U2FsdGVkX1+FPANrRIPRUW+yrAHlFzC3N5Un8HNFCRyDt6a2QEkHOapLFIuwXpfCwuDMY5EhnnK4cvu3208TYgIlU68OwuXMrNw02YOkUoj6KzMIFULWcEKXeYQRWHSdNq1bSMp9KXi2MTLddrAg0aCXJqzZ6d66weAyBv/6nkEsNkCGffmyVRtSsEJ6wfvLPWVQlewVJ1JfoE4yeHuAOjv8GL3Aq4MmLmlhwQCRBLDw20vKMO/jLQFwzgce5dhvfvygg09tQCIAs1Vt6kO7fhym48AwqvTdBw+u8VRX0h0MuhuuLXQlxtuKvSEP0U2msIlaaNLGQncp1VZUq2csF17CGKXm0Xlrx6LOeE4DXgqOixNrHlu4roMVOSlhj3p1b42Mcr/QBQIQbv2tGv7Mhg2EC0KJvgbpwW+4TVYS8167WtuCxAtpVdNnfUfcR934xMtJRwCSDFBpHVwtaexC7B+54seO8N6zi0hlBZOABBPU0Oxh3ft+UxD2UJsyg9ZwMjbGRrreMkkFrfaD5GmcFJg/tsVksEhuNDQzPBfR8LJlZMDlP6hrJ8mFaUDqVnYq32UyHpA/NqTzmN+nwK4IE/vJP7t3f/rWgnxYHp5AlureAejwVh/Tiea+mTsCl6B6stWteMCRim7cGZR4ZtKoQdWtzM/25SbFhCJFQN8HgtZXQWY+BhuKlN5f145sYz5JWTmd9VVIoVE6WDTTrWxP31INeKgF2xaU/0cRXuNY5a5RAkCnYVLEZ03nnSW9b3KUPJeCuxo5ELz8RaerbJYVMi0gKfq2FQU+kGi3W2lt2aziFn3fEKx9Ol1ctjmp/7wfcyT6dRTUx5ZWGJJKa5PkJaBEdETghFukLbM79d/ksihq7zNF6nt6hki2Z5TBlXr1Cni52p+f1BsYTXIDAWEBuRZOSFz73CXE00duLIbMapaNMuvTbd3SYfDJNEeMKjnADddopxRuNN8tBa7sXZk dDThwaxF J6s+B8vUuSaIe+LcLa3eL/0EARdwGytn+TJTzPECU7bYZMq1DmQJiQjppAOIX9oIWOfM8T2bV+XXc1dZjPa6b4URG/4oGxM9V6EAsYJcxQfvO8CnzNMyKlS5dg6VtauJhKc2eceEEUEUSCV0OejAvewGv2XRTbZJ5O0WanfoeLMPdu8b88ip4fkLeOAZIGeq/JjidMK4NLJETfPk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 01:49:15PM +0200, Christian Borntraeger wrote: Hi Christian, > > On 11.04.24 18:37, Alexander Gordeev wrote: > > > On Thu, Apr 11, 2024 at 06:14:41PM +0200, David Hildenbrand wrote: > > > David, Christian, > > > > Tested-by: Christian Borntraeger > > > Please, correct me if I am wrong, but (to my understanding) the > > > Tested-by for v2 does not apply for this version of the patch? > > I thought I'd removed it -- you're absolutely, this should be dropped. Hopefully Christian has time to retest. > > So I can confirm that this patch does continue fix the qemu memory consumption for a guest doing managedsave/start. I will re-add your Tested-by. > A quick check of other aspects seems to be ok. We will have more coverage on the base functionality as soon as it hits next(via Andrew) as our daily CI will pick this up for lots of KVM tests. As per the cover letter I will pull it via s390 tree: "Based on s390/features. Andrew agreed that both patches can go via the s390x tree." Thanks!