From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D15C4345F for ; Wed, 17 Apr 2024 10:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66086B0088; Wed, 17 Apr 2024 06:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0CF6B0089; Wed, 17 Apr 2024 06:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B68A86B008C; Wed, 17 Apr 2024 06:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 979B76B0088 for ; Wed, 17 Apr 2024 06:21:19 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5EEFC1C13E0 for ; Wed, 17 Apr 2024 10:21:19 +0000 (UTC) X-FDA: 82018631478.11.426DCF1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 475B916000A for ; Wed, 17 Apr 2024 10:21:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d+OxPeNv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qYsTlNEr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d+OxPeNv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qYsTlNEr; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713349277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fh/JsAx365b5+9LhCKoSfw3empGDkEaoXILqTfsoTCk=; b=G22otT2UkDGqZ6Z7b+DCBa2Iu8JqzJnFsZKwSV0R67LgPQYlHXDpZs2N2ToCmLjQ1ONrsb SfVhvNwbP9CNN9cMLEHiB0X4t24rQO+ZIl07B5isptMYB3HzVjBBUAwXw9QYQHlRdERRUZ g+uqkavb9kPK9ppT5vuAKVBtXjh/GQE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d+OxPeNv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qYsTlNEr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d+OxPeNv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qYsTlNEr; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713349277; a=rsa-sha256; cv=none; b=TMB4DSe0Kn+FwjLPohdqOBSXdBIpAZstSs+JPU4IAx69t5ea8nW/Gsuzu54SL/k546ptAp ACx2rdM8qFhh63X1o3PA6D+tsaHLczcz9QIiRW6ZpUlxktg8pm0Rj1TzBJprPQFQc5EMwt ofxdBnPHgV5GQ1t9mI/Fu6v81oKiXLA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A62ED33AE8; Wed, 17 Apr 2024 10:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713349275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fh/JsAx365b5+9LhCKoSfw3empGDkEaoXILqTfsoTCk=; b=d+OxPeNvL9YZMckUpJ0g7mpky2kuucuY0AHSf+tnU7LMVcSFi3BNZYTuRv5xAE8Y3S0DPZ /B9XizzXL43tJPuukB/oJdSIdC1GRmUA43BPEtIuMrddLMIIgY0SqDMnPU4EjqSJPZjjo7 Xo4Ghgcls8EmtbRCoE0BsTMce50IQco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713349275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fh/JsAx365b5+9LhCKoSfw3empGDkEaoXILqTfsoTCk=; b=qYsTlNEr0szT8LVQsX4hafElClV5lnrbsMjMbFD7CsWOZ6ZmYNhkp1jGoNA1St2DEoueVm JOdgAIM37OF31WBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713349275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fh/JsAx365b5+9LhCKoSfw3empGDkEaoXILqTfsoTCk=; b=d+OxPeNvL9YZMckUpJ0g7mpky2kuucuY0AHSf+tnU7LMVcSFi3BNZYTuRv5xAE8Y3S0DPZ /B9XizzXL43tJPuukB/oJdSIdC1GRmUA43BPEtIuMrddLMIIgY0SqDMnPU4EjqSJPZjjo7 Xo4Ghgcls8EmtbRCoE0BsTMce50IQco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713349275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fh/JsAx365b5+9LhCKoSfw3empGDkEaoXILqTfsoTCk=; b=qYsTlNEr0szT8LVQsX4hafElClV5lnrbsMjMbFD7CsWOZ6ZmYNhkp1jGoNA1St2DEoueVm JOdgAIM37OF31WBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C569B1384C; Wed, 17 Apr 2024 10:21:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kadzKJqiH2bVawAAD6G6ig (envelope-from ); Wed, 17 Apr 2024 10:21:14 +0000 Date: Wed, 17 Apr 2024 12:21:12 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Muchun Song Subject: Re: [PATCH v1 1/2] fs/proc/task_mmu: convert pagemap_hugetlb_range() to work on folios Message-ID: References: <20240417092313.753919-1-david@redhat.com> <20240417092313.753919-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417092313.753919-2-david@redhat.com> X-Rspamd-Queue-Id: 475B916000A X-Stat-Signature: s8asebfo31u7iqy9qqgpo1afx3mg9fdk X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713349277-392734 X-HE-Meta: U2FsdGVkX19KYi5qhadJq9Jk/ZPj+7nt6j+k/UuoZvN0rJbXUtTW0Yd65l4Dla+MnFaPUOZI7Ru4PUj2WxQxpi9uUp7cKflDXd3SL5DnnA/d0t7nOocD14L4EY+6cwU8K1MC9L6QWFlK0wEKQUkwVlcaFSeyaEL+xdV9qskltZkV/kT7PO4NJI9TJgqW1NCmFNNsquVXs2Hy/v+CN46nP9fY894B9c9CJ/2ZtJYD76MmpNzQ6UtZtTA+PwiXpwoghy2JZ2ee48shoXPXEuvNlcM9lT7JoSpQ6hjHdEpRVFGxvd3i312kWeCV8mNbVZXwK9ftebQy3ERj1Shbh8bSpthPO50T74a2GTc7Xxu0hLCEl8GFJpm5MtFQkCSMm5IDEA4DOdbuyQXvs3386i8STu1CvFDXTBFuPVuVvaNsODcnM0XzRMuYbU8BCyjeO18djjK+SgTnjt+LP0+L94Qgg5X/52dvYp4zBKtT2ZBL4lGqhDO4Ov92sKvDyt9x9sTrMCa6IPObeVPq9VxjlQuum9Fn8NIZdtGd6JgQoPcPLfqfAV2/gZ493f/JTKdoZwcak6WaQRp+tvqaJ7mB3zwUDYZG9m8OHEtUeAisrePLyMpY5qyRnoheXgpLlnPgligrE0n/Z/o6Tt+jTb4eZ9MMwrFQFJHq5pNH0QqFsMNwgzLeK2Kqr9jGoQRgJsrBOXqzScnWMUWcXVgGy7VjrzrVagB/F03PvnDbByIguAE+PVyVDzC+ie6jDqhQZdUfVdSiSzl2L4l1EO94xcNQ8/ts8usZKo1/8imkgrH8BJnmOlvMMEdg1bVsWNjbxFJQg6CPj7qPTxRkXGfLiMKIEpIvBdS4JTpIKcEnXh8dn0RDoKOhCDaKKg1MXSQcsuNTeuTjHysyKCwyi+ZcSWheWDFP2o8a2Wddl0SuXEElubhfyOw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 11:23:12AM +0200, David Hildenbrand wrote: > Let's get rid of another page_mapcount() check and simply use > folio_likely_mapped_shared(), which is precise for hugetlb folios. > > While at it, also check for PMD table sharing, like we do in > smaps_hugetlb_range(). > > No functional change intended, except that we would now detect hugetlb > folios shared via PMD table sharing correctly. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs