From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26971C4345F for ; Wed, 17 Apr 2024 12:09:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3621B6B0085; Wed, 17 Apr 2024 08:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 310A26B0088; Wed, 17 Apr 2024 08:09:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D98D6B0089; Wed, 17 Apr 2024 08:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 008B76B0085 for ; Wed, 17 Apr 2024 08:09:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B4332160DC5 for ; Wed, 17 Apr 2024 12:09:45 +0000 (UTC) X-FDA: 82018904730.19.5527DC0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 6D9B84000F for ; Wed, 17 Apr 2024 12:09:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vlS4lE2K; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TlHCqslP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vlS4lE2K; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TlHCqslP; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713355783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pptNZkp6pulHR22seSGYcg9eKyjdPLVEknH5lx1MXtM=; b=EyKU1FeRo5cKGmR/sT4vvwiiYdI22BrIvMgNWTbWC6S64xmJNh3qbYUMwiZ4muUolADZkr yakMkDa3AYT/xDm3EXzuW8I586vSuuZ2oGgrOd4PjTtuDx+DffvBEeEBJGwSR5gqQJ6Rrr sc6YjTaWXuXflb+MJI/2PpV2C/5phI8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713355783; a=rsa-sha256; cv=none; b=F92aLsZNt9CWWx+pvYe7G7fyQB9iwfEWavUjCXxDoS83efLmA4iWXVzODnyNvB8mFClOVy hyoIedMdN4HxK/NSOWV9UBfjR1efMV+ZjVkbTTmtWLtvKxuz/fSxkB3xzfz+rdUC7jPI8S Ifzs6He+PFs5wNif4bMLooxFOPgz9zs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vlS4lE2K; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TlHCqslP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vlS4lE2K; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TlHCqslP; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 921BD33BEF; Wed, 17 Apr 2024 12:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713355781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pptNZkp6pulHR22seSGYcg9eKyjdPLVEknH5lx1MXtM=; b=vlS4lE2K50ZRnqElpinbQQmEi7VsBGX9ADnqHneRMb3ynjpIqc74nHqzeaz4AIJVoa+3Qp WKcdzen2+/Q2voEUyvdL4btbCTyBWGp8U5IbY60BglkL/6Y/9DbY3hN6WNLFxNggbpf5jf MPQPQMlvPiKSsVsDLYrOYV2beuCBxYk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713355781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pptNZkp6pulHR22seSGYcg9eKyjdPLVEknH5lx1MXtM=; b=TlHCqslPtkNWjfuS+9gquddFq25t0Z2mrXdxzo0a7THgMEKtodZ15JUl2VoW/ScjzJi+VQ ZnrVqPqgEchxMFDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713355781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pptNZkp6pulHR22seSGYcg9eKyjdPLVEknH5lx1MXtM=; b=vlS4lE2K50ZRnqElpinbQQmEi7VsBGX9ADnqHneRMb3ynjpIqc74nHqzeaz4AIJVoa+3Qp WKcdzen2+/Q2voEUyvdL4btbCTyBWGp8U5IbY60BglkL/6Y/9DbY3hN6WNLFxNggbpf5jf MPQPQMlvPiKSsVsDLYrOYV2beuCBxYk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713355781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pptNZkp6pulHR22seSGYcg9eKyjdPLVEknH5lx1MXtM=; b=TlHCqslPtkNWjfuS+9gquddFq25t0Z2mrXdxzo0a7THgMEKtodZ15JUl2VoW/ScjzJi+VQ ZnrVqPqgEchxMFDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3295613957; Wed, 17 Apr 2024 12:09:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id talVCQW8H2aRFgAAD6G6ig (envelope-from ); Wed, 17 Apr 2024 12:09:41 +0000 Date: Wed, 17 Apr 2024 14:09:35 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Muchun Song Subject: Re: [PATCH v1 2/2] fs/proc/task_mmu: convert smaps_hugetlb_range() to work on folios Message-ID: References: <20240417092313.753919-1-david@redhat.com> <20240417092313.753919-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417092313.753919-3-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D9B84000F X-Rspam-User: X-Stat-Signature: x8ex3xx81qh7kjan3d6rdcfa19ydphx4 X-HE-Tag: 1713355783-494897 X-HE-Meta: U2FsdGVkX180Z0LwYpduWWC7CmM/zK3h5ZPLRxcpwTpfMLdzdbtirh6Vmw+8CKmOo5TQ5vW4PaizaQzyJFiMFE/HTOM1V1GlBlmH0uULIi6HeHhbLxu9QVhTHogB4VSO263jtgqQlhp+4yrBC/XDFWeAE5LBfGUxVWrjV3/trHveZTsAZ26qTt2BgMUn1Bcwdx2TLHtWBPb2JChl/xInZ7iGEla2tv0zWno+QcdAaDjAiigAgKgGiy0ayKPNK04Rv3M/QO61Hy6HoUyqPTYh6fXmyRfWUEYT8fB3X4kREh/wHdzesKcZgenEym4cvM2ey45jkjWy9S6TPSt7Hc5x0Zoxer7w/hTmCdfG7VTFTJ8agbV/k9XLdeTHAZSCvkGmQuVLAMs8m2Hh3j5FwauDUoPhLFdhAE0DcFaBkbs8R9kIF+bpJnF8RRbzusnfchUVSfp/6w3BXbFtdZOrop4amBRr+/wTWdBUmyrepPT/QWRns8ivnvacH8OH6lBusQN3I3z7f8z0Op39r/d1d1hpyWsfoAi/dx6w14kQ90QmoQJEC2oUknVjJ/w5eBnNhi75UJfo56wDVy0Ywr8tiImkhMCCEL0JVrlNUFll6SiulrjKfvfYQeB/dRU1+yQRZ2wRl392KOTYHq/MORL95k2bIv/zDIth8HphpqmcE6y5Az9Bfg0UavgGbkTHCyVOSD+SQgx5ouHZ1tRj7dlcO5Efnt3N5JmtAQNBX2bv5o/hcudkSfFwBKOFZW48SpMXmQ3NC2gxhKfPwOxmu3yPcWLvGbDwf2cCUaea+zZB8gORqn4aJyMZ1iMx7i75vy7j33Wm3ska31nYD0Y23zWbVN5eUkJreNwI+4x7Yumip1faguLAbLc6EqcPs8cKOhn6f8/3wnmSkUo0/WvuIiu7XmazC8mcZ4xwcNL84PxP0FQP2LoBQoCMVKg6mogxN00NFVNNGffjxYBHeRN45LN7AGH 8P9pwS8p PuL9w8er7ETZIGsuMePMwJN5TTlwK2P8mLDLU9SknMjDUa/kYLHFtA6U3R3bufO/mUiyWYFnoBCf/EP401FdQV0JpODnAHz1acQJqt62bmMYIfmNFzAXXVgZdcXS8Pa/wru+/0+nlRbKbNhs2S+k3xticE76JbNpIxkPytmCO6eVxAiwQ+44LzB+uLxuZlDwMgLaHw7dI//3HAgdY/CqjPNcjG9Rq3HWgua1WguoxqFuwe41d9KYcD3yVhk7pmRMNHcy46j+iYFvmuVNLxlBkSMsLVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 11:23:13AM +0200, David Hildenbrand wrote: > Let's get rid of another page_mapcount() check and simply use > folio_likely_mapped_shared(), which is precise for hugetlb folios. > > While at it, use huge_ptep_get() + pte_page() instead of ptep_get() + > vm_normal_page(), just like we do in pagemap_hugetlb_range(). That is fine because vm_normal_page() tries to be clever about mappings which hugetlb does not support, right? > > No functional change intended. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs