From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F941CD1288 for ; Wed, 3 Apr 2024 04:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0177A6B0087; Wed, 3 Apr 2024 00:53:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F08C96B0088; Wed, 3 Apr 2024 00:53:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD0436B0089; Wed, 3 Apr 2024 00:53:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C3D7C6B0087 for ; Wed, 3 Apr 2024 00:53:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 530F3120D35 for ; Wed, 3 Apr 2024 04:53:43 +0000 (UTC) X-FDA: 81967002726.27.A3CFFC5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 2F35A1C0005 for ; Wed, 3 Apr 2024 04:53:40 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BpikU07u; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xUE9M0uc; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712120021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VL+vMehon1ucfZkVFxJoj7s+kr51xM1FuURqwsVilN4=; b=x92jIUIP3sNg1hvn0zZ7rrU+LkMY12YVPy6cf1ZtSrh7D07JH3xdx0W3Oxcqgh05jo6CNl g5Y60owJrSK5bfp26hYPcvbTJRtQaowUnRXppUzqOXZbvShLWVt0AGnNmqwKCfCIwbiXuJ Mx1hCgepzWgF5r+ks5aGERjIZ23MTjQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BpikU07u; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xUE9M0uc; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712120021; a=rsa-sha256; cv=none; b=lqK+A+xbcR0ftJK3WUQGZxrMf/eNfrySURFmSNrDPi8gUbx2calQs3qH4bT4jlXHs0nWoT HxeshiG7TCjH5GJVxmsDKcryBN5TQNYFMwNGNXLd02BH+g+AbBXGkRd/wZZu0uaA4lRcvD aeFnw5BcfjJgHpL17kL3+UeRwmJHv5Q= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4DE595C7E1; Wed, 3 Apr 2024 04:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712120019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VL+vMehon1ucfZkVFxJoj7s+kr51xM1FuURqwsVilN4=; b=BpikU07us60g1VJ1MZdjyQT8/T1vmmSPygqzElphqCzyulc6z4OgToKlYyoMSMvVzzsDoz gief9qMIY4yTrcQfOTjEO/pxtg/i1zH/AQvhInPK3V9sDWVtsf/HF3NOxb5du0/p8PXiaR b/BKehvnQdDEiNRVlO8Eht2ykMo/eTY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712120019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VL+vMehon1ucfZkVFxJoj7s+kr51xM1FuURqwsVilN4=; b=xUE9M0ucAO/JhdK37j6aBWC/L9iojtdlUb/4mWLXAgCTeE7W5Wk2XkTKf2GiXmLsvE29Xb K0z69MMPgdD6S7Dw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 047A713357; Wed, 3 Apr 2024 04:53:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id 7IXAOdLgDGaHaAAAn2gu4w (envelope-from ); Wed, 03 Apr 2024 04:53:38 +0000 Date: Wed, 3 Apr 2024 06:55:04 +0200 From: Oscar Salvador To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Muchun Song Subject: Re: [PATCH] hugetlb: Convert alloc_buddy_hugetlb_folio to use a folio Message-ID: References: <20240402200656.913841-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402200656.913841-1-willy@infradead.org> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2F35A1C0005 X-Stat-Signature: by8c6y8ef8ibq179hjasgbxz9n9sug7b X-HE-Tag: 1712120020-157447 X-HE-Meta: U2FsdGVkX1+28kPAf4E3edZkQjPl83oDBivQrmYHFkgu0zvHMnJY0Ra1uY61w5oN93ouleyNaGGMrsX9brRwET4dYsuzNzU1Q+63d2O5K2ZThRZtGDUyZOnGdB5yMe4jnH54nXrIo0kx5QJh3hY/nnHLl6HKzr9kbd8MdfkqSVmVk0VNDG30aevMH6LSghub5isJ52ExrnZatpPDSmgTtiViccrBzeTTrqQGjjOQDLmkrg5BTVzldfQs2BNo+WG6ZXGlcvVgH4iIDAc7lV3yxIMQinivNf7HIRnMqlrfpLvRsp7vRFpnW8Jo55A/MP0R6kcxlLxW+Q9THiHl6aj4ODFBr94Ia6Gs2PQ39HhD0+8sHYm2aVI+3hxXuoNGI4RQgdPGLyIIrsbPAIegOoI0JyfUk4Si+0SdPEQg/Lri7Pi9NX+plYd0i20/GhpeeURLHgiQjwbrvOopUsE9+qjn4hpFiclyxRQqUgcTmYOeHukTHvZDmsB9+PiiOovngEAKLgISYCwiA4WqYAkzCCTNU4kDenoel242+bd5gDFmtj/JXUMzicdezD8/4SvW162JjlOcI9xi4/l5Nmejb3SBjr71FeNcsmKbXQpvCszV3kCNxfAEUq0JqwlXy4ImD4qjTFeKBh0m1tECkgG3DVaiBkjsZ9RjgZKNZsPBOeRqyvmAkAOmmvvsQwC3sdKIP7XnXM2UZG9ya2DLFhvykokw43e7MUKcJPx7yjBNk3NGHvV+3nmImDuGG9lLUavGL817yeTQdHiQCgxDexiiR5tWYI9ATaNYxfVubEsjwv1lm6NDIgSSUZ/KOP8Jds8Xcuc3HwFdhOx5WMSYBZ3hQ018RkZUt439jerRfoaNmmjEmiotx2jWdPELPSlIcjhde/KjIZVRReRXz7XDx0OhXB0Liyg3Bo1JpE57177p42HN7kU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 02, 2024 at 09:06:54PM +0100, Matthew Wilcox (Oracle) wrote: > While this function returned a folio, it was still using __alloc_pages() > and __free_pages(). Use __folio_alloc() and put_folio() instead. This > actually removes a call to compound_head(), but more importantly, it > prepares us for the move to memdescs. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Oscar Salvador > - page = __alloc_pages(gfp_mask, order, nid, nmask); > + folio = __folio_alloc(gfp_mask, order, nid, nmask); > > - /* Freeze head page */ > - if (page && !page_ref_freeze(page, 1)) { > - __free_pages(page, order); > + if (folio && !folio_ref_freeze(folio, 1)) { > + folio_put(folio); This made me look again at the problem we had in the past with speculative refcount vs hugetlb pages, and made me think whether there are any more users trying to defeat speculative refcounts this way. It was discussed some time ago that maybe all pages returned from the buddy allocator should have its refcount frozen, to avoid this. -- Oscar Salvador SUSE Labs