From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54238CD1284 for ; Tue, 2 Apr 2024 08:33:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEC916B0095; Tue, 2 Apr 2024 04:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D76A96B0098; Tue, 2 Apr 2024 04:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C169C6B0099; Tue, 2 Apr 2024 04:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9DDE26B0095 for ; Tue, 2 Apr 2024 04:33:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28346120A6E for ; Tue, 2 Apr 2024 08:33:45 +0000 (UTC) X-FDA: 81963928410.20.35EF211 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 87EC8C0004 for ; Tue, 2 Apr 2024 08:33:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="mgzW37/X"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712046823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b2g4zIhFBYfpUGirG3+bMsb8DTL3f94MBblTKnrt6Ss=; b=8O8zpMxPgk0Wk3ABjwf+8zelwHomvRKMEIUsH8bvS739GmQC/squ/nDBwnuHpII2I6AvGo 1sh9Zshl2nUNP4lVd1MrryWwIT2KNsQCZmiCmPOv4GyjG1yru/C0vAf6NnBBcBvJoZXcUT vNR4Nk6t4yHaOlSjOo/nFxLPqphWtM4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="mgzW37/X"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712046823; a=rsa-sha256; cv=none; b=Ktnmd6uhDcgRuqfGkftvHBHXOxg+3eYJmfSXZZDxptL8xTajCuPPRmpJMtvFKh+5RYQiEz Rh4NinKLtMcG6Ce3B0d9c8PMol3L4KDekVsUrwHfeCMfnaai/OfSUH5H1KMWiZOzlfWqa4 o8ro9pTVDWq87S/npXBn2xj/+XYkMk8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B7E5060F89; Tue, 2 Apr 2024 08:33:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4191EC433C7; Tue, 2 Apr 2024 08:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712046822; bh=Zaa8nEexlPhvRa5ofzkzWt1CyS6X+MgFQprpmS6NCDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mgzW37/X91k+qjYEBMZWblM0DU6bCl1ePBJ1zSkgQNd16afRkHKltQ6q8RXnbGBWi CwQ7+M6wHIlIiXLGO6ORmL1fLItY5D45zBtUUkNwEBFA3qYWkfGQP2Z8T7BULoGMg/ 5N5Y/toqnfVVC0N+G0zyreQKAb+cWCLi1dQOLdA4ihK5UvU/l+ChAanpqIniOZGuAe dFo8TvagJsO90kv/CXm3n2b41lnOXqPVLSIb6loVL0iZojonI5aXWOzeI+bGJUI11V Tq3bFrPZG/kTu12208x7LEVnPtBrBdwY7UfgnG4F+RWG2mnZupt48nUIEHX1UmjF5j XtDeBmJo1ph7w== Date: Tue, 2 Apr 2024 11:32:59 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@suse.de Subject: Re: [PATCH 2/7] mm/init: remove the unnecessary special treatment for memory-less node Message-ID: References: <20240326061134.1055295-1-bhe@redhat.com> <20240326061134.1055295-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326061134.1055295-3-bhe@redhat.com> X-Rspamd-Queue-Id: 87EC8C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zyryxj9k5odhxu4i4ox9638n8oft7t4n X-HE-Tag: 1712046823-422263 X-HE-Meta: U2FsdGVkX19gdVsr+eeWYT8gv2u4UvFtCXADXy3Gmcrxv+sVhJYwem6WkyHyoOM4fHWvwS/gdLHejl2EFKNDcwlL+vlZD5Iv5gh7VjImec8vI8wFHwJJqC9QzeX7GjWazcdkKbkRXpfmCIyO65fd8aaptghAGdYHVlM48Uru8BpaCcKDbt6Z7Zj6+5jg1GThm2L6b/KgyiXyXsmwQ3HCQiikagx/X74Ammxhh1Hs8mMhCORIaAaVABF5kQI9zcRrOi4Qx28g1nJMdETEJ7fdCZ+cmZGuaR6xtFf8SWk61/na7PGuIL0UaBhcw+XSLDbFK6tGQir9ogfBU0Zb598zrOsVgq0KVYDN/xS0wpTkvKSS5zXEPNvz7cm0ZGHoYw9etCU12OOUaOShW1OOkZzxuE4v8Rrqnne0D3C5jeMw5zKvcXoow9jtNk42W8nSnWNjUJdvg8ZpQ98McKkpdyhTe7fZD45HWIl8jI2myShtKG+46my6WhcQ8C2/zz5MDrDXV72te8zJejZAdAMRABYFaHNEQ3Pyfp7Lwt6tGsoQX12Oo6IYu+8ivkUn+jIRPAiKbrrUt5t7hAO5cSsiM5YXMxU9qwmtTbhDTPNwp3rRPWtK/qJpa468NXxRAapazvtgnlnj3Sfu2UAfGsABtKDdRyPsrlnA4Om13h17Y9Dkd858NTBRCyaPJ7D+k35lSNtTzJ2aOOXAf8RzdW/9TdUmGTOjbs7mkLWvy0s7UXOycX6mZ2pvfpkdzBcqE8njj/Y25J03d1XwFNZSxleKRuzyirAUw5zikWWflRzhpIAYlFv1ANRqRfoUHuYg6ZfqxU6SHagkJykFSX9/ho7dE785L1kqxGOgTxI1yS3DE+Y38S3I3lYEYfjSIJ7jMXRTr5xL2L5VY4pY3h7iGMO9oyQ13pP+URQ9C58shw0wAN4Pn1xmsa9yO251Fp6GukbbVo+mYurpjtzg+UwWeTCbDpl QmT6Zmo9 IJQfa74qxQGFsptAQLulCZRU7V4lbtB+D0GiIqrKdII8EtEmnWGk7i3yQpclELDJl7rqMFWvcsB5OEsdCE7Mn41VFuhNj4769Coadz20wTh8WBAVO7VkGAdz04XBcWmHFalv3XFQQtiz1lr0qBoAZZC6+mYJPoT5Dq0SbHHB9b8UOK7L9aUCBwTsHVjKpg6ggrVJoKx/ip+kPaUwfN7DojxhWTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 02:11:28PM +0800, Baoquan He wrote: > Because memory-less node's ->node_present_pages and its > zone's ->present_pages are all 0, the judgement before calling > node_set_state() to set N_MEMORY, N_HIGH_MEMORY, N_NORMAL_MEMORY for > node is enough to skip memory-less node. The 'continue;' statement > inside for_each_node() loop of free_area_init() is gilding the lily. > > Here, remove the special handling to make memory-less node share the > same code flow as normal node. And the code comment above the 'continue' > statement is not needed either. > > Signed-off-by: Baoquan He > --- > mm/mm_init.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 089dc60159e9..99681ffb9091 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1834,28 +1834,16 @@ void __init free_area_init(unsigned long *max_zone_pfn) > panic("Cannot allocate %zuB for node %d.\n", > sizeof(*pgdat), nid); > arch_refresh_nodedata(nid, pgdat); > - free_area_init_node(nid); > - > - /* > - * We do not want to confuse userspace by sysfs > - * files/directories for node without any memory > - * attached to it, so this node is not marked as > - * N_MEMORY and not marked online so that no sysfs > - * hierarchy will be created via register_one_node for > - * it. The pgdat will get fully initialized by > - * hotadd_init_pgdat() when memory is hotplugged into > - * this node. > - */ I think this comment is still valuable. Maybe rephrase it a bit and move it before 'if (pgdat->node_present_pages)'? > - continue; > } > > pgdat = NODE_DATA(nid); > free_area_init_node(nid); > > /* Any memory on that node */ > - if (pgdat->node_present_pages) > + if (pgdat->node_present_pages) { > node_set_state(nid, N_MEMORY); > - check_for_memory(pgdat); > + check_for_memory(pgdat); > + } > } > > calc_nr_kernel_pages(); > -- > 2.41.0 > -- Sincerely yours, Mike.