From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDA0C6FD1F for ; Tue, 2 Apr 2024 08:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2782A6B0089; Tue, 2 Apr 2024 04:30:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 228C76B008C; Tue, 2 Apr 2024 04:30:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 117506B0092; Tue, 2 Apr 2024 04:30:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E7A516B0089 for ; Tue, 2 Apr 2024 04:30:48 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A97EF1A0A3E for ; Tue, 2 Apr 2024 08:30:48 +0000 (UTC) X-FDA: 81963920976.24.2A1EE31 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 0B5CD180016 for ; Tue, 2 Apr 2024 08:30:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hVINm6rf; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712046647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzoIRkNfuvx4aw33C4UYQS6BZDq5J/kXY+I1JOWGAC0=; b=LyrULUExIE4kPj3cuAWJsg0sdptnTLW40clr8j2r+xkuBhwlKjElb3d4ycDtYqndMNZ9/h /Yg0DjJ20QDOfJwK0xpHjvWOfHNXP8dz6UH7eSoZF9UgyAw7TdThTgETCVLbzfrJRIisOo g/C94jRS4txqxmghhzIn3msSIdm9iQ0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hVINm6rf; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712046647; a=rsa-sha256; cv=none; b=QijtgCCc0v/osTIbhgSC4ZamdmVx2Z7H2Yb9Dloe38H9XEpkFcJYDDN9UeypTjTGe8KieS sxWME3/3BRV/E8cC4+rd5/dI142Ug0mC+RSnLtAGX5y+RqpETswsl/n/UWbY43vXKwglyP uFhgli3yepc8pHzV0+cm1FHGuzXTPT4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E8FB860F3A; Tue, 2 Apr 2024 08:30:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AF6C433C7; Tue, 2 Apr 2024 08:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712046645; bh=tKyHyDaQZrZsPjtF6RSD94Olq7FxrQsYk0x3Nt1WLLI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hVINm6rftnrbQVj9cxx3ehaDas1GFbMPJDtUe8sejK/w6bhAB1Vza5VJbMwyWlkp0 jLydglaIwyIzglHgFeqABvM0vOUWLIDgx/yLTmWeu6PT4zq1AIICJX81fZ+BJDVcH4 w5KktqjTxHO6D7xC0a3aCKdZx/VX+WF3+co2tS7nmXCrqLop37B+12z8amU7q/aTNY Poh1q9DXK/TvjOGcROvCS4JXM6Jh5bMeqLGe+L8/cEbvdOBiAbq4qmebRGjHDkdkK7 s8k1Ukh7NB82c/pppGIgiwY1aUeA9b1CSSw2B3d/P/GmbJt8dbCh7l6J92zDRjY4cG fM4JFehCula1g== Date: Tue, 2 Apr 2024 11:30:02 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@suse.de Subject: Re: [PATCH 5/7] mm/mm_init.c: remove the outdated code comment above deferred_grow_zone() Message-ID: References: <20240326061134.1055295-1-bhe@redhat.com> <20240326061134.1055295-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326061134.1055295-6-bhe@redhat.com> X-Rspamd-Queue-Id: 0B5CD180016 X-Rspam-User: X-Stat-Signature: 3tpe6uqxwzst8qbadtkn84kjquh9u8m8 X-Rspamd-Server: rspam01 X-HE-Tag: 1712046646-181974 X-HE-Meta: U2FsdGVkX1+O064zIOIkGL25P14re6NL5QTFVhY5u/70dXzi8LT/J3WtGxKhLdVQXGaT6s6cLC6QfHARxZ1b4FYdHZojgruu/qgcVOxnV8ZhK4xm0vMO61Iyf+6MJ3rZlXkcdAJh1OjIU7YJk7DBDy82Ya3Z8OjgHPFYH+oC1kfvNvIrl2HH1cKiUcXbktHRG4auQ5VgR1DWXSafA5lAFVjUSYhIePzsvWYkI9DoTv7I9LRO5+1mvjNKiHLB9MsR2c34k96lcWiGTM5vFLvlHFAnrcVrjEpbUntFjkeCErGHOMEljRqmwJoBEWYy7/nKK7nijRpWeHqEJGafspm/V1GM2hPPQdT336X+41sAvENxpFRpcexUx1blZSN8DAASD8OmG2AhwWOXpOvKUAHOA+Do9W3w8I2RHSOdxhuKIY85m49ADGnVtSwlDIOOI7PcSQFle75E8/7JvbZdMRM677lmfa17jaqz9CT2U/k/bkYjylpKHjTAZRtHgVD7VCz3HsyduM4FaVAwVzX2ubZU6X6XHEMXLki9w29zRTMZ79KkitF2IfUBiLtngIGgwk3/+YZSZQoBS8ACQGaLWKoRaERoTQxX0VUNWomb5Jzj/LVDdN+GbAW3Lk47WSi76TElcDT93eta3hWvtl3/wRuAaS5Neyzl6IUH13rcS9At8AfQTDfs8tRbJR7j7j5B56i/Vh3IQzD5RDw2blDjlGad6p5S1NtxR5pMFulmXEtzOmkjXwBXsuQMB8YNg9rVtGUJ9phG9ijzluaLhDSkkr2pmqLLpwSopiPfx6Y3fsUgZo7WZ9OjnzyhnYCn3g6MoCKOanLjKu31bjoWvjPEnbgkAzHkAKQMW1YVM8O+I9OiE9WFmD07Ttk4HaKLzvQkk4ckOKEgrYmvRHiwiHlRRtQvBRpZkO2fXCMVTRhY+V/jc1jZTvO0fGXZfFuE+xHg1zWCrqDB/uE42625kQp8I4m uofcXMpl kV7dbKHp09P2GBOEzSuRVA86cqzsjcNLY4MKDE3/9bS5wnsWfgy5TLIW9x2/NnIXf5sN0PZ4THnoYVoMv8L7MX7JeqEGgQaGvgXLYUOfeuof1C9Jh3u/W4kd4kakrBnYf+Yze+3nOfa0RTukfcgd/xlvf7hJ1aFd/accFpH0Bpp2XKKIz4p4hXdY0p48zxtrJ924HpDYLitDhFHQDrF9OmLrkFQ1EJy3uUUKSTPsdhNTzeltu1YaDv8duK9btai1hq8Bg6Cu+MDiin+xZPlFovnBGq44vJYk6G8ZlSsPwTFfwf4siVW+Z/HE3j2fWidhXlSjC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 02:11:31PM +0800, Baoquan He wrote: > The noinline attribute has been taken off in commit 9420f89db2dd ("mm: > move most of core MM initialization to mm/mm_init.c"). So remove the > unneeded code comment above deferred_grow_zone(). > > And also remove the unneeded bracket in deferred_init_pages(). > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index cbdb49cdd2ce..cc24e7958c0c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2006,7 +2006,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, > __init_single_page(page, pfn, zid, nid); > nr_pages++; > } > - return (nr_pages); > + return nr_pages; > } > > /* > @@ -2208,10 +2208,6 @@ static int __init deferred_init_memmap(void *data) > * Return true when zone was grown, otherwise return false. We return true even > * when we grow less than requested, to let the caller decide if there are > * enough pages to satisfy the allocation. > - * > - * Note: We use noinline because this function is needed only during boot, and > - * it is called from a __ref function _deferred_grow_zone. This way we are > - * making sure that it is not inlined into permanent text section. > */ > bool __init deferred_grow_zone(struct zone *zone, unsigned int order) > { > -- > 2.41.0 > -- Sincerely yours, Mike.