From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F26C6FD1F for ; Tue, 2 Apr 2024 08:00:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69F2B6B0088; Tue, 2 Apr 2024 04:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601B66B0089; Tue, 2 Apr 2024 04:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CA136B008A; Tue, 2 Apr 2024 04:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2E2416B0088 for ; Tue, 2 Apr 2024 04:00:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9F13120A42 for ; Tue, 2 Apr 2024 08:00:01 +0000 (UTC) X-FDA: 81963843402.17.5B687E0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 7A69A14001C for ; Tue, 2 Apr 2024 07:59:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="xbxCM2x/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="X3Q3/owZ"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712044799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RP9RLjMVbq6a75Dz/QpdRnh/IGmkM/3rb1FTFURpAMo=; b=B/32UlNLFfFrUMq6SJhaZeGYdD/FvIBNBc46kAgexUJnpfqGfSTszn1mI25xBjwk5GJgz0 RDXX/Lp85fRh/9Fs7gnTIZ4TyK9N2dzMx49XxBfEMxK2+HW7zyyRtwKCqz2yxQkaoNxBW6 gGE2G/OaYcrsPkILCmxbiGDUbG/PEQE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="xbxCM2x/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="X3Q3/owZ"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712044799; a=rsa-sha256; cv=none; b=YNsXzQWkcgfrRZffFPJd5e32avnL9h1UcUy4pgzQ1SPP+wyAKRhsrC47NJQtEvrnXpJdkN 4ie2/DX2b5xIrchLADZn4SDAKuyIVGINunNWXq9tHnBIA0QP10OPFswRw0FMyhuU0b/N4F oyU6yJbG8YQLLz6m5ClgpafHJVGTPFI= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A72DC34425; Tue, 2 Apr 2024 07:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712044797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RP9RLjMVbq6a75Dz/QpdRnh/IGmkM/3rb1FTFURpAMo=; b=xbxCM2x/bJD4HdWoiZb1cKC8CAA9RQNPT8nVdiN8EfX+4JSQNpjWyVnlB50FLRwQPraGOq LH7i7LdfyNmTnCSxxXnk47cnjsAHmUEBTTpw4/VNeP1NlzJNs+1P5ujPp+dvdxwg8Zy3Gg 6q8y3Tkx3pivB8i5U9/CQfMJkXV4M7A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712044797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RP9RLjMVbq6a75Dz/QpdRnh/IGmkM/3rb1FTFURpAMo=; b=X3Q3/owZH0O5AM0hWchtsbxVchJJno1eRfpFd6zLInlSx987+9m8H7gfyqM1R1Wqwy9ARg igIWi+3SP3yL5eDQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 1609613A90; Tue, 2 Apr 2024 07:59:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id mQGoAv26C2YiWwAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 07:59:57 +0000 Date: Tue, 2 Apr 2024 10:01:22 +0200 From: Oscar Salvador To: Peter Collingbourne Cc: Andrey Konovalov , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Alexander Potapenko , Omar Sandoval Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1 Message-ID: References: <20240402001500.53533-1-pcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402001500.53533-1-pcc@google.com> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 8ejs4w6frspb1ayik6a8t8ogs76sxjwg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A69A14001C X-HE-Tag: 1712044799-119076 X-HE-Meta: U2FsdGVkX18GRptw35VIg6mtiTvXGr0VV5rNx8DhXCWnpXpNrbkmOzhmk+DGlv9LeAe8Gkp70TQoAoaA/aE2u6sud1iWwquPGbGb7aym8NFUXH/Z1seyyd4/qUxl1CC0RgwsrTyD9N0ohvak7ozky2Mq3hnv3wy6pIqlS/k5gdzAE+iWiqQ4n55TyhnDheONNrYFl8JvXfJwNinmzP+bnmhnzFu6Okz3D0k3wXxPV8UHmBpCRc2ZVxLQr7NZxTsu8lre2aF3W/oizwg2phr8cRrXOdAQ7YO7E1lqdjgq2j1I68961nNkEps7VK3sRcgophdMuZAYasJshNNchYNjymkDIJnKHl6PfczOyytJdoRc4JpzDleJVsbFLNdym7+CnFX16hVlHGZxyXroiGtQ9gCoVpm3dqmHF7hFofgYhdfBgParwGio9U8MrFBtclIq8U4aCWz01gAC6K/bsWmFaFG3jiKoygF/5KnWHqc3ZwbobVkCvFVyCWfpHeUQn6rxT8iBqajfnOTLXRhCV0lJygWgRp2jMhx8Q1TubZvKFoKBljJ3BrG1C3KSjxAoWOJcLWjgWkZAOIn8JF6tu2MynNiHuzI8778w1zz7rg+Sc6CaxoD/gzW6Dl05cfj355NzYkZSYpv1xojmBNMpnaZBHSqCzt/ylvbI1aXmubYlPGFZy5HK8OKLcW59FEeXhtubNvyL618EPxB4j35D+yiRSTCIWHtAYSIm+ecaEx/95tm9hVWXjLlwGuevqRhvS8R8i7uNmfNwqdylbBMYjFqL7NRICLuUfGJDzJ9qg+5QqHV6pBybkqbALV85fbgKW6yM2hJu1gV37kLw0bT1JC22dtgyYkLWPMK4H5iz3kePAsPoCPCwOycSQMxznXhCNFIx3TpcunL1Nc7vtl7UCkh8AbeaC0CLDGvMEvTxFfImWCBqTlAo33Z3N4pCgZlWTekehpS5Y+FT3S9Th7qXTbE 6LIWlaCr wUBHgOvGvBLUqQG5sw0ucv3rRjuZr/ws+V6ZKMpT1o+jcv9AcHFzrSdivCax7/FDVzolmG8PO1QCErrXRpwMujTCwCxK1AK9o5GJ0QwjIbglCu8NV8/Cu/OTovGYVeZnDr0+ReXPqzzqVXnq4evrZJNNL+Ejl8uQqNpypS6n/b3PZe1G94REIbHO51n6aK/l+OnHeOaLiBif+aQu/NQuFA4c0uiCEY4JTmXXsmT/CYAK2JGvLuJZmOS+VVO2IgYQwtObBl1C7AFwiSlae331rqzNd6pb8WrB/1GJXz9v65bXIzun+kkSD9UvVxP9uUEAC6rx6cOFIxdv5u0Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 01, 2024 at 05:14:58PM -0700, Peter Collingbourne wrote: > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a > 0-handle") changed the meaning of the pool_index field to mean "the > pool index plus 1". This made the code accessing this field less > self-documenting, as well as causing debuggers such as drgn to not > be able to easily remain compatible with both old and new kernels, > because they typically do that by testing for presence of the new > field. Because stackdepot is a debugging tool, we should make sure > that it is debugger friendly. Therefore, give the field a different > name to improve readability as well as enabling debugger backwards > compatibility. > > Signed-off-by: Peter Collingbourne > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc22649b33e768b9f88 Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs