From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A205FCD128A for ; Tue, 2 Apr 2024 00:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7E26B0093; Mon, 1 Apr 2024 20:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 158AF6B0095; Mon, 1 Apr 2024 20:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0464D6B0098; Mon, 1 Apr 2024 20:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB87F6B0093 for ; Mon, 1 Apr 2024 20:34:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6565DA0B1A for ; Tue, 2 Apr 2024 00:34:17 +0000 (UTC) X-FDA: 81962720154.03.7B6CA96 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 1CABA4000D for ; Tue, 2 Apr 2024 00:34:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=enPGhwQb; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712018055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2VP4oPUjG7+cTRXLUPxAk6kKBT7PPaJfZQ6oyGi5qls=; b=A/uzKEK0815iGgnkB3tL8L/jQtShvTaJHuOySB6a3kDgr0fZ8wf33WAUtP/KR6EAy+RwHr qK7LjnT25fxAcWBoSQTaMXU3stl4E90vcWJRd5/EamAWhoo42mbDw72u2M7Od5J754JInM XZGUSZKc7ldskVcxR9260Gsf8APOqZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712018055; a=rsa-sha256; cv=none; b=lstJCeMyWsU5obrB0KWUw6HI4/Na0s7Efeowaa5eLXM0q0fn1F/LsaihXu/IcKAiHDTecp fwolZ0riR4CiQ2N2Bk8PzAIVK3l162mHOewZDAe4CIl7zSAbYYo2XrQY0hPg1W/BovbVcB /OPcvsRLGLGK341EYlWuFivsR3e8Mt4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=enPGhwQb; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2VP4oPUjG7+cTRXLUPxAk6kKBT7PPaJfZQ6oyGi5qls=; b=enPGhwQbk1NobKHJ5OrJH/ZeuY vCIcgJe0U0JiI91g+EeRXANEEO5IWX0j8FEELDZqpedtUjX2wL55gDQNiQz8uUaKkUNA2jxxg2DV6 PR7JvfK0wPKH0upfsj9NmAokcEyKAjYOCayfXB8bSPH4rwygODWkchxKJfHu3/LjQmBd7TmaIh9CA 7s+iybS/wOEMSbQIlr/+O6dadY7CW8IRk5k3zEBi5TPfx97qkzqtcz8hzaMxgBIUzW+YrKsBhmjiZ Y4FT707TIcGLlPU8Zs4OCZAawNlhJZqldabxF8MP3d4tb8QJTE2mYI3nqwxQ8OftbtjncQfW9Zmga 9vW0vdYA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrS6I-00000001nlc-3ixt; Tue, 02 Apr 2024 00:34:06 +0000 Date: Tue, 2 Apr 2024 01:34:06 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , NeilBrown , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, Christoph Hellwig Subject: Re: [PATCHv2 1/1] mm: fix unproperly folio_put by changing API in read_pages Message-ID: References: <20240401081734.1433755-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401081734.1433755-1-zhaoyang.huang@unisoc.com> X-Stat-Signature: ig9smt7a1135mw8h3czecjfncm7mgijw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1CABA4000D X-Rspam-User: X-HE-Tag: 1712018053-975689 X-HE-Meta: U2FsdGVkX1+1avMLQdHCrGiklF+V/BKmDUyguVWUFLMx10NOIq/JXwce4vkco+W3BNwgXxgFAtQTHc8goblGl8yFnJlFUSmTOaL1Aq9WWouPaeVDPrfL+Lk6CBFEwuKtV+naYFoUWXara8tovP/8gmtNUhgKats8pT2FxDEgF5JOci3uKuLEJzOKcegI1HAdEZ3nZVI3eTy8SIHg6OfbI1j8H8YYD9jUB4KAx4sckGTxyuBI+sLU1dhCkZTPlJuOYIl1dIzqY43nmXCoriu3Ah77/a4svHckkW2HBeYT6WjRovFvNr3Qo1dVd5WOjqPP5Bxmw8giBIWDKdkshrFYAe7/r/oiKp9LPzqaMNDqSjrPPuqcoTDTRLTLSQWUC7bVsL4ERpsgb+GIGYmsrPDWY6Xmpt0IIOiKrf1EUH3y+ooxPFQDIpvu3Sr3g2jxYP/cj0Da11Wef6Gyzl0YeBViMl3RNJoQgLCJGXhgMXDe6WSly9CIFP8HoLJTXzN7wRR+/hg1koVJqkzKVcwm48sSQsoNmuSKus+sygbQOzqs0hJ993+eW+zqvvUTFKOEkplBuhFqDD2uTEppSoo/v+hV0hLPepkjlmGYryidfoj12g4r5O42mT6DP5b7qE+LWbW6ll5fwRbYzvRfTFZzHaOIRbpEAGxj3KQqqvWCgr2efptM+Q+9ifjwEOyAdUTcMqnn23pEOIQh0UC/yT53PqCiGYgKZxKe0hUFZTU22sVGANoHud4lnSNd7sCSvLSA2NQLFw4z8NoOj/r4Iu83LB640FpwM5+5+D5Ac1w9Eterapx/vfqeRYpL19b80qqbPJFUiOLY5/hyCb7OtJCeJbNYGDRVp3/oTCeh6JegxRgey8JAHM4S3zENTI4CXRdXMAIW5gSgP2s2p18O149x3b/iQbinG3hlSfbjp9kqP+M36Lx3VGYCoEMsOfBebu0T89YejerP0PBDlAPa3iy9wVX YdUNFWoq 8dQg7UqaIb/xCbWzHTMHaq2zel3CCeRU8uSHsSN9xiw/+0bXK4CePRe5CptbNcXs4ncMpsYTz/4BTdDXPW3mUs7QjtO5hWuWKbjrnW+zeJjE87FW2XsKZHxl7Y15GdL7iUJ8HEv4vYN9Ect5nQVlHEwPoWAm0DXXb7Ukr+CRE4nRrU97Ol85JcCg8Kp03XFPP/KNh6wERXZWTGSRgfXh+nX86NIQdtZ+S114ERVOa8IP3ZM6PQfUtS2N5cR/dT0UP5LJBPRorVOlH9sbAWHqxAguxTPNKnxgaaHcF9zhFru5nNnrYRr+qt+sXAK+Lrxw2uvSUuNvYp176YuVgCba4A+GpEJM+tw94gwlYxw3uIIVKO/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 01, 2024 at 04:17:34PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > An VM_BUG_ON in step 9 of [1] could happen as the refcnt is dropped > unproperly during the procedure of read_pages()->readahead_folio->folio_put. > This is introduced by commit 9fd472af84ab ("mm: improve cleanup when > ->readpages doesn't process all pages")'. This patch is no less bullshit than the last time you posted it. I explained why here: https://lore.kernel.org/linux-mm/ZgQRtQ60mrvOUKXo@casper.infradead.org/