From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B02C6FD1F for ; Fri, 29 Mar 2024 12:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4A376B0088; Fri, 29 Mar 2024 08:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF9D16B0089; Fri, 29 Mar 2024 08:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE8026B008A; Fri, 29 Mar 2024 08:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A666C6B0088 for ; Fri, 29 Mar 2024 08:26:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 169CC120C2E for ; Fri, 29 Mar 2024 12:26:51 +0000 (UTC) X-FDA: 81950000622.13.7F9F1D9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 69E1D140005 for ; Fri, 29 Mar 2024 12:26:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d1xEhmSz; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711715209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZKa+ASXdo1cZjsSafEP2q+atVyr7ARDRo2pQvhN/Kj0=; b=wINhiCgvihYwTuL7YEVC5s2oTzhqq6k8xyqu73o8iMytRmVTyhoGc4WWdQMJf2JPcSbdB7 yN+7it4Sjnc+h9XsA3ryS7xCC0IAYgtDEopcP7bVQGgu1spvj3Y9BdM43rfKCGE2ety2yB o3aWU08cF7wCgb5WKRYPJRS3ZVfxazQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711715209; a=rsa-sha256; cv=none; b=btZRkBOeUZ5GPjOu5JBmw6oxbaXdu/3hTti3apTr25eGb5shB9E+RbX4dHmuRjWrKsQF24 9mRgWPOA2M/eraTfWkRHuZvJ/t1h83H9x8Yz/skU4I3QouQPDhe/qb6FaEFhY1b5Vb2s5Q VhuZWalovV311C9AW9TLfEkxZVwCRKE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d1xEhmSz; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZKa+ASXdo1cZjsSafEP2q+atVyr7ARDRo2pQvhN/Kj0=; b=d1xEhmSzYPQMlBB7Oof3HhACB1 spkoUuyRBhnjM9/BbRPGJTaLRqMwsVxf7ZBMADJaQWAswuXN8klCNAAIx/Tv95NQuPg+4danNJMpB RZwqBdDFTJDJLE++WqaP+SDSGHiuIQjuDSWnjfqqsY9J5Jd28vVoiU0xXM3DR5w+dOYMFls6j5rLk 1AswbXOAxluDebsTh2TxgAdgRPWCq4YYMAe2iaxTuZYBiS7TqZFr8ayWqntIc6mjhstgH6aQpnbJT cnqQfJuHv4K6uc9nCRG8zsXe6MnTR61rMEJOAJ+7Zz1zVJcpRyGEBhotZ92kIf0e4Mv0mNUMCHwoY 1Z4LuMsQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBJm-00000009Ar6-1nL2; Fri, 29 Mar 2024 12:26:46 +0000 Date: Fri, 29 Mar 2024 12:26:46 +0000 From: Matthew Wilcox To: York Jasper Niebuhr Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, willy@linux.intel.com, linux-mm@kvack.org Subject: Re: [PATCH] mm: init_mlocked_on_free_v3 Message-ID: References: <20240329115446.424923-1-yjnworkstation@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240329115446.424923-1-yjnworkstation@gmail.com> X-Rspamd-Queue-Id: 69E1D140005 X-Rspam-User: X-Stat-Signature: zdtsm4tx39ku6efuoocwebhfwnuq5y1g X-Rspamd-Server: rspam03 X-HE-Tag: 1711715209-801139 X-HE-Meta: U2FsdGVkX18gAWWqhWfh4FTaktXcVUjgTCM/o0gcZUeBnDDuMtfwnCMSRivvua14A/mq5tA0jEuD3pBVXIhh0ZnSITSmBm+AVLTQ5tWDEb2qD1hYhI/Czo6JONjBAdI/itdA2v3jNd+GRt0KInnjfHAUBTVadd8rt/bzP08XeIZarc+qyKoOExIdCDTlGLzRt9gSC0C4zqN986Gc+SkIjupVABni4NkyzbmAdl3tADIvPm9CxRU0fSAolCMx3x2EmboXdasu8l4eBdZO1gLq+bOR8SI3gQxNNv1FzzRuxg/Xa0Wlmf9CLi0C1yyIypgiR2313xUn9AxtbhWFBY2/AS2NOEshSWrmIdv1MfNGuj50SA5uvfULCq9dBudSVIpYLmmM7+jNWuFaZ4Q50cwBx+8P1RQfSvNK70hjN6/iktNSLTnr/8EBYpS5xl6+XO4FpczdF+kcWrpeVnFoYJQuTW92KydkA0GR0uDIS1ryzy4LKyzdSgumd1DKKRTi1bEsE51h2L3KC6AsEQVQFVwUZwu7I95RhZT84DptzI2vS+Slp9xSt3N5kFcuMBKbd4ue4jI4c9DhXlDyILtSVOzM2+2mMeZDfKiITQKpsG17ctK1Ld4OMA6kwiSeI4Yk1BFE1GEnVeSIfBbANjhZkj/SY00gTygI2G85moev6YphyglsVQ1B8SrlaaTs2Lyx3uw+M9zUn6cgHVUEzVZuwg5JHuiwxIZKHD/wvdQSmnw4U2/S00vkGKYg/0wyfuIqm3wN9WfuhzomeC0YpvtpXcc554ew6TCdhw3vtvBlf0xhzsTrM6J6np4J1k32lvh/kEDVe+7/XPZX9BPI4R72IQIxDhIeDspJLc+r16FZ2ybCUXDEZ9Eq2ZHFq1LMczmJJhum3QZyxtSds0Lhklr6J1akm3qrpXca/DJKulCBf7YC1LiUDmqtQp9oWMxGskrIVFGnDMX6QWhjZHAIxIKTezd xy7HOJC8 5ljwysP9u0HTecqbjYF/KSIM8O8XpkleeMcZkqXhpFGZI0CJfH+B7/qqSdFKtUwJjgp30+Ocot2BYIPRkn4myDyucBphUNarQA1K+Q1SDeRI9fI9w45Xk0W5zmXC9ZwbvVB6ceTxsagKscU/FV+o7zTyUo9U8Z9fGXHfCda4WX0aKNesBpxDBhW3jaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 29, 2024 at 12:54:46PM +0100, York Jasper Niebuhr wrote: > + if (want_init_mlocked_on_free() && folio_test_mlocked(folio) > + && !delay_rmap && folio_test_anon(folio)) { > + kernel_init_pages(page, 1); Confusing indentation. One of these two options: if (want_init_mlocked_on_free() && folio_test_mlocked(folio) && !delay_rmap && folio_test_anon(folio)) { kernel_init_pages(page, 1); if (want_init_mlocked_on_free() && folio_test_mlocked(folio) && !delay_rmap && folio_test_anon(folio)) { kernel_init_pages(page, 1); Also, '1' is incorrect. Should be folio_nr_pages(folio). > @@ -2559,12 +2570,21 @@ static void __init mem_debugging_and_hardening_init(void) > } > #endif > > - if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early) && > + if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early > + || _init_mlocked_on_free_enabled_early) && > page_poisoning_requested) { Wrong indentation again. I'm not going to point these out every time, just fix it throughout.