From: Matthew Wilcox <willy@infradead.org>
To: York Jasper Niebuhr <yjnworkstation@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
willy@linux.intel.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: init_mlocked_on_free_v3
Date: Fri, 29 Mar 2024 12:26:46 +0000 [thread overview]
Message-ID: <ZgazhqoK2Icgahy9@casper.infradead.org> (raw)
In-Reply-To: <20240329115446.424923-1-yjnworkstation@gmail.com>
On Fri, Mar 29, 2024 at 12:54:46PM +0100, York Jasper Niebuhr wrote:
> + if (want_init_mlocked_on_free() && folio_test_mlocked(folio)
> + && !delay_rmap && folio_test_anon(folio)) {
> + kernel_init_pages(page, 1);
Confusing indentation. One of these two options:
if (want_init_mlocked_on_free() && folio_test_mlocked(folio) &&
!delay_rmap && folio_test_anon(folio)) {
kernel_init_pages(page, 1);
if (want_init_mlocked_on_free() && folio_test_mlocked(folio) &&
!delay_rmap && folio_test_anon(folio)) {
kernel_init_pages(page, 1);
Also, '1' is incorrect. Should be folio_nr_pages(folio).
> @@ -2559,12 +2570,21 @@ static void __init mem_debugging_and_hardening_init(void)
> }
> #endif
>
> - if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early) &&
> + if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early
> + || _init_mlocked_on_free_enabled_early) &&
> page_poisoning_requested) {
Wrong indentation again. I'm not going to point these out every time,
just fix it throughout.
next prev parent reply other threads:[~2024-03-29 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 11:54 York Jasper Niebuhr
2024-03-29 12:26 ` Matthew Wilcox [this message]
2024-03-29 14:56 York Jasper Niebuhr
2024-04-01 22:34 ` Yuanchu Xie
2024-04-02 10:43 ` David Hildenbrand
2024-06-01 14:09 ` Lance Yang
2024-06-01 15:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgazhqoK2Icgahy9@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@linux.intel.com \
--cc=yjnworkstation@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox