From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4508ACD11DD for ; Thu, 28 Mar 2024 19:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A03896B0099; Thu, 28 Mar 2024 15:32:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DEF56B009B; Thu, 28 Mar 2024 15:32:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87C026B009C; Thu, 28 Mar 2024 15:32:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 66F8F6B0099 for ; Thu, 28 Mar 2024 15:32:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E565EC0336 for ; Thu, 28 Mar 2024 19:32:01 +0000 (UTC) X-FDA: 81947443242.27.45E4656 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf18.hostedemail.com (Postfix) with ESMTP id 06B741C000C for ; Thu, 28 Mar 2024 19:31:59 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RgSooElH; spf=pass (imf18.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711654320; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JhfbUSiwIuT8LIHU0+RkNyojAQTzCsx1VSv7AHZemnA=; b=dzpgTVV/X1w40ZnSJIqq4ydZCKEzr1jkO/7Nbbke97ukkFcgeJuw2mgXwdKkcRDn92NOSf IJkY29ukrjUTqIaYOqPWLxDz3P1hy4EpkvQ8/t4IHkpHezW/AwYlkhiOqcgqHQbqmY//ex 6ztzW6kRDlO5Kbm6ug7KOvaUTJYp6vA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RgSooElH; spf=pass (imf18.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711654320; a=rsa-sha256; cv=none; b=YhPPHLdT7ASxn2KDl6BFu2qin3TVuWocF/e00GVAY/aLSyTAPTsawaUN//+aNPPPELqrmM haxK6VGUjU9gxKGzn8F7lhJOCNhPQYNXwMZJy85WXgbUt086H4+kGgItQe2zcTx3FyZohH GLiy83qW5MmvPMY3PSYZOIYE3rwikI0= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6ea838bf357so1186486b3a.0 for ; Thu, 28 Mar 2024 12:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711654319; x=1712259119; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=JhfbUSiwIuT8LIHU0+RkNyojAQTzCsx1VSv7AHZemnA=; b=RgSooElHUuMF7WqYIBb9UVWAFaqmvvSk07sRGJw28l2QQx7WkxxAT4xPZas6zKcpYB lJtbLQcIAlR2lEuIqfK86ccxI4RYPQMjb6lzhxajE0fKJNDIdsK/yZq3DnV49aFe9ohu oiO3W8g2iEhvlblj2uyfVP1OxaQvFW0Q7A0PLOi5dzYnO/qNPseddo24z3wukeidcPF3 t+ZQJPOMkSksULZqzUiH3ZTg3ZwXRiyVleHut2ao1LmaLBW+vt1YMJ5I5WWhNsGElqeH NKA4l5rqLmf7a/brTCAFCSXorG7qI/CpbSfnjnuf8HwNBtRcJsLE9Dvb07RgORRIZ0Bk 00aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711654319; x=1712259119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JhfbUSiwIuT8LIHU0+RkNyojAQTzCsx1VSv7AHZemnA=; b=K0+FoS7JGq/kS3mtaNlwInb5iKmQwRD5G6DeGkL74sNmwAp/wAd0Mjgt4qnrkWyO32 pZRSTsPEqlSFaJtnj3tg7wbx7UGmmMfSmqcwRJVpoBqKu2ULq0IsFe6xKRmVyGCsLZOG jQu3OMOGuWidAfg0HPRjVzdjQiiA+GFYIEzI1NIUXR+1mz4lfmqHEWxsO6r8le/aamej rbJT9UU1SqU8piUkCJwrCwAOKrgRT5fC31WN8E55WbS1GTpeTxF7ZKvtvwt5QSJs748T u2p9rHP1eQETWS5zf71up1wgVZBWHuqmebd0FpnwMZAm9ucEMz2gmVPLK+OZjebote2q lAXQ== X-Forwarded-Encrypted: i=1; AJvYcCW3krYoLA/ogtAQx/RXjH7JUssCGqXjDeCvc45lr5Tb+4yfPcDOcsLs1fzPzr17uVja5v936LC2c1zUmF0InsZApLg= X-Gm-Message-State: AOJu0YycpYWGhzMQlPqnKygBY0CT+0yVhax/wMbYYvBtOFpn4SqnlYEG DvxSQNp1skbmRNUbihpHkLZuWOP6Ddw+QuKXp2nMWkMl+MvVI823 X-Google-Smtp-Source: AGHT+IG2EeIzMXCjgNUYqx+aDJKclqaKpMMWrn0g/2Imx4HnSHvQRyRUTiSJPCS3IUxr/GDAtLt6gQ== X-Received: by 2002:a17:902:f54e:b0:1e0:a2cf:62f2 with SMTP id h14-20020a170902f54e00b001e0a2cf62f2mr491565plf.23.1711654318736; Thu, 28 Mar 2024 12:31:58 -0700 (PDT) Received: from localhost (dhcp-141-239-158-86.hawaiiantel.net. [141.239.158.86]) by smtp.gmail.com with ESMTPSA id i17-20020a17090332d100b001e0d88c908bsm1989805plr.281.2024.03.28.12.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 12:31:58 -0700 (PDT) Date: Thu, 28 Mar 2024 09:31:57 -1000 From: Tejun Heo To: Kent Overstreet Cc: Kemeng Shi , akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-ID: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 06B741C000C X-Rspam-User: X-Stat-Signature: 3ji8wotbo7m3tms854jdb6qefbc9a8tq X-Rspamd-Server: rspam01 X-HE-Tag: 1711654319-136227 X-HE-Meta: U2FsdGVkX1/F15iz9dtH8KcCY6845jM4mzm5IntV+1i1xMunMpOV3eI7BgnoOT4uULQwPjbE6eD44kQEsa7PZN+Q4W/CgyIpKlz59dyZjfL6FgFfTDwqOXMn7pVn2DHCM30ES/+qmqf6Re6gMYQI/HLnnk1f68BBd+qcfnReMoHrd7SukpxJ6bt6Ft42bdU0danr47Xy3AUwDuXIlzKbRuNIISGGWFdVvfKJCe/WtCPAkPAHzCvtOtq8Cae6Y+Hk62SXxpUSP6cIDJZxd8X0Of1GHNaILNziO1NbhiYMvkAQcz1JipiTIBkH6genacbefQ43vXR3pSomKAg+lVGf2Nw+LOnmKx4SgVC0/Edyyvtg2OOhLBQtXxL9QeTt5mtpdqyC9tUwZSK0vCKVbQn+kA9NCZhG3y8Bg3uEkNZ334YnGP9Z9EJPIPEiM8EHr+rMWI5vjnQ6TrlaiQBTjiAFwJirVluBytS+ZUiXdBgILuJMuWad/Z1sIbQ6liKJIrmGqHite3nagkOrKugxL8DZZ+sAMwOg369EOIvZHGXSm1uYpAX4TA/BPo2C/rNzsyZ32XEuCaIo4BvcbWZPSvrN8IB0vYhw7DvgfLac5Z/SYS8CZT8IK2fooNMgrfFmf2fqqmwwmL8bnCKL4Ak57P9WMcjVFGCieRIfbZeLozI2zP/hEsw+9jR9EPJ0lyFHF+Fw5cjJOs41q4+zdBiEg2XbpBSCQNX9IzGppr7t+Z45fkvPRm22pPeJJ8EdEpXn4R/68fedgfm+4oyVkqBaax7cRexk1J65ccQ1Ycc8Mh03F+WM6sjNjwwLQYkK+PSv1YBTSCNY+4kKx+vmidl381uBbd5apfDjPVlMzF8LszTjvbp1/+S57gO6S05u2fiPFLgzHjclncSybcXAtwjvNeQ/Z5B8R6cTLrmjzO2yyuDm8omnjJI51u2Oj7oFE4GrFGw1zbYpFRmGx+ZFpBqpv5D jQv0CVXC ERjjtcstCmimXG53zuWb6MFVoHRbtT4qI4Gn1OVmPXtJI6Ply/klDmO7HruX/Anefhk64eWshPzYEUM6wuQNxwMrnO8N6w9swplxBCz69lr90LhMKef7BjkogrKmiJq7Uf5VOhkkbri9Inj9BKND1PD9/RABFw5T4h4RoHjE57aH28kE8pRV+KhTW8961BWWC+ApBlUPvSXeNZsaNSpPDmFBph15RzZyK5mKb5rjzsPcPrFrT0kJBzBr6v5xOZAjNJyzMVJ+iQWy1rMJaNksoj8B5jpvabs9q7fy4ypWIyQ3WQ39Lq4Hy1TKIu17QHvp9TToP7SGwpO69+WhRQCCVsXxl5g/Cc+WTQ8QXkcHlZcsqwMXzjLjH8Se1tSVAaSFKZ/HKmswbIHE2vT3oT0BCFGW2/6UFG5lCHY5zakVJXMFBTaBSWuiP/PC/1r37WUtdDNL4tBjDX/8ASBRnWTzCL9kZW1wu6TAyBb6hjLnVjBpCL2O7xIoF5jUdGswGcukFepxH X-Bogosity: Ham, tests=bogofilter, spamicity=0.002700, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Kent. On Thu, Mar 28, 2024 at 03:24:35PM -0400, Kent Overstreet wrote: > fs/bcachefs/time_stats.c has some code that's going to be moving out to > lib/ at some point, after I switch it to MAD; if you could hook that up > as well to a few points we could see at a glance if there are stalls > happening in the writeback path. Using BPF (whether through bcc or bpftrace) is likely a better approach for this sort of detailed instrumentation. Fixed debug information is useful and it's also a common occurrence that they don't quite reveal the full picture of what one's trying to understand and one needs to dig a bit deeper, wider, aggregate data in a different way, or whatever. So, rather than adding more fixed infrastructure, I'd suggest adding places which can easily be instrumented using the existing tools (they are really great once you get used to them) whether that's tracepoints or just strategically placed noinline functions. Thanks. -- tejun