From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD10FC54E64 for ; Thu, 28 Mar 2024 14:46:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE4176B007B; Thu, 28 Mar 2024 10:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94916B0082; Thu, 28 Mar 2024 10:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83646B0083; Thu, 28 Mar 2024 10:46:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8BB6B6B007B for ; Thu, 28 Mar 2024 10:46:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 46EF2A112D for ; Thu, 28 Mar 2024 14:46:58 +0000 (UTC) X-FDA: 81946724916.04.C8B85EE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 6D72E120011 for ; Thu, 28 Mar 2024 14:46:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aqqNHXgS; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711637216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPAuSkYgy+MUhS8KdVZMaOcLOllCqbF/NxocVA82LN4=; b=s2bA6r5GPcrJdzSwbsqWloq3xxUPZIVtFWHmAWfheRMJk09Bkj9be6x5ktUhFAjnpaRgAL qVotKc7kgFAoxt/EpnAcYVSAuRBDrUC4aVTaPu0dt79JAqDBo7OYrFcgIvnbYz0TntnOIh J/Tk0f3IxG+A4ebkYMlcA9fVkjPDD7c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711637216; a=rsa-sha256; cv=none; b=VGYDC6IyouuFDUhz1lEGqEKyj+cJqxS73PkB50eXzDY5ScaI7F1BQMs0gVff3tVtF9BXNb ENNe3o2fRtSquzII/yRmHa0VEd8kZWoOcqC/W4xNi6n2YzzV7i0MEN/I6WALiMV7vStaw+ 54cgexhdNMZzr78VVDR7BoawhiwNUiA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aqqNHXgS; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711637215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPAuSkYgy+MUhS8KdVZMaOcLOllCqbF/NxocVA82LN4=; b=aqqNHXgS92c3BpXuG/jkXFDM2AQYtjfm4Txd1pJp1mVi29s5x1iE3+cODhAPs1Zb4kM6Gc qn9tbTYJ1LL4pUGKQGY4Y4Tq3o00AiGcJkciUnWAxKhgwM1D+7faDdAIvoCqc7aUHuLxxZ pIqhvHJPJxnxovZuNPTWEVxrDHQrtoI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-PInHT43-PY2c36tojWgsHg-1; Thu, 28 Mar 2024 10:46:50 -0400 X-MC-Unique: PInHT43-PY2c36tojWgsHg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E226801906; Thu, 28 Mar 2024 14:46:49 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FD432024517; Thu, 28 Mar 2024 14:46:48 +0000 (UTC) Date: Thu, 28 Mar 2024 22:46:39 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 4/6] mm/mm_init.c: remove meaningless calculation of zone->managed_pages in free_area_init_core() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Stat-Signature: 8mi8kgft6azfsfqtqktfn3kg3qik3hhr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6D72E120011 X-Rspam-User: X-HE-Tag: 1711637216-343186 X-HE-Meta: U2FsdGVkX18LAdjYSzQLyEhmNx7gGgSTdGzccIntgVUBiND8ty/b0tvpPxd7nntO7xaR6OYSMzaccdm3bFg9hVCounLnHCBKcb+X1T7LOLcLyTVwHEx7W4/JbubrMRWIyTcsvPxRZPGCmXE1osQTd6WBUeWTVNHGNhlvUWVspF4fKFiDbOvAFZ8YhygJQkmfv6XzT9W2b5WA0zx5kq7t1CmMBg89T9TkF3wrtgnKskU45qofHqmb1OySQsnIHzFtAjXl3qXPAAzgFQNy48SVPXWN5K7yoPbOv31UNVTm+PN5zDTgQq8MYxIMigvBrxEfBIa8tB1Dwn6w+WSaD7fFnCTh3MQQftxxW/e2jBLA+jRYgxNsy+Fe1o5M6OOUYxgCTdYPU2ZDgdINNqt+0WLFDWFlA3mn3v5dm1zPvrcOmCg9bRvvmIuamo2NgRQc3gCsFbmCwhlAo0y1+ejsT80XLnyVWC5S2fOBZ9ozNJNkRPThsOLxb2uHcKVvEZTp+E4fJC6X97wmU7JM4w3/MAtnuu9130Qas/4bpScZWz638aO110URY4EZFHpdw21cZDFZ0L51WzKMEkJT6yQeKv3gIl6b0gSqdgbXAgiRjR9cLrjaY7RQYu7/NamdKIMVbajn1D5VXzlhKwSWkBsVtHTrPv57os0PLCMa5mRhttYWM4IbpKKZGKe3E/Kd2KjbayEa+dXnx1NaONTIapidu4dWtO8V70742PHl1hwaQvRatfFyuhNWkEoycttUkzEWVX2tAwugut7U1XF56gF16QGlzcHqbd7/dgaK5ijm8CiYHyoT7lX+fQwrOpxv7OsvsREzh7vbFA9UPYuAULaMs6tx3/C7cS+Nf1Fy5hAeVL3LrUoNBGtXHYGm/pyYSryOp5YDeLk1C2MlxOTP81hCitDwsSoYaEMtNJFkaIEqFZpFSSughSpb7uxc6XJRxFVLmW76yOAs2XUoDtyMWhNe02t qLvKvE/d aK5oMLTeoa70mqcqMeDarOcN3UmCxCiJEP3CQLkeD3+HIf/3vNdyqv5uPsZGelK6aYHCFbWEHLZwwJm2YPC29x/EPEMiL3ZzHySemtaTCVSJnowaj1EG+6hCESiyx5rjddifH6TIiTfz7L6KwVcJ4M6tuX7Gg3kAG3vKXBykv1/EMGZLspNnkCHThd8RDWnmVkE3y4ieGMzQ4nSkrRc5Z2/M7/zphorJAvRYL4MQEVGNIfnzFfpjoPaCWM0HvHuP50HYSDSW8MvBMErs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/28/24 at 11:53am, Mike Rapoport wrote: > On Thu, Mar 28, 2024 at 04:32:38PM +0800, Baoquan He wrote: > > On 03/25/24 at 10:56pm, Baoquan He wrote: > > > > > > /* > > > - * Set an approximate value for lowmem here, it will be adjusted > > > - * when the bootmem allocator frees pages into the buddy system. > > > - * And all highmem pages will be managed by the buddy system. > > > + * Initialize zone->managed_pages as 0 , it will be reset > > > + * when memblock allocator frees pages into buddy system. > > > */ > > > - zone_init_internals(zone, j, nid, freesize); > > > + zone_init_internals(zone, j, nid, 0); > > > > Here, we should initialize zone->managed_pages as zone->present_pages > > because later page_group_by_mobility_disabled need be set according to > > zone->managed_pages. Otherwise page_group_by_mobility_disabled will be > > set to 1 always. I will sent out v3. > > With zone->managed_pages set to zone->present_pages we won't account for > the reserved memory for initialization of page_group_by_mobility_disabled. The old zone->managed_pages didn't account for the reserved pages either. It's calculated by (zone->present_pages - memmap_pages). memmap pages only is only a very small portion, e.g on x86_64, 4K page size, assuming size of struct page is 64, then it's 1/64 of system memory. On arm64, 64K page size, it's 1/1024 of system memory. And about the setting of page_group_by_mobility_disabled, the compared value pageblock_nr_pages * MIGRATE_TYPES which is very small. On x86_64, it's 4M*6=24M; on arm64 with 64K size and 128M*6=768M which should be the biggest among ARCH-es. if (vm_total_pages < (pageblock_nr_pages * MIGRATE_TYPES)) page_group_by_mobility_disabled = 1; else page_group_by_mobility_disabled = 0; So page_group_by_mobility_disabled could be set to 1 only on system with very little memory which is very rarely seen. And setting zone->managed_pages as zone->present_pages is very close to its old value: (zone->present_pages - memmap_pages). Here we don't need be very accurate, just a rough value. > > As watermarks are still not initialized at the time build_all_zonelists() > is called, we may use nr_all_pages - nr_kernel_pages instead of > nr_free_zone_pages(), IMO. nr_all_pages should be fine if we take this way. nr_kernel_pages is a misleading name, it's all low memory pages excluding kernel reserved apges. nr_all_pages is all memory pages including highmema and exluding kernel reserved pages. Both is fine to me. The first one is easier, simply setting zone->managed_pages as zone->present_pages. The 2nd way is a little more accurate. > > > From a17b0921b4bd00596330f61ee9ea4b82386a9fed Mon Sep 17 00:00:00 2001 > > From: Baoquan He > > Date: Thu, 28 Mar 2024 16:20:15 +0800 > > Subject: [PATCH] mm/mm_init.c: set zone's ->managed_pages as ->present_pages > > for now > > Content-type: text/plain > > > > Because page_group_by_mobility_disabled need be set according to zone's > > managed_pages later. > > > > Signed-off-by: Baoquan He > > --- > > mm/mm_init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index cc24e7958c0c..dd875f943cbb 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -1561,7 +1561,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > > * Initialize zone->managed_pages as 0 , it will be reset > > * when memblock allocator frees pages into buddy system. > > */ > > - zone_init_internals(zone, j, nid, 0); > > + zone_init_internals(zone, j, nid, zone->present_pages); > > > > if (!size) > > continue; > > -- > > 2.41.0 > > > > > > > > > > if (!size) > > > continue; > > > @@ -1915,6 +1878,7 @@ void __init free_area_init(unsigned long *max_zone_pfn) > > > check_for_memory(pgdat); > > > } > > > > > > + calc_nr_kernel_pages(); > > > memmap_init(); > > > > > > /* disable hash distribution for systems with a single node */ > > > -- > > > 2.41.0 > > > > > > > -- > Sincerely yours, > Mike. >