From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5FEC54E67 for ; Thu, 28 Mar 2024 01:24:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37226B0083; Wed, 27 Mar 2024 21:24:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE7906B0085; Wed, 27 Mar 2024 21:24:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAF416B0087; Wed, 27 Mar 2024 21:24:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BCEF06B0083 for ; Wed, 27 Mar 2024 21:24:15 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 38E65160E4F for ; Thu, 28 Mar 2024 01:24:15 +0000 (UTC) X-FDA: 81944702070.26.C6DD144 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 85E9AC000C for ; Thu, 28 Mar 2024 01:24:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MwpJzT9g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711589053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LilcHusgSvqim2+d+06wj9NkX9jRJyVASh1CxKYlBM4=; b=H6ah4EwiVrPWq8xlmJ0P8c/H/Rr5cNv6KhMiUCLbFO53P03wLaRrjJTuGnnhKQMcakfYBs //gsCM2bk6dhRjzh80pUHExSnMp7hj92h5kXkfSncBJZlYM2ROLkKadvuXuo/aiJYUeXJ3 9EErgUkxe8Zb/eqhPX/ldeFXJE6pN80= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MwpJzT9g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711589053; a=rsa-sha256; cv=none; b=2NE65k1gd0wuB2vkTqgCRSq4qlgtRcOPkKyvcLbf5J3N1EWxs3kq83VhtUbG2fv+Ug32Z3 K4eVV0qKjmnwbsOYHqpkws+/oS1GM08helqVHwGHQmBmoh1G8283GMEm3h67FoeCuEr+1b i1SpcEvCocxaWpbqx1eqsiEw4nExlIc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711589052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LilcHusgSvqim2+d+06wj9NkX9jRJyVASh1CxKYlBM4=; b=MwpJzT9gRTOdrtWRmSICTL4Dn+xI1RX+Bq0xa7/oyftTCf2q8vwnyLv/T8NG2D47k+F81B 51m1NU3CFRF+HpAnXPOlDOM60KXfVrdFsFOuGZRk+ubSCX1M/ykufZkdJk/bnnpuVeK2dD YqDlgxzAKpE/EaK0ozyb0nSA5znH5OA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-pbODCuinOoimN5IXwG6ifw-1; Wed, 27 Mar 2024 21:24:10 -0400 X-MC-Unique: pbODCuinOoimN5IXwG6ifw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 238DA3C0EABF; Thu, 28 Mar 2024 01:24:10 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5369217A9D; Thu, 28 Mar 2024 01:24:08 +0000 (UTC) Date: Thu, 28 Mar 2024 09:24:01 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 5/6] mm/mm_init.c: remove unneeded calc_memmap_size() Message-ID: References: <20240325145646.1044760-1-bhe@redhat.com> <20240325145646.1044760-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Rspamd-Queue-Id: 85E9AC000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wg5cndub3z3fe8irixwgkd4yzf9epqgo X-HE-Tag: 1711589053-394093 X-HE-Meta: U2FsdGVkX18E+zg76OLnaPubzcKbLstzswQEX/bEiXfwAQonjVu6QC9z8hYUgL/eoGvTukai6Mi8LVrBMx2Vgglu9towYQf+dVQ59wkm6bJyNjKkbogXdOIZ4dLY7m8O/v+/s/BhCBED1jK++kb78qJCJ00/743UpvKs9BV8ULiK3TIyZ0a2a32x2H5uK1NmX/knk2o79hc4YeBOmQm95oPbpRQau6SFXLdRL38tbn5/XMMjojQgARivmP8zsWNAxPnjVyDB8hMF6u2KVi/IJ+9mfvKvUa0MC5HpFa8BYn0uOD3t/U2lOb6USjkt4BsDpUmvUIKcwOopOg5LG++qp1Ts2HJk3GdbEh7mdID477deE0ACR5NWJZLdMp9np5c1m2d7UX7fhEEmrTYjCPYAUHy1mcCnKbIXR1srTqmU2hQZXJ7g4YgoN3g++8GOAxzwMANTu59C5A+Op1UT0rtyUX0Sa/Fv+2kM8oW0Ra+SP3rX4A3497rO0mWOyKKvwS1Rhpf98r75IFljddZBVtapNtQI1p/jE60uUD7SymZyhD9ZRhsYRijLUkqz+1xko8d7bswqe1yCsQ6JVhZqh4JRZIBCiyY9IKM4pHPCbtibHzZ5CyU6R0kj2G6VgWzVMOUDP1DwZpkZ031aMtR+kldN0ymYeBMT/Z41ZXFb3AfLWjtFqkxQgJcJCPfeG8i+x3UX+AHMcS+6aHUV/6Hbq6fvLIBhDJEuLD44rSCN05bCm8NCfplEJ7U4ivqF6N+kQ/FTHIPkSzPwxv4b7EW2yfulx6f4ybIrfF81gM0RzOdeVOsN4ztpinZSdsEtXHE9HlIcmKwMMrGh2aLuoo6mAMPxBPyR6HKWLLdDVQO1wa/1gZ7h+nV5RPlT3BqbWdKt/KY5cgM1eO7qJW8dKFtUyUsS3gI7ULV/wuCe6jIIUwlDBYdfpvawAcmTTxJLyaFxHO1/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/27/24 at 06:21pm, Mike Rapoport wrote: > On Mon, Mar 25, 2024 at 10:56:45PM +0800, Baoquan He wrote: > > Nobody calls calc_memmap_size() now. > > > > Signed-off-by: Baoquan He > > Reviewed-by: Mike Rapoport (IBM) > > Looks like I replied to patch 6/6 twice by mistake and missed this one. Thanks for your careful reviewing. > > > --- > > mm/mm_init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 7f71e56e83f3..e269a724f70e 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -1331,26 +1331,6 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > > pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages); > > } > > > > -static unsigned long __init calc_memmap_size(unsigned long spanned_pages, > > - unsigned long present_pages) > > -{ > > - unsigned long pages = spanned_pages; > > - > > - /* > > - * Provide a more accurate estimation if there are holes within > > - * the zone and SPARSEMEM is in use. If there are holes within the > > - * zone, each populated memory region may cost us one or two extra > > - * memmap pages due to alignment because memmap pages for each > > - * populated regions may not be naturally aligned on page boundary. > > - * So the (present_pages >> 4) heuristic is a tradeoff for that. > > - */ > > - if (spanned_pages > present_pages + (present_pages >> 4) && > > - IS_ENABLED(CONFIG_SPARSEMEM)) > > - pages = present_pages; > > - > > - return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT; > > -} > > - > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > static void pgdat_init_split_queue(struct pglist_data *pgdat) > > { > > -- > > 2.41.0 > > > > -- > Sincerely yours, > Mike. >