From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6C6C47DD9 for ; Wed, 27 Mar 2024 19:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4670A6B008A; Wed, 27 Mar 2024 15:25:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4171B6B008C; Wed, 27 Mar 2024 15:25:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8146B0092; Wed, 27 Mar 2024 15:25:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B1796B008A for ; Wed, 27 Mar 2024 15:25:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BDCE014064C for ; Wed, 27 Mar 2024 19:25:53 +0000 (UTC) X-FDA: 81943798986.15.DAE1BE4 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf07.hostedemail.com (Postfix) with ESMTP id E7CE540014 for ; Wed, 27 Mar 2024 19:25:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GgG36Uv6; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711567552; a=rsa-sha256; cv=none; b=tSwGiRcbt5R6Wr7GtmT9Af5asKMgAoUcGWMrEf2tC9yf3CJ5vCiHNWPA26zFW5OF4fyexF +4bmlBHMLYwGDS8qZ8vhMwPLfRJeTZm5r+aGpz/dYE0R1JctEPk8aTE0Mk1NBZQEcAdz8N QOTlIyYdWNkAwqVPbOrQGoz8+V1Nm20= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GgG36Uv6; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711567552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nl8eNBms0Ypy8dIOTW/avUScjvW0EWf64cS1n0rycF0=; b=5mxlUdXBCrzJXhbwvJr8U8jAJ64C+SLYe+ALD578A9lGP0335fUlJu2YZ4S4ySaYtFPZ+l /yUk3Rc6q/MJ2nz/4qdH4mQ+tKVXD7Pa/8MkS3XIeE4AYQGq4HH+4LBjZc16nD6veMEBgF 1i8wd6xYed5jXKmxnUSv0acNqIdX+kg= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1e00d1e13acso1585375ad.0 for ; Wed, 27 Mar 2024 12:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711567551; x=1712172351; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nl8eNBms0Ypy8dIOTW/avUScjvW0EWf64cS1n0rycF0=; b=GgG36Uv6KeZt/8L6j4Q/o9NO27MkTppKpma5sXXK+ig+vkB92oFg8J8JKao/7XsHQM byD3IHSAydXQWFfzLHFszxy5r+JR6jIu3uqkhxqk3xbLvW5+M4hcuU09k/I0g7wQxBZB aFSj52JSsZAHnng93AL3wU3xWvXp40QP+wrn0V/N0InSeEw7EDcYLYd7EoUDPLtE3w1+ yDYkHn/SMgM7S/huyGHM6RNPOzKggguFi0lWp8x0G7vDfUW100p4INVhzYkMFcWIIQq1 dCFTBaQewDNcV4n+V2WGkR8jwixHm204Fe/b/reRrhDWn3RgdLPRIYFGgJv2vQkr+604 P97Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711567551; x=1712172351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nl8eNBms0Ypy8dIOTW/avUScjvW0EWf64cS1n0rycF0=; b=f+gjtrGrb/l2vpypwHBGLLb5bhDrFBxYWw7YkkS+wnhCXyRf+QNqX49Sb5cGBqArkk S+92EET7JpCx0c/yyJLzulhCbnJEVN+vQp6Gpakjw7kEc/xY6uBom2+cjrjd2qGYXQcj PINhuD7Nv6omOz4woAx44UB/MignhWib1lQwtv7fh3nLYmIA9qAikkEuWVjS7XbIIuLE CKfyTTV3I0cNrIhT93MqlIhxTp+YmlRfsJpB4odBWccDT9duebCPhDDoBX/OxbP5OAC0 ehYOiKZq453q+7JHTiiqyyd3kTwHtAirX1n5qBX4SokBM3V8nBYcuLLLfk7Nc1FKzOz7 +jig== X-Forwarded-Encrypted: i=1; AJvYcCWFdknHeXm+s1thDY21dozeG6bTJXzk4B2Kf5Hbp2qWLgsBPQWym047eGislZU0BafKPzYQDU5N9G1qAGH8yHZAHqU= X-Gm-Message-State: AOJu0YwkCmGbX/ZlVfzyJZDhwvXnbcZ8Kf/lGiUFVfZNZKOSwjQi83BX iWQxXAoibK2KAjj45DQgeAIkDpsuDvFPtCjdDDtb04hVE7I9nnlMzZ2rD4QGT1c= X-Google-Smtp-Source: AGHT+IGYfiRrgVXsMUV2nu22JT7tG9NAHWBYfdLcLavIx0jYc2nP+M24nKWYxWtgXqkyzo14EU+XKQ== X-Received: by 2002:a17:903:238b:b0:1de:f840:fb22 with SMTP id v11-20020a170903238b00b001def840fb22mr793660plh.12.1711567550737; Wed, 27 Mar 2024 12:25:50 -0700 (PDT) Received: from fedora (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id d7-20020a170902b70700b001defa2d8e22sm9395699pls.233.2024.03.27.12.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:25:50 -0700 (PDT) Date: Wed, 27 Mar 2024 12:25:48 -0700 From: Vishal Moola To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "David S. Miller" , Andreas Larsson , sparclinux@vger.kernel.org Subject: Re: [PATCH v1] mm: remove "prot" parameter from move_pte() Message-ID: References: <20240327143301.741807-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327143301.741807-1-david@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E7CE540014 X-Stat-Signature: xjn5g77n45ndmw67964yhy53b86cdtn7 X-Rspam-User: X-HE-Tag: 1711567551-383241 X-HE-Meta: U2FsdGVkX1+V8sfIZm5/HosEJTs14DAZArXHRcgQTMQg6s5KKDZpzeM1CwzxY0oO3VlyEoeQgU0U41A0GxOOsl0b0xzlOzoKbboxVYaUYrE8VR8FXOSj9wL+R7PVTpReaU9k8NlgbYu6Y/RSMNb3XO65zebNjIF/3ccYh9R1iMRjbSRxhfCA9R2CBfnEl2Bwgm9MnPAiVMyL/b0xe8NXb6p/3iGIg//mL9vczKPxvs0k9c8VHq9jc3XPVSQ4vUJyBzmaBjuruzvC9yQv4W3LQqzs3VQ1yicI17+ZzKKsgppvGOIR4iz/tTfClWYrFH+oYuyS/mRRCGuDcsy7/HVyZJRpuGb+zaoN2OVX4kDQfSpIc4Ct57jQ7kUzo1paLI2YfAjRg738RGfNZ0QOkCNyLU3HuXJAOlhkr4qcovSwlDIORF+l1zhxKN67Fg+1ltzC6dhUys3HDPPhOliGThlRdx6y4lhpgxjesbXOg1Qia67+/KUV5QrUR7EyFBlh6S3sipWCrppUlOSdbVPj96CsvOZry4+P9cvUPwMq3jWp/gKrdu0oSgYTCQ6QattZqb8qckliChMvb3z4Fv25AH+6VXGXcwWRYvmG594aB9PKWNIM47fFVzRhF9rq7g5KCsic32qkLt1Uh3Q1KcpA6XfmtE6tGVCeTSlLfQ+KudmH1NAXO08CeiAHlaCj4ypvVqWLRvcqiq39avXaRhFPuRiSXHav0YPED7vQbbnitKoI/0N3RF74Mlcs4mm74DDW7ah322ffT5Fg5VTAgrVG2Ii/xkup6beLo4JF69MOowhrJlqEYZemNnPtqgrRgyj7yk5WvGh0rx5S8vrR+pkl3G/2q6sBTpmESw/IMYGVvsLSlKuCzkkdYXXNp8Jsd5ng3oyoKcVboiZO3wte4/GQVgwVpsaQTDEH9BnuML7FD9DI7cs/jdKS5Q6lF1sr1eSKe9yB474l+D2sBkEeRIwF7fu OdOzuXvn tuImIZd0sm1x3C57Dxz3IKV/PMJp2JZtwSXYIXrPZVOaWgQgBusXC6q1sXSVAcKaPQIpE7k2G4D0ZbW6xzw/h/eJtoZJJVwwon4q472dxYZeh9o4qIzTKhJyQ02RTQSYf55Nj5VxkbwXOoIx4B58RlGWYq8djSAfhWxfj2+46Yq7snp3z+IuIyDVUDW5A1rwSEPwmsVysktXEe2hPZZnvd3klrAh1xuVuXR1HuI/gAsqZoL+5NCkXnqCiqqat0pKE6N+c/J24e8x/FhKWlG++1x1VB5h5UpGH9kcSuT4ZPSacYRJ1MfpBQhLgybn0E0Em31oUb9lALwmoZzxxIL2icZh8C7v2HIp9/GPWyohEWwkHNcUy4BVH9LyKsOBbcuyy4anYJHZcCxg5TGwxxkoA/qLN61CWaOZMN8kzj4FWvMS0TO7GO0xTHskg1hxCsiajmfhG7wzfvalKMcI/NqxWJ0rPAoBQxCfAdwGzqe6Z7WdVJ+PyxCdJuwQklqZWetwKEcotwR6+PRUWhiaxYvfB3zSUWY90nQEjsm0sJKp3s3sy4661NGuUhw9J7KfIu3SGMKqVQgLucY2L7sNJ9x9FfYtlsXUh5aLP7neivu6we3xcz17/Je1Y9+zIdATJT33LC7Pu8DJkw9eeT5cap/TQF4T0/m5qOdSmiC4DRQEH4gwmqnbBGvLoLgNTDzZFIl5bXeSp43o/gSzY/cqE0fEqb6NXoGlzeB927B3STvu7HZT90f1CwiqoGN+EQ8TITIHz5+mNGfoBT6w2lQZU4dYcsgNeY19pzHRU+LsP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000830, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 03:33:01PM +0100, David Hildenbrand wrote: > The "prot" parameter is unused, and using it instead of what's stored in > that particular PTE would very likely be wrong. Let's simply remove it. > > Cc: Andrew Morton > Cc: "David S. Miller" > Cc: Andreas Larsson > Cc: sparclinux@vger.kernel.org > Signed-off-by: David Hildenbrand Its interesting looking at how long this has been unused for. Reviewed-by: Vishal Moola (Oracle)