From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAD9C54E67 for ; Wed, 27 Mar 2024 17:41:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A07246B0098; Wed, 27 Mar 2024 13:41:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8096B009B; Wed, 27 Mar 2024 13:41:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87F556B009C; Wed, 27 Mar 2024 13:41:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 687EA6B0098 for ; Wed, 27 Mar 2024 13:41:36 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 37DAE80148 for ; Wed, 27 Mar 2024 17:41:36 +0000 (UTC) X-FDA: 81943536192.26.88FC361 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 252E11A0022 for ; Wed, 27 Mar 2024 17:41:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ce37q6jp; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711561294; a=rsa-sha256; cv=none; b=1d6KkxMWBtRkrtl+TxbdJEcYp25Y/OULgrT65eX08S780yu/j1c+ZThVS6dTGpMuSetVMA +phMnuPJ8EAB2GKxcLcAQx1skvlwwGgtkIsMq9lvH/gWwnYcBlfHtQ6xKoHGqz/Qo2S/Cr 2npnWmNChD/c83cc5geIbgys4uYK5PQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ce37q6jp; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711561294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O1TuGj6QVxTeZpLUQXJVb3h0SEqjbJg//12UastWLxY=; b=KwqKzb6j0RqL0Wc5IP2QwVc1i3h8cXl0i5ml+IMUyvB/Us6pMNZJg42aO6QvlDgIsqDRXk 9FzEdC45nxVk34RkP7rXQzFRMF/UOc+xl0uQU+EZzXv1M1mqtFcHdSLb8GQa73YS1yxD3D Vu9Xq6aEVCi9sIMi02lzsHkl9Hj1QAw= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d475b6609eso87586641fa.2 for ; Wed, 27 Mar 2024 10:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711561292; x=1712166092; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=O1TuGj6QVxTeZpLUQXJVb3h0SEqjbJg//12UastWLxY=; b=Ce37q6jp7tqIRto7rYSmHu/au/TXqWXsS7ZcEkqM9MaefXCawOy6yaZFQDFKw3bl2T LegZEJvGVPiwYhRVEv+m5zQUH/j00BtrPN/OHzo//98iVoHN6pxz3Z1JhpF1RAGdXOrN TlV85pNp7ldFUyozH8g2Dzlje1g+vgDE8VimvbjqW/+T23PUgMSbBee8g6BIk3zoyCxb GoL/0P2Buf92XNDeIVq38US8wHIMgzBQePdYab5gJ5yI0uaw0V3BZsTqwXTJ8FcWVfo8 jTicnoeDXU6qobnKxA3t/NRe8wr/pAhJNQbtUBbluObUBsPelIgUdMhy1QCBKer/A3v9 GIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711561292; x=1712166092; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O1TuGj6QVxTeZpLUQXJVb3h0SEqjbJg//12UastWLxY=; b=geFQG72EyFvilRGOFPkodM2fCqhw+8c4k+5yZlWGCXV/ROHTuj7SndMx68iz0yTmTu i2vTk8xA/y8Zfi5Gtn7RXvgQfbuOw+LJSKsrdGkRhBgvhxVzpf91ohaXB26cqTE97rVn A24GupY93zwIU1pMn6F4i4+GXmXg+H9usDqwUJ5u58k0sqh3h/dhgMQexzGCjhX/zjUl e9MwKpnmvA+D69LgH9eow4YMDpGnH9Bgrk/mVTxMY463JrsqJ/FaKH2jnHfKz4jUgbI6 26WokGRW7tz5NmG/Qz2rVTZVO1+xXRLer52IpT3ZgIfsBK/hd4pwcpNvKEV7KUshLpoj Aalg== X-Forwarded-Encrypted: i=1; AJvYcCWyodK0yre/8Kq5vrl9AVKgFBv2wv5Ktafjs/4r2a4fvfzkuK9vWHSLWnLfZ5Uji3EDx134My7vj4abuXU7GlIkQDg= X-Gm-Message-State: AOJu0YwAGF7WV0fPHi9DAw8jwgMziZlJl4a7mag3fIJr7n6YXHJe5MKW lwoGbF93oYvzYJQO1todMDGMXRjoh9xh3UQukDAmW/KvAdc39gue X-Google-Smtp-Source: AGHT+IG5WJHYVgh7KZRbUnCy+J7+bZpofcwqHQf8eTVHmoTdV88ZZgYId9Mx1rK3LIltZN/hwWW3PA== X-Received: by 2002:a05:651c:4ce:b0:2d6:c61c:90c9 with SMTP id e14-20020a05651c04ce00b002d6c61c90c9mr595418lji.53.1711561292198; Wed, 27 Mar 2024 10:41:32 -0700 (PDT) Received: from pc636 (host-90-235-28-241.mobileonline.telia.com. [90.235.28.241]) by smtp.gmail.com with ESMTPSA id g11-20020a2eb5cb000000b002d6f2e56d0asm367619ljn.69.2024.03.27.10.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 10:41:31 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 27 Mar 2024 18:41:29 +0100 To: Omar Sandoval Cc: Uladzislau Rezki , Jens Axboe , Linux-MM , Andrew Morton Subject: Re: [PATCH] mm: vmalloc: annotate find_vmap_area_exceed_addr_lock() for lockdep Message-ID: References: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 252E11A0022 X-Stat-Signature: 13gx1tu7npogaheh79nxd8dacih78hdg X-Rspam-User: X-HE-Tag: 1711561293-656812 X-HE-Meta: U2FsdGVkX1/4odfmS2eeORWqeYYO6cE07dbT2DzlvReFLpOBjvgAePKbBrEs3VtwZQTItmvEBlrvgkVehPkCNAYX6aNtMxaL/d5r4d7WLv0ue/vnf8kKvtAYKOBfw52TjXaPG/OIHyFdDIlX/dGd0d9c4qr9LYABkHq/438cKXeN1QdyQrPylYbFuS4aJNhMsbHtYDKc8heSbJGb463GuG8orOt03xZzIJJx546ahQYlxERM9btp2KERXQ+CFSLLFB+ACVz9EXuh0Ryn+zaVDSKaTHzBVzhgMsfaLNg6H9gVpgrnsvqkbewV2JlMe0mmX+a3B0mrHSaXsk3IW2RhlR0HnVXKCOBhyypLqwOnbz1wHv5bGrLivdURNAVyRdRMoitdLOBx77EU7q2CRaHZMkBJiafS7jFVAX2Ixw1ow5AwKWFVx2eXIaMWAKHHE6dPk6yH9eyFCYh1ZmraljrO8b6mlZt0JYc2PCZTeNXRAznc00MfIsS7wvOKiHN0t9IpIWQ5luagoanapSgars/PnCgMZgY7tzSlOtLLuq/l+S9s7AnJwy9LRlPA7Y2XHtuULuOaSTI8+LmQv2m5KYMPxotC1m/RKKgQxf+ZWLJnvTNUT3+LkKg6anwGO7PgU9Aw1d/0O8s7P00F+jIZMzofc8mwqBoaWp0yROmIt7AYgOSZfP0FLshAeMEOp2E7QeuYPRpd4eYtpAAKZFei+guNZ909Y5X2926HdJFxzsTKYI7vpFQQ8cDX1tSoZ8MblhyKaPkgFs7KuuNUqHkOd+FwaMfiw190Tqm2Z/YNXwoBJ1P1ZkzaGd2KFl81ZNrCWREeF5Kqv7AywiTmKDa64v3x+dBwOlQnNsA/cJn06ijHicyHxn4GiBrvIgOv7ONBXvYzOvfUlUwmQn4sQwy7Wcygl9nmIYVuSTISLptj3adPasCX/TnQi0fuyR0TUuvZfgglIDMpIdJ6kh2A5Ng+omH rn6fmaMV BZF6Uxhof8Le1IIRofH86YkexmGCFfbmnAVCDe7vZUV/IW07PA78q9fygmv6fmtgTCXOQSlRB83I5TAaFYrXuMPN3ki2Od9kP3kED+khLjwx1DGiyubKFzib1cy9giTLVsRIXTHBKH7Zvmlp0cF0bjX8/rkq3sWZaovsR3Zl3pkzucQqFwmxz2fV3FjblQwdDVdFVQNEWpY040rmdpZHrMe3rXODD1IQq+1MFFb9rqeehjdyB0u7yaYKUNn2l4M/MBPzKNZVTcZoTMBQiw7Q42KP7s2Xsg3TATLvigtNoFAYZGN0xVslYz1WZtjAT7uSSkd2ED2gMtkqm0zznu69Wa7dBYlBlMOxbf7YWmxzJGXoQcP/DFiEYYNnv2bfmJOpNvBf8kuhyBsFXsvj4/wOD9B5xyC5I1OJUkNxlwnrhNAP1dX9Q/Keb8yMBjbSIjaqvgGyAjffsfeEYAUJEkNnUePht9p+4/+iwATO1YiZPvncVMMbGXd3iwFL9kDIFTju2MhakpVW4zXF3dMOAIZxlKrg2TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 10:22:38AM -0700, Omar Sandoval wrote: > On Wed, Mar 27, 2024 at 06:04:59PM +0100, Uladzislau Rezki wrote: > > Hello, Jens, Omar! > > > > > On Tue, Mar 26, 2024 at 04:24:01PM -0600, Jens Axboe wrote: > > > > On 3/26/24 3:25 PM, Jens Axboe wrote: > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > > index 22aa63f4ef63..26a69fa6809c 100644 > > > > > --- a/mm/vmalloc.c > > > > > +++ b/mm/vmalloc.c > > > > > @@ -1032,7 +1032,7 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) > > > > > for (i = 0; i < nr_vmap_nodes; i++) { > > > > > vn = &vmap_nodes[i]; > > > > > > > > > > - spin_lock(&vn->busy.lock); > > > > > + spin_lock_nested(&vn->busy.lock, i); > > > > > va_lowest = __find_vmap_area_exceed_addr(addr, &vn->busy.root); > > > > > if (va_lowest) { > > > > > if (!va_node || va_lowest->va_start < (*va)->va_start) { > > > > > > > > Omar said he tested this and ran into lockdep complaining as it only > > > > supports 8 subclasses. So this patch can't work, but that still leaves > > > > the current kernel code buggy... > > > > > > > It is a bit tricky. Let me rewrite it so a lockdep does not complain. > > > > > > Thank you for your report. > > > > > > > Could you please check and test below? It is based on latest 6.9-rc1 tip. > > I have reworked it a bit and now it does not hold two locks so the lockdep > > should not complain. > > Works here, too. > > Tested-by: Omar Sandoval > Good! I will send out the fix. Thank you. -- Uladzislau Rezki