From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A213FC54E67 for ; Wed, 27 Mar 2024 17:40:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 266336B0095; Wed, 27 Mar 2024 13:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215B66B0096; Wed, 27 Mar 2024 13:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD8B6B0098; Wed, 27 Mar 2024 13:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E445A6B0095 for ; Wed, 27 Mar 2024 13:40:50 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 105A7160CA6 for ; Wed, 27 Mar 2024 17:40:50 +0000 (UTC) X-FDA: 81943534260.19.E425A68 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 1229D14001D for ; Wed, 27 Mar 2024 17:40:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SDl0EWfp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711561248; a=rsa-sha256; cv=none; b=kvumOS4IJN9xYwXu05iLzumwRdr0POcRicN/O97xiWXYwHcZ6vJ8ros2eTvEcKsR0DtH2/ Y1aTt78uLTnOlKYvhp26zRoyFO1qWoHUZnCfNCnNb7t64U5TA/VKQNcuDpdm47j66fZXUS xhrlVgD+9FdSv8XrJCgjGUwje/AfEx8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SDl0EWfp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711561248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TdEq28jidsRxZJOpRkkHP0DzIgI16cGR9stM2x14bdI=; b=DzK2x+xIqEUxtUjXgJJ8vd7lvP6DlUeSTnEvBL/o8vhz4sTZPzU4g1IO9t/zTh+azCSWhl y5x4WvWvuqFBjLwUpSbejf7Pg8sio7fOjFuSoaGIuW1KqjUttFjAeWqD47vVzdJ/5X77xU ExTpIH8UzS1oW4b7Xx/hyt2vRD51WAI= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2d094bc2244so74681fa.1 for ; Wed, 27 Mar 2024 10:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711561246; x=1712166046; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=TdEq28jidsRxZJOpRkkHP0DzIgI16cGR9stM2x14bdI=; b=SDl0EWfp8es/fZyTO+ZB4p9ZDFlD/TES8vZMVd3s8ju9z3x8Y5yWEGNhmjdkQuZ0yO a4pH+so+0f8lOSZ/zfy+4Yu3xwVyh1AM4f/+h+Xd/NhKpnV2eZJt8T6tpAeEkHm6KiJq Tvlahmh1T5ycWbi1jpFTibnMhBMYdanlw1Gda3T8IyxqAyrvg30eRwXJyoBf6Kf1R5y3 P2oYQ4XI5O0pHPs3scJ8ssuro4BSuodduMnTgnnk+c93DlfA00J3CqXRElom0SNr7mxH LefGAmzjzzn0aDos+WYoYwG6gCT0uT4BPNiTsHEcPGKJWKueZwvyfVoakfRx84mqqv8e rhtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711561246; x=1712166046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TdEq28jidsRxZJOpRkkHP0DzIgI16cGR9stM2x14bdI=; b=wxoFIDV4+FzPUg1HhOdg/z6RrBARbRdCbJ+pvULlKtWKCejb/THmzMqOBWtkpew9xp 8KrAq5ZINFY4/Mh1hV9mWLAR2m+PP36xel+BP4fRjCO3LMBK3Ijs81eGpoQZEW4W6UeL birn/dm8hRtRNAHMq2VDeiCkaVm1HsTATcEF007Ej9GC2/JYP6kS8nLB2xJRJ6rTWsLc iBuC1oj5F5JQSSdiK5A2+w57Ih9KpCD2x6Lk2vySmx4l3uiY1knMPyump8w8VInamRdK wP+2gXC+XNwN5Nj3K1tauLWwua0z5tWBH5ilJP8G8rXDWksLkRhYw7fpx9o0xBCEC8k+ XZOA== X-Forwarded-Encrypted: i=1; AJvYcCVDOcvZftLnBL/oDrCrCtrZu30dP0D2K13U+flB7Rf3wCVk0QvEGHJRyekSAEtM7uQiQoLX5FhsmyUP8OYxO0vOEjs= X-Gm-Message-State: AOJu0YytRGm0QPz227zutRLOycDE1Te7h/y99RR2jEDPXPUS6v5tRzBQ FOiMxccTqxZn0bP2pI34G1pmKQzlU/9yz0AqGY0JEhyzYS/RuZOm X-Google-Smtp-Source: AGHT+IHmg/9PuTUdrF9EQMG7WDlmMfpTTNYLMuAvS4RdITVK3wwB4Ea30DBLBFdatCRGt+iuavPRxw== X-Received: by 2002:a2e:bc11:0:b0:2d7:219:78c5 with SMTP id b17-20020a2ebc11000000b002d7021978c5mr421603ljf.10.1711561245918; Wed, 27 Mar 2024 10:40:45 -0700 (PDT) Received: from pc636 (host-90-235-28-241.mobileonline.telia.com. [90.235.28.241]) by smtp.gmail.com with ESMTPSA id m13-20020a2ea58d000000b002d6c88b9addsm1598828ljp.50.2024.03.27.10.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 10:40:45 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 27 Mar 2024 18:40:43 +0100 To: Jens Axboe Cc: Uladzislau Rezki , Omar Sandoval , Linux-MM , Andrew Morton Subject: Re: [PATCH] mm: vmalloc: annotate find_vmap_area_exceed_addr_lock() for lockdep Message-ID: References: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1229D14001D X-Stat-Signature: yqaukpteo5ur7t6wujoq4nxmkpw433yt X-HE-Tag: 1711561247-770881 X-HE-Meta: U2FsdGVkX19sAoV8osrDqYs1iDZXhH+eG4cFlNUd7GyalkCklKzgmgbXdT08885NTqzchMyhx8bak2opdfII5loGXZeNfuVK/PNLtyEGjvPltWC2foD0s74srHSp+qkorW+8DocQ3oMIAg9aju8b185xvNKMHZ74M335QlOpnioT0S0ccJYARmIh46gRlhVkFugSpGifvH8HI4MRiFL2d6WDz1yoSLy8Hp4KLHQLeXhEl21J7Gy4STublvZ9UVZZjJ29YbkeaPrm8YgiXVcvnv3109836zRRMqvMnRG8vUgXaQWmS+l/kg9ETLTOroGCjafI7RTbJsX0zPJdFF09zESsm4AP13FII93K+bTagtORaygeObCgt8qFme4eCzFZxtp26RA2G47SAT3nDUl96HscLDK1BsRpG5EGcl4G/aCJCO2rAFs3uRDbbO+NORuXnu/pVAZ3Bx6H91DKpvRthsYvDr+9PqmmNFzR9PspxiuNSeoFKQ2FSBltgE3mzsivuRPUV04bfENSsjNTizs+lITZvulhaPbxCC5lueeIqCiMwDwLgCWy3htJnj5VMnAXU/5vYt5ilkJW/k4lC22Q0KWREjkTLBIdka5+/ec/qRqqT0lRZYsDGJlcsunUbcH4hrMcw3evwHS99Zo4c4g7cTersHDA8354NY4GvK0PlXtMl20Gm/bLUZ1Tnk4X7I8chdh6Lr0U+h1ouoU9eYoA4DwKnL6LAgm/q2qoIwgptLmNv6VhUQiQ62Ynju822fBeI1e3yhHBL+SCjb3kfZDPw3JR8cx5hzdNvosO8aQiYHtSZ4rcIYS9E+iINAk51JCTb4oEQvabIY/DFc9rbdbnGbdl1E82l8RbZCzE0OYkrXNnem+g4e8EWGWGmr/VEMpq8cxL0XWr1Rjx0i+GPtVSE5BMQGs/Pk352Bn3+iI54Fjb/t79sDxnFybGthw92uOQWIr14qxPpBLnEGZUTPM RqL354Jq kR5efGcz8YhZPJYBW/cBrygemW/G0fzcSS5elr6wiVfy7Qr6zOajdP/8ASzcJc1yKAYzT5NvO4BBOnb1PgJuzaSFQpcnPRQlXOPMLqqZCFerkIOixiTOnY7M4lUVnPlYiYPzQOzfWKh4j4R5/X4Fpdnshn13/wekJkV52kwEYAZObGSFcf/da5AYIJpdfxtp+w9PoAjhgIvP6kF2jNaypGy3etAASHlqwD4Ah4S9D2E+RzjwxBKModlX196Oa0YJa54m62ZDDI2dQkbMX17nDUye78XsvYrDItoBHqqEzF9WLTYFJEGwBL2/yxbUiCiNfQE9H+2sHSuG3g4NVTwWUYm1TQ/oCELzHX//cav+iAPaidilIb/eUejuW+zQNqixa1ipUfwyt1GPu8JWO7Bs6++/sUHGCv3X/tb711iqB1R8BHIZvmeBsHkn/zaUnhK15RlnkZirSGERvoqtVmj5beeP0SAzkvJRGUnAZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 11:21:59AM -0600, Jens Axboe wrote: > On 3/27/24 11:04 AM, Uladzislau Rezki wrote: > > Hello, Jens, Omar! > > > >> On Tue, Mar 26, 2024 at 04:24:01PM -0600, Jens Axboe wrote: > >>> On 3/26/24 3:25 PM, Jens Axboe wrote: > >>>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c > >>>> index 22aa63f4ef63..26a69fa6809c 100644 > >>>> --- a/mm/vmalloc.c > >>>> +++ b/mm/vmalloc.c > >>>> @@ -1032,7 +1032,7 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) > >>>> for (i = 0; i < nr_vmap_nodes; i++) { > >>>> vn = &vmap_nodes[i]; > >>>> > >>>> - spin_lock(&vn->busy.lock); > >>>> + spin_lock_nested(&vn->busy.lock, i); > >>>> va_lowest = __find_vmap_area_exceed_addr(addr, &vn->busy.root); > >>>> if (va_lowest) { > >>>> if (!va_node || va_lowest->va_start < (*va)->va_start) { > >>> > >>> Omar said he tested this and ran into lockdep complaining as it only > >>> supports 8 subclasses. So this patch can't work, but that still leaves > >>> the current kernel code buggy... > >>> > >> It is a bit tricky. Let me rewrite it so a lockdep does not complain. > >> > >> Thank you for your report. > >> > > > > Could you please check and test below? It is based on latest 6.9-rc1 tip. > > I have reworked it a bit and now it does not hold two locks so the lockdep > > should not complain. > > Works for me: > > Tested-by: Jens Axboe > Thanks! I will add tags and send out the patch. -- Uladzislau Rezki