From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62BCC47DD9 for ; Wed, 27 Mar 2024 17:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 402356B00A2; Wed, 27 Mar 2024 13:22:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B1F06B00A3; Wed, 27 Mar 2024 13:22:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2798B6B00A4; Wed, 27 Mar 2024 13:22:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 05C8D6B00A2 for ; Wed, 27 Mar 2024 13:22:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9EB5A01C8 for ; Wed, 27 Mar 2024 17:22:43 +0000 (UTC) X-FDA: 81943488606.20.449CEB9 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf05.hostedemail.com (Postfix) with ESMTP id C378E100030 for ; Wed, 27 Mar 2024 17:22:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=osandov-com.20230601.gappssmtp.com header.s=20230601 header.b=ew7R7ECN; spf=none (imf05.hostedemail.com: domain of osandov@osandov.com has no SPF policy when checking 209.85.210.173) smtp.mailfrom=osandov@osandov.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711560161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ALR7+bogHEvAVP5ECUPySnDBSc7wWIYotIOWlbLWUbQ=; b=wfIh8rzH5puu+TStip4WUkAFAThwTuvSg2hA35+RLJBOTGU7u0oC3SAH/ZPMQgkNW1YrlV lojFZRcoH+qeyLRk7FcVHV2wOHHDM2PBJapCiakRx9J2mA2+fhIeDcC/l/ez9ouSNFI8rg 08qN3/u2ZVjUFG8coVWlRKu/hHExoqY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711560161; a=rsa-sha256; cv=none; b=PElN/2Zg80B5NHOliqky541Q9kgC5OMrD++x9Go+1F1ejSB2rFpLcg3q+wwawvfA2j8VRW fUvqwXAFHXDvKQiMla1XozTLVmrS7pfTiI2GJ+Hs5LjHYOiXLJXgaXrhfeu0mNNb5coRxs fuYuOp3kGGtMYnLQS7Aod4DdZg629Gw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=osandov-com.20230601.gappssmtp.com header.s=20230601 header.b=ew7R7ECN; spf=none (imf05.hostedemail.com: domain of osandov@osandov.com has no SPF policy when checking 209.85.210.173) smtp.mailfrom=osandov@osandov.com; dmarc=none Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e6b54a28d0so85317b3a.2 for ; Wed, 27 Mar 2024 10:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20230601.gappssmtp.com; s=20230601; t=1711560161; x=1712164961; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ALR7+bogHEvAVP5ECUPySnDBSc7wWIYotIOWlbLWUbQ=; b=ew7R7ECNOP/kpB2D7k+cZ2UaYHfgqTdDIDMQLyDecX1eFSfzT0Jt+IcqpMAjQa/03p 3UwHX5xW+jzJo/m4OXKQ0RC3cIA7H64tPuE5Qu82KT/ibKXFuzyiYdplxyKzk7sSyyyk REp4eqHVjqRQjKivD8Qz10kS6BlXCBKOakAQMNfpgFpvPBjLWxzGbV6ZCKQkg+KiXTa6 W/BxxejhGPBuBhP2oYZETLzym1n8KGREK/lo2MQ699l1bgmdpv6kWijwlyYzfP4MMdAV bxOWVCbjcI56eZquRIO/G2WhKn4W2YOLI9M6sNmaIXUZZSHoSMWbaC4sFsJ1BOFqeWNV tsDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711560161; x=1712164961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ALR7+bogHEvAVP5ECUPySnDBSc7wWIYotIOWlbLWUbQ=; b=VCYRuU+KBP1ACrFLFPiAZP6aso52EqQA9X3ZL7OAlcQlJ2y6JtV2CyELQFGZqdhDPa fNsG+HneVysalXDSwqxILLIxZsxk1lMTqjc8HIGYVhQ81qCiutT1OR5HGxho3hNzRAP8 O71SQu4vRDJeg8gC7VXf6JTh3PC1EGia3x2l53NU92OVNSNnuHRyXYm+GpPua3RHhr4Z RsDcfPxnDPwafQuXk05dWKjkFqUForJs/u+AY78lmkbNIqEJmawAYWKAIV3ZtL/K4Ode 3/tGIqUNzf4HJa7/iqxPqvdypyXM9i3mKz+sijCxBalcxsRBTvYXqi9yILTzKYrurcvS j3Vg== X-Forwarded-Encrypted: i=1; AJvYcCXcgShV5Mka2fsBpjpXCrR+9w8U3JjK13xtAKtm940aYA8O5P8lw6M7SYYxhZ+hYiU295wtk4KfbajX1c7XDbnx95w= X-Gm-Message-State: AOJu0YwEg2dUqdAcIMv6AFOBNW6j93Lu98GJgWBRTgDzIwN4WhO6y36p Z08uwVXzEG9NU4WEoeZnXwW7CHeNGbpFUgK8u0DQbHmnKxEyE9BoHRm5OEer3tE= X-Google-Smtp-Source: AGHT+IE3OhW54kKy1RbfOLzi8pJIUzV/ZqQP33bQIpldo9qJHUACnQ60LON9WW41f+Iu3quEhF8KMQ== X-Received: by 2002:a05:6a20:af26:b0:1a3:4a1d:1092 with SMTP id dr38-20020a056a20af2600b001a34a1d1092mr517689pzb.35.1711560160571; Wed, 27 Mar 2024 10:22:40 -0700 (PDT) Received: from telecaster ([2620:10d:c090:500::6:42f8]) by smtp.gmail.com with ESMTPSA id r18-20020aa78b92000000b006e647716b6esm8440884pfd.149.2024.03.27.10.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 10:22:40 -0700 (PDT) Date: Wed, 27 Mar 2024 10:22:38 -0700 From: Omar Sandoval To: Uladzislau Rezki Cc: Jens Axboe , Linux-MM , Andrew Morton Subject: Re: [PATCH] mm: vmalloc: annotate find_vmap_area_exceed_addr_lock() for lockdep Message-ID: References: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C378E100030 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sw5xdjg7ypt9tcz3hk6jifzxfet96uyk X-HE-Tag: 1711560161-523328 X-HE-Meta: U2FsdGVkX184iOSjjXPkmdurPKvkvlYUXeP7unepEQlZySKnYjsMkKfcasSiJtTZyV7ocxs0B5xxtKdsZYZzM6llPFTAmHNve74RNjuOKpV0+JBus50vE/OSDHT2NiwEP0pU7ajoi4YXDxJZ+lCRuA3Hla7vSH1ELT+5WRwyxcWgcvqZ8XfwNO+gXCZGP/g8GjkQ9iHKo3WnIDb62klheVRNVozoh/f87URqBZCYOrHCU9tGrBrSOOATLvgEWbOdXr4Up90F2cYrIqTqnQhoOEE8K+tSCG2DEq8UqzXgJHQ9dGrz1k/uCtFkEVQcpARXbwkHlAaf59zy0NktUWT3q7mTw2xh6kZnd3OwD0N24532qNiM6CbOcq3SpPPdDRLED2VsckS9ykKODCfQqpvrnJjGbKLyDIrj0i5uR0fIQBXAF48QOpYOdO/04ZKIf4KxQSQA28jm2uMwqMR/wV5at5yYkbfVQgxxyjxIISpfjTlzmdYKQzmkzju71OJzAli27bs2LqsTbGdPOllng05qPGo+SrqBa6UI1gjA03mZWCZRYYOm+4+lWrqxIHO0RjpF/lA54xG182orZSlviZtRRYhW1O7igxyX8xZ4KphmrPqBUFPLy127JwPItGIqorhexmV29busfhah1XruOnjJo3wxWC6DfVryoy7fMWS2UbiP/8ga2iM6JlBIrzY5lw6Zg2eDh5pU97CJLuW4cQ84aI6Og2lo1Hc3oJGbK/gSTdLvN2X+NdIjc2lvtDaGmSffsjmZWQ8Rlt1pY1vZ6abWdZtx6HJ4hM9u96OKKl8mAdnFBWsycBvWmEIcouWBFkJo6ZGqGj7XlzPrEId65BtFu4D+obTdy6wCYBrzPuI+PApd+PSorvjAoG0amzCwhCKpAM5bSS47oH7q0vk/mXYqK6DxXvSVtNHaY7EDXDQoWQUY9M8AbKK1H1kpe1eM722t+vtUqrP6RSj9S2lxwoB sKgigUPo kyGlSM4eYQZTQmN7Y+KxUPmwCV+seWQA/jGlSQskqTxpOIORPSetazkgqxpvyrSm6yXEmm/di0g/85bK3ubfcKSGcfDFAiT1pyhHIugh9z9+22gAWaoJ+CHz/dk2OBberiiCs0eFZ8FErJRNOGfPKfRSWVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 06:04:59PM +0100, Uladzislau Rezki wrote: > Hello, Jens, Omar! > > > On Tue, Mar 26, 2024 at 04:24:01PM -0600, Jens Axboe wrote: > > > On 3/26/24 3:25 PM, Jens Axboe wrote: > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > index 22aa63f4ef63..26a69fa6809c 100644 > > > > --- a/mm/vmalloc.c > > > > +++ b/mm/vmalloc.c > > > > @@ -1032,7 +1032,7 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) > > > > for (i = 0; i < nr_vmap_nodes; i++) { > > > > vn = &vmap_nodes[i]; > > > > > > > > - spin_lock(&vn->busy.lock); > > > > + spin_lock_nested(&vn->busy.lock, i); > > > > va_lowest = __find_vmap_area_exceed_addr(addr, &vn->busy.root); > > > > if (va_lowest) { > > > > if (!va_node || va_lowest->va_start < (*va)->va_start) { > > > > > > Omar said he tested this and ran into lockdep complaining as it only > > > supports 8 subclasses. So this patch can't work, but that still leaves > > > the current kernel code buggy... > > > > > It is a bit tricky. Let me rewrite it so a lockdep does not complain. > > > > Thank you for your report. > > > > Could you please check and test below? It is based on latest 6.9-rc1 tip. > I have reworked it a bit and now it does not hold two locks so the lockdep > should not complain. Works here, too. Tested-by: Omar Sandoval