From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0DDC54E67 for ; Wed, 27 Mar 2024 12:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617EE6B0096; Wed, 27 Mar 2024 08:32:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C6FC6B0098; Wed, 27 Mar 2024 08:32:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7066B0099; Wed, 27 Mar 2024 08:32:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A2506B0096 for ; Wed, 27 Mar 2024 08:32:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E15001A0D5E for ; Wed, 27 Mar 2024 12:32:50 +0000 (UTC) X-FDA: 81942758100.26.8C92BC3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 3972140023 for ; Wed, 27 Mar 2024 12:32:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cJsQBQlG; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711542769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l6GZOMZ+j81OaJ382d3JAd6zvAL+ZqNG19CFuQDVLPk=; b=B5YjbioeK6movwT1HP6QvOzg1tAbvwZH/ca2+R03XwqIMym+jnWkuM4ImXUpVSijuP4DYL XcIVO1itnQNc7kAbYJd4KcbUOVJlwiKdcOeHiALur3WPcDoizpy9tCFo8P7On4a0kV5WN7 n4QQhiTldbMFcWfqTeJSPdSVEGCI7MY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cJsQBQlG; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711542769; a=rsa-sha256; cv=none; b=zMksbnWmdCao/woGy8gcvzQZaUjEd3qEUVleA+xao4+zfXwxNqdU0ybrO1JZtQ9TxusyBO 1jKGcN/L1x7YUoj+rYsXo6Ii/qDCAPdGSgr/zUKWUNcQYi42fahrV+3QtBhHsGjhxhLm89 FAFYdZQdOVUVUBLLOiJd0x4LmVwFe/c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l6GZOMZ+j81OaJ382d3JAd6zvAL+ZqNG19CFuQDVLPk=; b=cJsQBQlGZHSZtJpD0rZeloENVv 4Hten8gDfDu3gEft+8N6tNJ5XuKV3Ex997I4AurtmJAKCZVUCm3oQa6QfB72EeJF1x5jme03dsQIW Df3Y0lBQLaHO2NC//OVnBby6yqo9jRXd00mNR62yqV8898L/1HvQpDXqMaPInBwmrz6XmoMM5OxmZ ac9wwPYAjc2bSJ14DmRRdk6ACRqUUsiM6G8VgUHbW3j80YWP72v8Vo9L/1lc4H+W3gJpjJNfKfmKj e4+dKXmLPCykxbfZE0f2Uy6nVrbGDz3c992MNYsnE/apqBjGf2aLBoisVAiwGvKraufV3fTI27ODb xptM7/hA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSSV-00000003qbf-1PIW; Wed, 27 Mar 2024 12:32:47 +0000 Date: Wed, 27 Mar 2024 12:32:47 +0000 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCH] mm: fix unproperly folio_put by changing API in read_pages Message-ID: References: <20240327055406.1339636-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327055406.1339636-1-zhaoyang.huang@unisoc.com> X-Rspamd-Queue-Id: 3972140023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: trr9j7fwr649npbaxxzbetenmgx15t7n X-HE-Tag: 1711542768-43784 X-HE-Meta: U2FsdGVkX1/DcjMoz2VWpBow8qDDZDarBANxMImsVMFrjDV4VJyPy4JoQRSDKUHb3/0WGnaoboyZwCRTMQAJpKMJ9/7KSQ/6dN5SUYmRim7urGmNW2A8CiuwbE8kC8nN1ni/KvQR3m2evc+Q62BtLB3TAqQUmaFFQLkAHIEzjvzXQ55Dz7mC2XywZXErNaA3brXnJpykUx+9/vissvukVr2ArHBkmyVPE2D5oCikP7HL5aSGCjyWmJYWl4hCqefv7ujv1EdAIHZYjrchQ8eCi6GZwAGdv+v7LoXLTZrHei6JxMEzlT4O0hvk3mF316WAsJI4zHyInKlkvWlxULNunvC48YIthx8V9XEfHwuUkDAx0S9o0lT4WmlcA1E5+mGPfzdw3KxrRkF1OV/owLVymr3a4jilUYmHp67vQknj3BkKoJ4UNffq8T4rVgEnc9RH+ZJEoz93qtjBglXoHWaC1udKRn9xLhC2WWWwx8u65ihbXyQXxDCTL2jqt/WTQgHSPNgsg1t83IUAs3haJNRuq6c0FgCVxqlNbPzUiHu/1j0S+Tz0+76Jcca1xOcNTwqYZiAJPvq86VW7ikx5pRStCtf74bcjdFpGjLVJJ42CNjPwAC01IQD1c4G/10Wf9qeJk7g4C06PNhvqev5dpHuTFKMCJkxP8+1b11JKfFRnpyx3DE2+VUTuVHoTwcopWYgsmyF2nLEEB2cW8kBTJuAUZXxqncuy+j/lJFiwQEp5BoSJNpfdihrQZJgbVd7P38U/tUgWcLIRsfc8wen+8aHVUzR0iqRHu83w9/VU3hAM7/39g4Z+guNJkBLw6vz4eBTXSF185m2nFjm9z2U9Iexlxnm6yXuDi8MMcld9pWBp7uzf8b31oU76TIet4i6d58y01/HWJM/w34T+6dWGES0Ls/L+PZnqCkR7n5nDzfnMXcigDlcDtxcV8Ubj6Qqqcdm2FvDd5kOTW9a7vk5i8ax PmC4xjru n8sZ9YAF5DDBh2iu9JP2Ogpjf0HMxk5odO4FZsIUv2l13PajazNa/MP4J/vcAqSu3bCvSEeXnLjT76rly4OBOuOiWaV+fMd09rnAiQdxzNxrPPCYAGn0kKspAi3o9LCsHajbeEUc1v+Oxiuh96kx+JcsXkrtMHYaNdDL+ITLPuZx7rTPpcwnVXc0mP2PenIUDuZVtfILhagUacvnbY7nUM9/uH+49jfByHzcXjzz9NVrvQLBLjV45xq3jlFYO9fiWOCAY9U00RGXRxwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 01:54:06PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > According to the comments of readahead_page[3], the refcnt which > represents page cache dropped in [1] makes sense for two reasons, '1. > The folio is going to do IO and is locked until IO done;2. The refcnt > will be added back when found again from the page cache and then serve > for PTE or vfs' while it doesn't make sense in [2] as the refcnt of > page cache will be dropped in filemap_remove_folio. NAK, per previous email.