From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0AFCD1284 for ; Wed, 27 Mar 2024 12:10:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD546B0085; Wed, 27 Mar 2024 08:10:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ABC76B0087; Wed, 27 Mar 2024 08:10:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 656316B008A; Wed, 27 Mar 2024 08:10:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 479596B0085 for ; Wed, 27 Mar 2024 08:10:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D4EBA122D for ; Wed, 27 Mar 2024 12:10:24 +0000 (UTC) X-FDA: 81942701568.30.6918FA1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id C7942180009 for ; Wed, 27 Mar 2024 12:10:20 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rF1gxh5g; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711541421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WStYxaWmdcAd0EHdZG7F8WzduUaXJH+PLdTWTFJ9Was=; b=hUbIkbscBc01kPnh3qsnX0WaCnaZXAQ0+n5OQMSyVSH6RelaJoV4luQIe/oftrlm6upPWL a9Fbdi4ctCsityQc5VF8H0+GqTjmxLDC3toOpmFJZ1Dw1QYiun2/RT4Ha5GgzOfBJemee2 zwaOUtWo3PrMnr04rLcGQRpr8r3bNTA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711541421; a=rsa-sha256; cv=none; b=qoV66mzBiJ43vT+CUbLiUixs7eFITiRV1wJWSxWhl8XQqcHdLIqOYFm7IEGSMxekQkiSzS lwa/ckH3VavC6nftvNsuA1B92+7F6IOXUzWc1CvrVT/UPzv/2weWKjFzlLihSzaDGKTxVO XRkQbO4iH6HzEMKkhrw3gEskkIUJQ9w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rF1gxh5g; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WStYxaWmdcAd0EHdZG7F8WzduUaXJH+PLdTWTFJ9Was=; b=rF1gxh5geKNCFhMxyw1MJ6ZYRi XSYU32Cju0TUtaZK/8AUtAXqCfpPT5DCMbGbZY6EuHenzsaWIwA7vRY6OWkWpEjRpp4g5eFBY+l5p k+U678aYExmKK+QIJ+fUZGMHZuvMkGTFuDsA19ladr17nHufjRzQVSy1MwJ+Iv3o4XB5wvBmrcUDd e/6wCnJuLUiKH4lDwbnBioVxD3tFXOd7UQUiVA6Yu1ChvQ5rmT7ZY24LJH0dv7sVptOogsRs2mYhv z6IdmbsABmiFpvXjZ0JaOtzwViy9Hud8tjb6+V4Y5QScWR9tLBPcTIJsRYas2NrWDdUp+VxcWQ+ng UXuwnJKg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpS6Z-00000003nvt-482Q; Wed, 27 Mar 2024 12:10:08 +0000 Date: Wed, 27 Mar 2024 12:10:07 +0000 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCH] mm: get the folio's refcnt before clear PG_lru in folio_isolate_lru Message-ID: References: <20240327075516.1367097-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327075516.1367097-1-zhaoyang.huang@unisoc.com> X-Rspamd-Queue-Id: C7942180009 X-Rspam-User: X-Stat-Signature: 3yd6m1f5komfo5thrc96ahmdojx8hbps X-Rspamd-Server: rspam03 X-HE-Tag: 1711541420-191757 X-HE-Meta: U2FsdGVkX1+e+Vra4EWw7p1pU6jtsUKSJvTbxeK1pCqluR7L4tZuVmr+54h4z5EbRtjy6ndLyLv3YAEoLNhP1UM7dVQU7tOdVJmYUUkNQl1Kp/iJUP0kwhlV+O/buB6etcxlh9uXu8Fy5gEF6gLnJstePucbrWd0jfv6vLfsnUeQVTEzLHoFMZux09fqBZb8xkdmmCvnQgyWy/PfEgUdILCvV4F9I5TK/xsnafV2BEzhX8Y+O8xlRHc/gPl9cgzQv7hyCMkl7fczLCCHaMb9FolFg8Kmaab+qWQJBAlTp5jHu58c1FBuH8mNMgawMynwaPoILdrWvo5wr7ztzNpjz/+L4Wr95Ipik7Db8rbKRi1xyOczyppeRoBKfFxNXsoha7oqh/9KD7YozSfjXvvX+XqrOds09t6aY1OiZGTLzafa3fW8yq4JUbLodPsN2qN4jK/EgxatSLeqRVGbmPdUMhEgWp2O4QUs/YItXuSnpJeMZlGtxhYkkowcl94Tx6oY11pxU91hqwHkqqKEBXKAWY1/XIMc68j1pjETgtTH2Yjr6mbL40lFwldBm7D6kXI9mms11REBC/2+Dc2eABIHWtbaW1/4Joc980ce3Hzie1VAoiJy8sBIoUeBNnksSIur1d0S3wIe+BRZL83lN4Iaj0S31zC7Y9eWZRIlzaLFikU1xJneqV872aAh6R73SVIegJJD5Ca9oUAJpO2v/i0mj0bNJhzEqhxs5rJC3NJF9RVjyTJjcTGs/Re1F/dtN8IU825P0XFpCpv2Kgys4pdRIM2LmCHvhOr65lPBONmJvmQ+XNa2Gc4dhhXxgB+J5VuPYK4z9jRbldyRQAzoBuzUZUw8h5aQpnKzxyyU8YcUtaqniEmJRu8Jt4HI5GAqSfg7s5jOtanPyQLtSal2ut9SzoIO+quSxavxVvv6ek0OOqZu3ZS2gUXE2eldQ/BnGjdPjbiljZjI/jqDcsVTM6F O80wy1wQ cuyte7x3rRVo4wqRplqC/4leBNtx8vuxGFqivvd7vWKFsS7owyEMgJokP7migaQ3pT47eczaJwaqE1zMoYm17dNsSY+ARPNBUp+SIMxHVR32JeVFCF/swsZ8NDm40MlG1Mda837uB2tGWNI64m4GErguHgIkpY97MBaC6vybO+OpRW8JoKG7ybPVrXUIsljQe6oi7mFKVvhFpsmRI8wmYn1y0kUyqiSlFBbT+m1UnIo5SLEnT6jZbk2C/Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 03:55:16PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Bellowing race happens when the caller of folio_isolate_lru rely on the > refcnt of page cache. Moving folio_get ahead of folio_test_clear_lru to > make it more robust. No, as explained to you multiple times before.