From: Baoquan He <bhe@redhat.com>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, rppt@kernel.org, mgorman@suse.de
Subject: [PATCH v2 4/7] mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()
Date: Wed, 27 Mar 2024 20:06:45 +0800 [thread overview]
Message-ID: <ZgQL1WOf9K88nLpQ@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240326061134.1055295-5-bhe@redhat.com>
When CONFIG_NUMA=n, MAX_NUMNODES is always 1 because Kconfig item
NODES_SHIFT depends on NUMA. So in !NUMA version of build_zonelists(),
no need to bother with the two for loop because code execution won't
enter them ever.
Here, remove those unneeded codes in !NUMA version of build_zonelists().
Signed-off-by: Baoquan He <bhe@redhat.com>
---
v1->v2:
Remove the unused local variables to fix lkp reported warning.
mm/page_alloc.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 14d39f34d336..d35b4cbeffbd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5180,37 +5180,13 @@ static void setup_min_slab_ratio(void);
static void build_zonelists(pg_data_t *pgdat)
{
- int node, local_node;
struct zoneref *zonerefs;
int nr_zones;
- local_node = pgdat->node_id;
-
zonerefs = pgdat->node_zonelists[ZONELIST_FALLBACK]._zonerefs;
nr_zones = build_zonerefs_node(pgdat, zonerefs);
zonerefs += nr_zones;
- /*
- * Now we build the zonelist so that it contains the zones
- * of all the other nodes.
- * We don't want to pressure a particular node, so when
- * building the zones for node N, we make sure that the
- * zones coming right after the local ones are those from
- * node N+1 (modulo N)
- */
- for (node = local_node + 1; node < MAX_NUMNODES; node++) {
- if (!node_online(node))
- continue;
- nr_zones = build_zonerefs_node(NODE_DATA(node), zonerefs);
- zonerefs += nr_zones;
- }
- for (node = 0; node < local_node; node++) {
- if (!node_online(node))
- continue;
- nr_zones = build_zonerefs_node(NODE_DATA(node), zonerefs);
- zonerefs += nr_zones;
- }
-
zonerefs->zone = NULL;
zonerefs->zone_idx = 0;
}
--
2.41.0
next prev parent reply other threads:[~2024-03-27 12:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 6:11 [PATCH 0/7] mm/init: minor clean up and improvement Baoquan He
2024-03-26 6:11 ` [PATCH 1/7] mm: move array mem_section init code out of memory_present() Baoquan He
2024-04-02 8:19 ` Mike Rapoport
2024-04-04 1:38 ` Baoquan He
2024-03-26 6:11 ` [PATCH 2/7] mm/init: remove the unnecessary special treatment for memory-less node Baoquan He
2024-04-02 8:32 ` Mike Rapoport
2024-04-04 3:23 ` Baoquan He
2024-04-09 15:40 ` Mike Rapoport
2024-04-10 3:38 ` Baoquan He
2024-04-10 3:35 ` [PATCH v2 " Baoquan He
2024-03-26 6:11 ` [PATCH 3/7] mm: make __absent_pages_in_range() as static Baoquan He
2024-04-02 8:29 ` Mike Rapoport
2024-03-26 6:11 ` [PATCH 4/7] mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists() Baoquan He
2024-03-27 12:06 ` Baoquan He [this message]
2024-03-26 6:11 ` [PATCH 5/7] mm/mm_init.c: remove the outdated code comment above deferred_grow_zone() Baoquan He
2024-04-02 8:30 ` Mike Rapoport
2024-03-26 6:11 ` [PATCH 6/7] mm/page_alloc.c: don't show protection in zone's ->lowmem_reserve[] for empty zone Baoquan He
2024-03-26 6:11 ` [PATCH 7/7] mm/page_alloc.c: change the array-length to MIGRATE_PCPTYPES Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgQL1WOf9K88nLpQ@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox