From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15859C47DD9 for ; Wed, 27 Mar 2024 15:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C8916B0085; Wed, 27 Mar 2024 11:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 978E26B0088; Wed, 27 Mar 2024 11:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 840B36B008A; Wed, 27 Mar 2024 11:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 659996B0085 for ; Wed, 27 Mar 2024 11:21:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9E6EE40E4B for ; Wed, 27 Mar 2024 15:21:50 +0000 (UTC) X-FDA: 81943183980.17.398C64D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 6D10CA0022 for ; Wed, 27 Mar 2024 15:21:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YUbjyiWF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711552908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=zwZSlPUbvaRXUm1oU0F5TR1ZDp8LewFebHwFwlxqkErE86Or3fLkjEO5Z1aNf8JGQonKpY 6EtaplU72zDFjlGcWMwBr689tQpb8gvKuvZ3aUcPZ1c5dUrsg2KVpKpkJOk7FCrONP1ueO zYmTkwosYnnDLb+V5Ai5dtJ6XeXtUNA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YUbjyiWF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711552908; a=rsa-sha256; cv=none; b=kdF5m5anj5z8CP0CWWWp7J6e5RKIHOEOAKU2ksUxPtxJWftOyf2RJIL5UzYUYhu0z0NP3d Rstk03zJveQeiMLnoNidUa0qn2W3KleTbbL0wOzJk6WhpNrQIvALHcK+VAEc930qW+/pL0 abB2fxqiDGtUXKMSHY7BOCIkPrbnav0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711552907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=YUbjyiWFAtdkzqWR831+PC1L1Sg5hlrxk5kUT2nTQQ/vbz4OpDQjVIGe2FVx6VnWv80nZE sAYEDfrV3vKuYaNoUUHUugr4H44Pb0YvD+mFekAXv8NhvOkk1PVBV3zUQPGwUjnXzbZw+p 9NBH/h6Jy5qy9u49+Zw2c4ZqVrS94gY= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-QDreEIXyNPaPItkcQdPY6w-1; Wed, 27 Mar 2024 11:21:44 -0400 X-MC-Unique: QDreEIXyNPaPItkcQdPY6w-1 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-6e4fe655c93so2425758a34.1 for ; Wed, 27 Mar 2024 08:21:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711552903; x=1712157703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=kzbBOD/cY0RfC9/+ioWZ22q4WjGCgVHzAIbmbM0BwTtSfCMfpnL9xG3ihFg7KpmmDh EkuLv9kHY4VwSQEfgWoID0w9gAUiOO5XLGBzeL73VSpTmWIBn7TJLetnL4S8ZKiTb3UE HEPXsSnYrGL1Vy0Zj2hBgOUM08UbohO2T75s4awmsUKeC8T6zChYjTiSkh+DqdLJ1cF5 7KTGWQ8ijMun/18Br973wEHaNVDxwGaGW0e2ePs6knP9aCz0IAW2XvukYpY/PxhSsc3L q0wYx+uriHlYYM6vhN7RqGnyt2MNctR1rY3Ch3vXTA8Hv8rnrpjlXM0Z0+BfWEAC16Ac tkdQ== X-Forwarded-Encrypted: i=1; AJvYcCVgRh01rfJdpZ0/x1kS5DvNSfpQFNnOTwd1TT2nG8H1fS2hbP7NwZCknizu/IOOcAITeGoLGP17YJ6D2yy8bj5zntU= X-Gm-Message-State: AOJu0YxLQp5F2y+x4ZNsjm0u8AaYFXS4odWTzYlUKZQPYNkNKlgc3elD lHVHIju/mR80BQi6U+PnzPB6eNW43IKVWRxt/uSvUHGYQQeZ3oILiJAC/omYEwlsgj7sairQVOW FsOW+vNzGj8kdHWDF1P5dq2cNQ18FqmYLNDJhmPZ1XZtgrO8k X-Received: by 2002:a05:6808:128a:b0:3c3:d729:1d56 with SMTP id a10-20020a056808128a00b003c3d7291d56mr316753oiw.0.1711552903442; Wed, 27 Mar 2024 08:21:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxT5qAZWntttFMbBHTXwtvywmg90pV0zoL9F4zS7SQ4GsHwDy+Ru4KfcRdtRpsXZfeVg5bqg== X-Received: by 2002:a05:6808:128a:b0:3c3:d729:1d56 with SMTP id a10-20020a056808128a00b003c3d7291d56mr316719oiw.0.1711552902921; Wed, 27 Mar 2024 08:21:42 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id r15-20020a056214212f00b0069698528727sm2350243qvc.90.2024.03.27.08.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:21:42 -0700 (PDT) Date: Wed, 27 Mar 2024 11:21:40 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast Message-ID: References: <20240327130538.680256-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240327130538.680256-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 6D10CA0022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1b8erckk7natp6fskd95smjkkcs643fo X-HE-Tag: 1711552908-590484 X-HE-Meta: U2FsdGVkX18q1Z+lfiLLSHTms4nl+ihdt3VcF42jW4RyqWeIFlbS8KQinIcswu/WHKiAjnTksSs5xv4n2kQ0UFT5d5pwqCPFZyD09aLoYxP4T7I5FV3o7+OwO/ZKsOfcFb0PzDR17CTReecKyVCuWJ8LvoNQ5DoDYBKPCqXeRgY5GHNWwtxySFpR7E8hI+mjFLTah9TgtgrSfZ64ta0dG04ggqJxt1BY4D3jurQgqrKWwKCdpYrfYWKihNE38aw2b66QG4Pg6YoVo+Phncw920QY6+GhX26P54HvTpLv5Ym549M0JDc5i2ic8Y0K2dSDmNwrMTmlviXHLq9IqBahiO6kwaxQiRiyMssA17IRDFQd/PCe3DX8wLBS9PEaqfNB2zVPRgYkmRmYfdWrGuhXCHsPfQgUBYEAU/1SsjEIpQRbeAeBdKKzx7vsGTfgwuNnENrRBb6R2bTSYii7XoNYK2qjg8TUK3LLouu3tklK4cr/LqtiCG1cZj2FS4WSmNcQfiJh6pR4Aowm4FqodACRmRHX1NljeTN7jQaOo7dij0xBQ+POZnd7slo/x2mFSJuUVKmERj2xjurBGs0wB1kZSr2hSnl42W/wtZygMq927JNT8Yn5cRZ7f5abS0N79zKsdT4vmho0vR0dJTnwxaunoIsUSyydoGxQDosKBOW8ruHoehK7v8SRsjyeelfhfFxA2fLxbtbG6dsn1dRI3SUic6M0/TZJrhD+pz+WcvEi6vIlEY8/X8WYSPF4xwAUXWUxFVp+7JiYaKQQWyUB/ce1pTtYGksmOLGvp1HJlVsB2igYVZ+ZHmCEq+1pbx1HG1uBNUvi0UfW9rsXMjOAlufw0UDqJgRf+Xmd41GS/yjvAl+Fuc8MOdF6sAZZfeyZvYpk7quHCc4MCvOfoXZblPzQ5SedvCj/3vIBNRbzXLcYyDyXDx5hen90czxHfJe8hxYD9jlY6MsYuxINYRU8wyC aFZTqo6U rwqQMfI2nWm+FE9OGc+uxMDZ8KT6wDieGKxShWtBkm8YiqvJaVkSfkN6VEhTzRIvMbe9KJKaWkXy0B7ZNNDli+NL7FMUdMESeiozyu55vRYdV/RAcNOnjEAQglg24XsRwbd3kyWLsrvG8VTdEkKqw8iGC5p8iE3cukJ0eeY87rZEv1K4RRCnX1duBoFT7b1/WoxKVVgD9B3NneQRLswKE6SKLggmplE8u9Bguwg7vjCcJuwmEicqm/GW/qbXGL6pbolDOibG4qMtymvygQKEbiKTE/uDRUiuzzEIKW/fNicRNpehMPAaffp5yKjDHeH2+3AAQOUJrR+bi1o93JS2WmkQKIo247lkpkLMGIh9LEYAkyV03o2UZ7SSvb8HLADEC0UykOlxlJFTK3nG7eEHPslGHie427nCM8BYDMhKGSvorvHaIuTQfEfFm5TcrVesemLuSiY9muQ1pjg4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 02:05:35PM +0100, David Hildenbrand wrote: > Some cleanups around function names, comments and the config option of > "GUP-fast" -- GUP without "lock" safety belts on. > > With this cleanup it's easy to judge which functions are GUP-fast specific. > We now consistently call it "GUP-fast", avoiding mixing it with "fast GUP", > "lockless", or simply "gup" (which I always considered confusing in the > ode). > > So the magic now happens in functions that contain "gup_fast", whereby > gup_fast() is the entry point into that magic. Comments consistently > reference either "GUP-fast" or "gup_fast()". > > Based on mm-unstable from today. I won't CC arch maintainers, but only > arch mailing lists, to reduce noise. > > Tested on x86_64, cross compiled on a bunch of archs, whereby some of them > don't properly even compile on mm-unstable anymore in my usual setup > (alpha, arc, parisc64, sh) ... maybe the cross compilers are outdated, > but there are no new ones around. Hm. I'm not sure what config you tried there; as I am doing some build tests recently, I found turning off CONFIG_SAMPLES + CONFIG_GCC_PLUGINS could avoid a lot of issues, I think it's due to libc missing. But maybe not the case there. The series makes sense to me, the naming is confusing. Btw, thanks for posting this as RFC. This definitely has a conflict with the other gup series that I had; I'll post v4 of that shortly. -- Peter Xu